From: Sabrina Dubroca <sd@queasysnail.net>
To: Siddh Raman Pant <siddh.raman.pant@oracle.com>
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] udp: Move back definition of udpv6_encap_needed_key to ipv6 file.
Date: Thu, 23 Oct 2025 12:17:37 +0200 [thread overview]
Message-ID: <aPoAwV8fHvYuC2Md@krikkit> (raw)
In-Reply-To: <20251023090736.99644-1-siddh.raman.pant@oracle.com>
2025-10-23, 14:37:36 +0530, Siddh Raman Pant wrote:
> It makes less sense to remove define of ipv6 variable from ipv6 file
> and put it in ipv4 file and declare it in ipv6 file, which was done
> in 3d010c8031e3 ("udp: do not accept non-tunnel GSO skbs landing in
> a tunnel").
It would be good to CC all the authors and reviewers of the patch(es)
you're mentioning.
> So let's move it back to ipv6 file. It also makes the code similar -
> the key is defined right above the respective enable function.
I don't think that works with CONFIG_IPV6=m. The ipv4 code will need
to access the key via udp_encap_needed().
> Signed-off-by: Siddh Raman Pant <siddh.raman.pant@oracle.com>
> ---
> I'm not sure why ipv4 key is exported using EXPORT_IPV6_MOD?
So that the ipv6 code can use it via
udp_encap_needed()/udp_unexpected_gso() when it's built as a module.
--
Sabrina
next prev parent reply other threads:[~2025-10-23 10:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-23 9:07 [PATCH] udp: Move back definition of udpv6_encap_needed_key to ipv6 file Siddh Raman Pant
2025-10-23 10:17 ` Sabrina Dubroca [this message]
2025-10-23 10:24 ` Siddh Raman Pant
2025-10-24 14:40 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPoAwV8fHvYuC2Md@krikkit \
--to=sd@queasysnail.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=siddh.raman.pant@oracle.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).