From: Ido Schimmel <idosch@nvidia.com>
To: David Ahern <dsahern@kernel.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
pabeni@redhat.com, edumazet@google.com, horms@kernel.org,
petrm@nvidia.com, willemb@google.com, daniel@iogearbox.net,
fw@strlen.de, ishaangandhi@gmail.com, rbonica@juniper.net,
tom@herbertland.com
Subject: Re: [PATCH net-next 0/3] icmp: Add RFC 5837 support
Date: Thu, 23 Oct 2025 14:19:13 +0300 [thread overview]
Message-ID: <aPoPMXrfAlSnbgA8@shredder> (raw)
In-Reply-To: <410cd787-0085-4409-97c1-2019a7baab8b@kernel.org>
On Wed, Oct 22, 2025 at 11:29:20AM -0600, David Ahern wrote:
> For the set:
> Reviewed-by: David Ahern <dsahern@kernel.org>
Thanks!
> Did you try testing this with an older kernel versions on the receiving
> side of the icmp packet? ie., making sure older code does not have a bad
> reaction to the extra data in the icmp.
I didn't touch the ICMP receive path so I don't expect any regressions
there. The only open question there is if the kernel will be able to
correctly parse the ICMP extensions when the IP{,6}_RECVERR_RFC4884
socket options are used, but like I told Willem, I don't expect any
problems given that traceroute, wireshark and tcpdump parse these
packets just fine [1].
[1] https://lore.kernel.org/netdev/aPnw2PkF3ZMP9EJr@shredder/
next prev parent reply other threads:[~2025-10-23 11:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-22 6:53 [PATCH net-next 0/3] icmp: Add RFC 5837 support Ido Schimmel
2025-10-22 6:53 ` [PATCH net-next 1/3] ipv4: " Ido Schimmel
2025-10-22 22:00 ` Willem de Bruijn
2025-10-23 8:35 ` Ido Schimmel
2025-10-22 6:53 ` [PATCH net-next 2/3] ipv6: " Ido Schimmel
2025-10-22 6:53 ` [PATCH net-next 3/3] selftests: traceroute: Add ICMP extensions tests Ido Schimmel
2025-10-22 22:12 ` Willem de Bruijn
2025-10-23 9:09 ` Ido Schimmel
2025-10-23 15:39 ` Ido Schimmel
2025-10-23 21:25 ` Willem de Bruijn
2025-10-22 13:26 ` [PATCH net-next 0/3] icmp: Add RFC 5837 support Jakub Kicinski
2025-10-22 13:58 ` Ido Schimmel
2025-10-22 15:10 ` Jakub Kicinski
2025-10-22 15:35 ` Ido Schimmel
2025-10-23 0:38 ` Jakub Kicinski
2025-10-24 1:48 ` Jakub Kicinski
2025-10-24 14:50 ` Ido Schimmel
2025-10-24 15:04 ` Jakub Kicinski
2025-10-22 17:29 ` David Ahern
2025-10-23 11:19 ` Ido Schimmel [this message]
2025-10-23 13:39 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPoPMXrfAlSnbgA8@shredder \
--to=idosch@nvidia.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=horms@kernel.org \
--cc=ishaangandhi@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=rbonica@juniper.net \
--cc=tom@herbertland.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).