[PATCH net-next 1/2] dibs: Remove reset of static vars in dibs_init()

[PATCH net-next 1/2] dibs: Remove reset of static vars in dibs_init()

[Alexandra Winter]

'clients' and 'max_client' are static variables and therefore don't need to
be initialized.

Reported-by: Mete Durlu <meted@linux.ibm.com>
Signed-off-by: Alexandra Winter <wintera@linux.ibm.com>
---
 drivers/dibs/dibs_main.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/dibs/dibs_main.c b/drivers/dibs/dibs_main.c
index 0374f8350ff7..b015578b4d2e 100644
--- a/drivers/dibs/dibs_main.c
+++ b/drivers/dibs/dibs_main.c
@@ -254,9 +254,6 @@ static int __init dibs_init(void)
 {
 	int rc;
 
-	memset(clients, 0, sizeof(clients));
-	max_client = 0;
-
 	dibs_class = class_create("dibs");
 	if (IS_ERR(dibs_class))
 		return PTR_ERR(dibs_class);
-- 
2.48.1

[PATCH net-next 2/2] dibs: Use subsys_initcall()

[Alexandra Winter]

In the case of built-in modules, the order of module_init() calls are
derived from the Makefiles.

Use subsys_initcall() for the dibs module, to make sure dibs_init() is
executed before dibs clients like smc and dibs devices like ism are
initialized. So future dibs client or dibs device modules can use
module_init() without the risk of getting the order in the Makefiles wrong.

Reported-by: Mete Durlu <meted@linux.ibm.com>
Signed-off-by: Alexandra Winter <wintera@linux.ibm.com>
---
 drivers/dibs/dibs_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dibs/dibs_main.c b/drivers/dibs/dibs_main.c
index b015578b4d2e..dac14d843af7 100644
--- a/drivers/dibs/dibs_main.c
+++ b/drivers/dibs/dibs_main.c
@@ -271,5 +271,5 @@ static void __exit dibs_exit(void)
 	class_destroy(dibs_class);
 }
 
-module_init(dibs_init);
+subsys_initcall(dibs_init);
 module_exit(dibs_exit);
-- 
2.48.1

Re: [PATCH net-next 1/2] dibs: Remove reset of static vars in dibs_init()

[Alexander Lobakin]

From: Alexandra Winter <wintera@linux.ibm.com>
Date: Thu, 23 Oct 2025 17:06:35 +0200

> 'clients' and 'max_client' are static variables and therefore don't need to
> be initialized.
> 
> Reported-by: Mete Durlu <meted@linux.ibm.com>
> Signed-off-by: Alexandra Winter <wintera@linux.ibm.com>

Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>

> ---
>  drivers/dibs/dibs_main.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/dibs/dibs_main.c b/drivers/dibs/dibs_main.c
> index 0374f8350ff7..b015578b4d2e 100644
> --- a/drivers/dibs/dibs_main.c
> +++ b/drivers/dibs/dibs_main.c
> @@ -254,9 +254,6 @@ static int __init dibs_init(void)
>  {
>  	int rc;
>  
> -	memset(clients, 0, sizeof(clients));
> -	max_client = 0;
> -
>  	dibs_class = class_create("dibs");
>  	if (IS_ERR(dibs_class))
>  		return PTR_ERR(dibs_class);

Thanks,
Olek

Re: [PATCH net-next 2/2] dibs: Use subsys_initcall()

[Alexander Lobakin]

From: Alexandra Winter <wintera@linux.ibm.com>
Date: Thu, 23 Oct 2025 17:06:36 +0200

> In the case of built-in modules, the order of module_init() calls are
> derived from the Makefiles.
> 
> Use subsys_initcall() for the dibs module, to make sure dibs_init() is
> executed before dibs clients like smc and dibs devices like ism are
> initialized. So future dibs client or dibs device modules can use
> module_init() without the risk of getting the order in the Makefiles wrong.
> 
> Reported-by: Mete Durlu <meted@linux.ibm.com>

Was this reported on LKML, so that you could add a 'Closes:' tag with
the link here or the report was internal?

> Signed-off-by: Alexandra Winter <wintera@linux.ibm.com>

Either way,

Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>

> ---
>  drivers/dibs/dibs_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dibs/dibs_main.c b/drivers/dibs/dibs_main.c
> index b015578b4d2e..dac14d843af7 100644
> --- a/drivers/dibs/dibs_main.c
> +++ b/drivers/dibs/dibs_main.c
> @@ -271,5 +271,5 @@ static void __exit dibs_exit(void)
>  	class_destroy(dibs_class);
>  }
>  
> -module_init(dibs_init);
> +subsys_initcall(dibs_init);
>  module_exit(dibs_exit);

Thanks,
Olek

Re: [PATCH net-next 1/2] dibs: Remove reset of static vars in dibs_init()

[Dust Li]

On 2025-10-23 17:06:35, Alexandra Winter wrote:
>'clients' and 'max_client' are static variables and therefore don't need to
>be initialized.
>
>Reported-by: Mete Durlu <meted@linux.ibm.com>
>Signed-off-by: Alexandra Winter <wintera@linux.ibm.com>

Reviewed-by: Dust Li <dust.li@linux.alibaba.com>

Best regards,
Dust

>---
> drivers/dibs/dibs_main.c | 3 ---
> 1 file changed, 3 deletions(-)
>
>diff --git a/drivers/dibs/dibs_main.c b/drivers/dibs/dibs_main.c
>index 0374f8350ff7..b015578b4d2e 100644
>--- a/drivers/dibs/dibs_main.c
>+++ b/drivers/dibs/dibs_main.c
>@@ -254,9 +254,6 @@ static int __init dibs_init(void)
> {
> 	int rc;
> 
>-	memset(clients, 0, sizeof(clients));
>-	max_client = 0;
>-
> 	dibs_class = class_create("dibs");
> 	if (IS_ERR(dibs_class))
> 		return PTR_ERR(dibs_class);
>-- 
>2.48.1

Re: [PATCH net-next 2/2] dibs: Use subsys_initcall()

[Alexandra Winter]

On 23.10.25 17:18, Alexander Lobakin wrote:
>> Reported-by: Mete Durlu <meted@linux.ibm.com>
> Was this reported on LKML, so that you could add a 'Closes:' tag with
> the link here or the report was internal?

It was an internal report, so no link available.
We still want to give credit for the colleague who spent time to report
this issue outside of his main area.

> 
>> Signed-off-by: Alexandra Winter <wintera@linux.ibm.com>
> Either way,
> 
> Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>

Thank you very much.

Re: [PATCH net-next 1/2] dibs: Remove reset of static vars in dibs_init()

[patchwork-bot+netdevbpf]

Hello:

This series was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Thu, 23 Oct 2025 17:06:35 +0200 you wrote:
> 'clients' and 'max_client' are static variables and therefore don't need to
> be initialized.
> 
> Reported-by: Mete Durlu <meted@linux.ibm.com>
> Signed-off-by: Alexandra Winter <wintera@linux.ibm.com>
> ---
>  drivers/dibs/dibs_main.c | 3 ---
>  1 file changed, 3 deletions(-)

Here is the summary with links:
  - [net-next,1/2] dibs: Remove reset of static vars in dibs_init()
    https://git.kernel.org/netdev/net-next/c/182663bbff78
  - [net-next,2/2] dibs: Use subsys_initcall()
    https://git.kernel.org/netdev/net-next/c/968822086b74

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html