From: Florian Westphal <fw@strlen.de>
To: Andrii Melnychenko <a.melnychenko@vyos.io>
Cc: pablo@netfilter.org, kadlec@netfilter.org, phil@nwl.cc,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/1] nft_ct: Added nfct_seqadj_ext_add() for DNAT'ed conntrack.
Date: Fri, 24 Oct 2025 18:27:07 +0200 [thread overview]
Message-ID: <aPuo22KKi2CtD57q@strlen.de> (raw)
In-Reply-To: <20251024162216.963891-2-a.melnychenko@vyos.io>
Andrii Melnychenko <a.melnychenko@vyos.io> wrote:
> There is an issue with the missed seqadj extension for NAT'ed
> conntrack setup with nft. Sequence adjustment may be required
> for FTP traffic with PASV/EPSV modes.
Patch looks good, thanks.
> Oct 16 10:24:44 vyos kernel: Missing nfct_seqadj_ext_add() setup call
> Oct 16 10:24:44 vyos kernel: WARNING: CPU: 1 PID: 0 at
> net/netfilter/nf_conntrack_seqadj.c:41 nf_ct_seqadj_set+0xbf/0xe0
> [nf_conntrack]
This is useful.
> configfs(E) virtio_rng(E) rng_core(E) ip_tables(E) x_tables(E)
> autofs4(E) usb_storage(E) ohci_hcd(E) uhci_hcd(E) ehci_hcd(E) sd_mod(E)
[..]
For the future, please consider trimming this to the essentials.
Loaded modules etc or date are not relevant info that needs to be in
the changelog.
I'll trim this before applying, no need to resend.
Thanks for taking the time to track down the root cause of this bug.
prev parent reply other threads:[~2025-10-24 16:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 16:22 [PATCH v4 0/1] nf_conntrack_ftp: Added nfct_seqadj_ext_add() Andrii Melnychenko
2025-10-24 16:22 ` [PATCH v4 1/1] nft_ct: Added nfct_seqadj_ext_add() for DNAT'ed conntrack Andrii Melnychenko
2025-10-24 16:27 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPuo22KKi2CtD57q@strlen.de \
--to=fw@strlen.de \
--cc=a.melnychenko@vyos.io \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).