From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6AEC261B70 for ; Fri, 24 Oct 2025 18:20:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761330015; cv=none; b=gTE5fVGJ7TgDt839OPPwA7NhAm0IZIKruYpZm1lDioRw7WogsdR+m9ijYRG0/Ud5v7BEdiJTvaiWwJsiREYdIss6JOzfXhgcV2IqOgLrGcwEgQdl1vwn680StFeJUjsxf8rBoB/5JuyZPl6vxMVTnFVEbz8C19r5w8YxiTf10hE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761330015; c=relaxed/simple; bh=XEWcdB8nSL7TWcB0vmWs3gPFfFkARIiMj9ncUdIOKvg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sZYtcX8786GuSvYd58moRDvvRmQ/ccG66NRp/3+w4il6jGe3NfpL02xIIiJZqQCikQLtki9JsU+a/YExR/G9ZahwvyK23hSFafWhs0cjGwfu2qhQxhmlnHIrU0qWWZNEij58w7EtViySeGNuoO97+12wPoosu4oCZHIt6yXlnpc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Hxb69m2v; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Hxb69m2v" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-7811a02316bso1804127b3a.3 for ; Fri, 24 Oct 2025 11:20:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761330013; x=1761934813; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=mF8pASkRSmy3g5pAre6pJzEAWPU5hy46lyxgo7GleXY=; b=Hxb69m2vcZLJBzX+QHiR+EYvsOj3PsSBmFSqAmXnoaM55Rswoj2yAwWv+vWyKXm0TI qhXMC0gh27QainkDAUDMoXiEHCwEAvQR9er9wyHbompffxJhej6vSC3rMZs3X05D97pZ mNMmVRsYFZiUajGKdVHaNtZiihUPTetmhShf6SgB2Ke0hsH6qGWGcYpts3azfT3YFxNg ysjpZZ55LtYnVUnMVOZTtsSVH70gwjetIDYZyQ1VZ3pCokGyErGxpRgXPOqWyJCqOXQy PyiejjyzCPYSufxx00o4ieO0a1dKDHuUalM9d8rma65XFNk+QpUG0pM2hwlnBYXnwLbT Atcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761330013; x=1761934813; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mF8pASkRSmy3g5pAre6pJzEAWPU5hy46lyxgo7GleXY=; b=DxHb2L1mGy4M02mMDdg3NNgQCZyeeuW3AG+yHWieRovaUlUWZgI+NBh0d/yIB5ThZ/ qV1TuyAj+/evmBeFiQitLc6VUUmk7A1qEDeVO6kYTTT0Dc/JCGNZ40bHo4KgB9lK/3ix dj/GNAS4GE+mox1wUqkUo4ezNoB+O8vb7ElTtdnn+Mi4dyjIRLhZfcKmEd8HZWFA1TjS pvNnl6yG6iUapHxMLFFUnJOTAXEpQsos5oMllwvbvlaPAL+xEVFQxri98lXbAH90nENA K1R7lTzsWgQRHo6lgzDdtQ/+r6U6kOr5wVbwD4ZUb2tB6wgoJIe5DjzRqHFYPobMwoyq 4j5w== X-Gm-Message-State: AOJu0YyU2ApC3XnVBMttqZhEJZ3Szz2WUjIOWiYZoHEYJnVwRKpOYGD4 +mAJnDNg7HtYV04CyTLm15F+aFCrqiQEdbkWoxYSaEUvUM7zargb6LY= X-Gm-Gg: ASbGncuOG5a5zZS/w09d7D4tgDvkWuz2S7qTMljKbyBWLkA7o2bEfcjVAqD9q1msyV7 IUmj3B0hVWbopPa0l0QnFKeOpClQulSOBF1vx/Gz7vJ95XSRVs3tNoH2PzFeXFiBwoxcMxHRaa8 1fNWcJd1Hy8HteqiA1wNDxx3zy6EzkJTc5EkvfNYATtm9V5X9Ks+7qMkonRcPR7+KLSsONndfQp vEZkpzAdHOctaMcPSbwvJr9kLoSf8h4sm25+gI1CP5OqvTcrGIN00FJZ2s2tjETnOgxgKSILbrh /deql0knZSZsEh8HlnKBsRZlxNZ+bx9+voSKM1jcVs4VDuTZQzuQBUTSFF5yvkVO1r1wSjnInRI 0Sy8QUurN55yhQciiQtZ1C83mX0s6Rt1H/io+G7Io1PoaWcHVlHmXuxskxgNt6AT+0y16TPf4IV EQ/iB+jCXOH4AXYk8y6vUJ/O2q6bu/XA2MeHhd6wWWaPDJrrEt5kMIv7ogtrmjxVLQnThAlD6x8 cxChdGlWQv5c2qVbbOlM6r4cKALJuLbiGbR17gXCoUXmqfibFNfYRyWCEpRyj3N7PA= X-Google-Smtp-Source: AGHT+IFl3AvSw+4rywJDi3NIfeZ09z7+cHIedsvqceTYOl/yM/dg2dUTcTxeuql+mG9DZvg6arOO/g== X-Received: by 2002:a05:6a20:72a7:b0:334:a1bb:58a7 with SMTP id adf61e73a8af0-334a8614287mr38803933637.46.1761330012605; Fri, 24 Oct 2025 11:20:12 -0700 (PDT) Received: from localhost (c-76-102-12-149.hsd1.ca.comcast.net. [76.102.12.149]) by smtp.gmail.com with UTF8SMTPSA id d2e1a72fcca58-7a274a9e580sm6537353b3a.17.2025.10.24.11.20.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Oct 2025 11:20:12 -0700 (PDT) Date: Fri, 24 Oct 2025 11:20:11 -0700 From: Stanislav Fomichev To: Daniel Borkmann Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, kuba@kernel.org, davem@davemloft.net, razor@blackwall.org, pabeni@redhat.com, willemb@google.com, sdf@fomichev.me, john.fastabend@gmail.com, martin.lau@kernel.org, jordan@jrife.io, maciej.fijalkowski@intel.com, magnus.karlsson@intel.com, dw@davidwei.uk, toke@redhat.com, yangzhenze@bytedance.com, wangdongdong.6@bytedance.com Subject: Re: [PATCH net-next v3 02/15] net: Implement netdev_nl_bind_queue_doit Message-ID: References: <20251020162355.136118-1-daniel@iogearbox.net> <20251020162355.136118-3-daniel@iogearbox.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20251020162355.136118-3-daniel@iogearbox.net> On 10/20, Daniel Borkmann wrote: > From: David Wei > > Implement netdev_nl_bind_queue_doit() that creates an rx queue in a > virtual netdev and then binds it to an rxq in a real netdev to create > a queue pair. > > Example with ynl client: > > # ./pyynl/cli.py \ > --spec ~/netlink/specs/netdev.yaml \ > --do bind-queue \ > --json '{"src-ifindex": 4, "src-queue-id": 15, "dst-ifindex": 8, "queue-type": "rx"}' > {'dst-queue-id': 1} > > Note that the netdevice locking order is always from the virtual to > the physical device. > > Signed-off-by: David Wei > Co-developed-by: Daniel Borkmann > Signed-off-by: Daniel Borkmann > --- > include/net/netdev_queues.h | 5 ++ > include/net/netdev_rx_queue.h | 36 ++++++++- > net/core/netdev-genl.c | 141 +++++++++++++++++++++++++++++++++- > net/core/netdev_rx_queue.c | 61 +++++++++++++++ > 4 files changed, 240 insertions(+), 3 deletions(-) > > diff --git a/include/net/netdev_queues.h b/include/net/netdev_queues.h > index cd00e0406cf4..286d5edce07d 100644 > --- a/include/net/netdev_queues.h > +++ b/include/net/netdev_queues.h > @@ -130,6 +130,10 @@ void netdev_stat_queue_sum(struct net_device *netdev, > * @ndo_queue_get_dma_dev: Get dma device for zero-copy operations to be used > * for this queue. Return NULL on error. > * > + * @ndo_queue_create: Create a new RX queue which can be bound to another queue. > + * Ops on this queue are redirected to the peer queue e.g. > + * when opening a memory provider. > + * > * Note that @ndo_queue_mem_alloc and @ndo_queue_mem_free may be called while > * the interface is closed. @ndo_queue_start and @ndo_queue_stop will only > * be called for an interface which is open. > @@ -149,6 +153,7 @@ struct netdev_queue_mgmt_ops { > int idx); > struct device * (*ndo_queue_get_dma_dev)(struct net_device *dev, > int idx); > + int (*ndo_queue_create)(struct net_device *dev); > }; > > bool netif_rxq_has_unreadable_mp(struct net_device *dev, int idx); > diff --git a/include/net/netdev_rx_queue.h b/include/net/netdev_rx_queue.h > index 8cdcd138b33f..db3ef94c0744 100644 > --- a/include/net/netdev_rx_queue.h > +++ b/include/net/netdev_rx_queue.h > @@ -28,6 +28,7 @@ struct netdev_rx_queue { > #endif > struct napi_struct *napi; > struct pp_memory_provider_params mp_params; > + struct netdev_rx_queue *peer; > } ____cacheline_aligned_in_smp; > > /* > @@ -56,6 +57,37 @@ get_netdev_rx_queue_index(struct netdev_rx_queue *queue) > return index; > } > > -int netdev_rx_queue_restart(struct net_device *dev, unsigned int rxq); > +static inline void __netdev_rx_queue_peer(struct netdev_rx_queue *src_rxq, > + struct netdev_rx_queue *dst_rxq) > +{ > + src_rxq->peer = dst_rxq; > + dst_rxq->peer = src_rxq; > +} > > -#endif > +static inline void __netdev_rx_queue_unpeer(struct netdev_rx_queue *src_rxq, > + struct netdev_rx_queue *dst_rxq) > +{ > + src_rxq->peer = NULL; > + dst_rxq->peer = NULL; > +} > + > +static inline bool netdev_rx_queue_peered(struct net_device *dev, > + u16 queue_id) > +{ > + if (queue_id < dev->real_num_rx_queues) > + return dev->_rx[queue_id].peer; > + return false; > +} > + > +void netdev_rx_queue_peer(struct net_device *src_dev, > + struct netdev_rx_queue *src_rxq, > + struct netdev_rx_queue *dst_rxq); > +void netdev_rx_queue_unpeer(struct net_device *src_dev, > + struct netdev_rx_queue *src_rxq, > + struct netdev_rx_queue *dst_rxq); > +int netdev_rx_queue_restart(struct net_device *dev, unsigned int rxq); > +struct netdev_rx_queue * > +netif_get_rx_queue_peer_locked(struct net_device **dev, > + unsigned int *rxq_idx, > + bool *needs_unlock); > +#endif /* _LINUX_NETDEV_RX_QUEUE_H */ > diff --git a/net/core/netdev-genl.c b/net/core/netdev-genl.c > index ce1018ea390f..579469abac8c 100644 > --- a/net/core/netdev-genl.c > +++ b/net/core/netdev-genl.c > @@ -1122,7 +1122,146 @@ int netdev_nl_bind_tx_doit(struct sk_buff *skb, struct genl_info *info) > > int netdev_nl_bind_queue_doit(struct sk_buff *skb, struct genl_info *info) > { > - return -EOPNOTSUPP; > + u32 src_ifidx, src_qid, dst_ifidx, dst_qid, q_type; > + struct netdev_rx_queue *src_rxq, *dst_rxq, *tmp_rxq; > + struct net_device *src_dev, *dst_dev; > + struct sk_buff *rsp; > + int err = 0; > + void *hdr; > + > + if (GENL_REQ_ATTR_CHECK(info, NETDEV_A_QUEUE_PAIR_QUEUE_TYPE) || > + GENL_REQ_ATTR_CHECK(info, NETDEV_A_QUEUE_PAIR_SRC_IFINDEX) || > + GENL_REQ_ATTR_CHECK(info, NETDEV_A_QUEUE_PAIR_SRC_QUEUE_ID) || > + GENL_REQ_ATTR_CHECK(info, NETDEV_A_QUEUE_PAIR_DST_IFINDEX)) > + return -EINVAL; > + > + src_ifidx = nla_get_u32(info->attrs[NETDEV_A_QUEUE_PAIR_SRC_IFINDEX]); > + src_qid = nla_get_u32(info->attrs[NETDEV_A_QUEUE_PAIR_SRC_QUEUE_ID]); > + dst_ifidx = nla_get_u32(info->attrs[NETDEV_A_QUEUE_PAIR_DST_IFINDEX]); > + q_type = nla_get_u32(info->attrs[NETDEV_A_QUEUE_PAIR_QUEUE_TYPE]); > + > + if (q_type != NETDEV_QUEUE_TYPE_RX) { > + NL_SET_ERR_MSG(info->extack, "Only binding of RX queue supported"); > + return -EOPNOTSUPP; > + } > + if (dst_ifidx == src_ifidx) { > + NL_SET_ERR_MSG(info->extack, > + "Destination driver cannot be same as source driver"); > + return -EOPNOTSUPP; > + } > + > + rsp = genlmsg_new(GENLMSG_DEFAULT_SIZE, GFP_KERNEL); > + if (!rsp) > + return -ENOMEM; > + > + hdr = genlmsg_iput(rsp, info); > + if (!hdr) { > + err = -EMSGSIZE; > + goto err_genlmsg_free; > + } [..] > + /* Locking order is always from the virtual to the physical device > + * since this is also the same order when applications open the > + * memory provider later on. > + */ > + dst_dev = netdev_get_by_index_lock(genl_info_net(info), dst_ifidx); > + if (!dst_dev) { > + err = -ENODEV; > + goto err_genlmsg_free; > + } ... > + src_dev = netdev_get_by_index_lock(genl_info_net(info), src_ifidx); > + if (!src_dev) { > + err = -ENODEV; > + goto err_unlock_dst_dev; > + } But isn't the above susceptible to ABBA exploitation from the userspace? I can try to concurrently do two requests, the second one being with dst_dev and src_dev swapped. Or do we assume that we exit earlier for the swapped case based on some other condition?