From: Saeed Mahameed <saeed@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Saeed Mahameed <saeedm@nvidia.com>,
netdev@vger.kernel.org, Tariq Toukan <tariqt@nvidia.com>,
Gal Pressman <gal@nvidia.com>,
Leon Romanovsky <leonro@nvidia.com>, Jiri Pirko <jiri@nvidia.com>,
mbloch@nvidia.com, Adithya Jayachandran <ajayachandra@nvidia.com>
Subject: Re: [PATCH net-next V2 3/3] net/mlx5: E-Switch, support eswitch inactive mode
Date: Fri, 7 Nov 2025 20:53:22 -0800 [thread overview]
Message-ID: <aQ7MwqRiCsR6aNq3@x130> (raw)
In-Reply-To: <20251107182813.737c2d73@kernel.org>
On 07 Nov 18:28, Jakub Kicinski wrote:
>On Thu, 6 Nov 2025 16:08:31 -0800 Saeed Mahameed wrote:
>> + if (IS_ERR(table)) {
>> + esw_warn(dev, "Failed to create fdb drop root table, err %ld\n",
>> + PTR_ERR(table));
>> + return PTR_ERR(table);
>> + }
>
>cocci says:
>
>drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c:2397:4-11: WARNING: Consider using %pe to print PTR_ERR()
>
I was planing to do this now, but then saw your message bellow :).
>While I have you, could you please help this one along (dare I say,
>first, due to the extack propagation?):
Sure, what do you need just review? I see that the series is straight
forward, but let me take a deeper look.
>https://lore.kernel.org/all/20251107204347.4060542-1-daniel.zahka@gmail.com/
prev parent reply other threads:[~2025-11-08 4:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-07 0:08 [PATCH net-next V2 0/3] devlink eswitch inactive mode Saeed Mahameed
2025-11-07 0:08 ` [PATCH net-next V2 1/3] devlink: Introduce switchdev_inactive eswitch mode Saeed Mahameed
2025-11-07 0:08 ` [PATCH net-next V2 2/3] net/mlx5: MPFS, add support for dynamic enable/disable Saeed Mahameed
2025-11-08 15:21 ` Simon Horman
2025-11-08 19:39 ` Saeed Mahameed
2025-11-11 14:27 ` Simon Horman
2025-11-07 0:08 ` [PATCH net-next V2 3/3] net/mlx5: E-Switch, support eswitch inactive mode Saeed Mahameed
2025-11-08 2:28 ` Jakub Kicinski
2025-11-08 4:53 ` Saeed Mahameed [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQ7MwqRiCsR6aNq3@x130 \
--to=saeed@kernel.org \
--cc=ajayachandra@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=leonro@nvidia.com \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).