netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 ipsec-next] pfkey: Deprecate pfkey
@ 2025-10-28  6:29 Steffen Klassert
  2025-11-01 12:26 ` Steffen Klassert
  0 siblings, 1 reply; 2+ messages in thread
From: Steffen Klassert @ 2025-10-28  6:29 UTC (permalink / raw)
  To: Herbert Xu, Paul Wouters, Andreas Steffen, Tobias Brunner,
	Antony Antony, Tuomo Soini, David S. Miller, Florian Westphal,
	Sabrina Dubroca
  Cc: netdev, devel

The pfkey user configuration interface was replaced by the netlink
user configuration interface more than a decade ago. In between
all maintained IKE implementations moved to the netlink interface.
So let config NET_KEY default to no in Kconfig. The pfkey code
will be removed in a second step.

Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Reviewed-by: Sabrina Dubroca <sd@queasysnail.net>
Acked-by: Antony Antony <antony.antony@secunet.com>
Acked-by: Tobias Brunner <tobias@strongswan.org>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Acked-by: Tuomo Soini <tis@foobar.fi>
Acked-by: Paul Wouters <paul@nohats.ca>
---

Changes in v2:

- Add some new tags.
- Fix two typos in the commit message.

 net/key/af_key.c |  2 ++
 net/xfrm/Kconfig | 11 +++++++----
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/net/key/af_key.c b/net/key/af_key.c
index 2ebde0352245..571200433aa9 100644
--- a/net/key/af_key.c
+++ b/net/key/af_key.c
@@ -3903,6 +3903,8 @@ static int __init ipsec_pfkey_init(void)
 {
 	int err = proto_register(&key_proto, 0);
 
+	pr_warn_once("PFKEY is deprecated and scheduled to be removed in 2027, "
+	             "please contact the netdev mailing list\n");
 	if (err != 0)
 		goto out;
 
diff --git a/net/xfrm/Kconfig b/net/xfrm/Kconfig
index f0157702718f..4a62817a88f8 100644
--- a/net/xfrm/Kconfig
+++ b/net/xfrm/Kconfig
@@ -110,14 +110,17 @@ config XFRM_IPCOMP
 	select CRYPTO_DEFLATE
 
 config NET_KEY
-	tristate "PF_KEY sockets"
+	tristate "PF_KEY sockets (deprecated)"
 	select XFRM_ALGO
 	help
 	  PF_KEYv2 socket family, compatible to KAME ones.
-	  They are required if you are going to use IPsec tools ported
-	  from KAME.
 
-	  Say Y unless you know what you are doing.
+	  The PF_KEYv2 socket interface is deprecated and
+	  scheduled for removal. All maintained IKE daemons
+	  no longer need PF_KEY sockets. Please use the netlink
+	  interface (XFRM_USER) to configure IPsec.
+
+	  If unsure, say N.
 
 config NET_KEY_MIGRATE
 	bool "PF_KEY MIGRATE"
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2 ipsec-next] pfkey: Deprecate pfkey
  2025-10-28  6:29 [PATCH v2 ipsec-next] pfkey: Deprecate pfkey Steffen Klassert
@ 2025-11-01 12:26 ` Steffen Klassert
  0 siblings, 0 replies; 2+ messages in thread
From: Steffen Klassert @ 2025-11-01 12:26 UTC (permalink / raw)
  To: Herbert Xu, Paul Wouters, Andreas Steffen, Tobias Brunner,
	Antony Antony, Tuomo Soini, David S. Miller, Florian Westphal,
	Sabrina Dubroca
  Cc: netdev, devel

On Tue, Oct 28, 2025 at 07:29:09AM +0100, Steffen Klassert wrote:
> The pfkey user configuration interface was replaced by the netlink
> user configuration interface more than a decade ago. In between
> all maintained IKE implementations moved to the netlink interface.
> So let config NET_KEY default to no in Kconfig. The pfkey code
> will be removed in a second step.
> 
> Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
> Reviewed-by: Sabrina Dubroca <sd@queasysnail.net>
> Acked-by: Antony Antony <antony.antony@secunet.com>
> Acked-by: Tobias Brunner <tobias@strongswan.org>
> Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
> Acked-by: Tuomo Soini <tis@foobar.fi>
> Acked-by: Paul Wouters <paul@nohats.ca>

This is now applied to ipsec-next,

thanks everyone!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-11-01 12:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-28  6:29 [PATCH v2 ipsec-next] pfkey: Deprecate pfkey Steffen Klassert
2025-11-01 12:26 ` Steffen Klassert

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).