From: Simon Horman <horms@kernel.org>
To: Wang Liang <wangliang74@huawei.com>
Cc: kuba@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, shuah@kernel.org,
acardace@redhat.com, netdev@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
yuehaibing@huawei.com, zhangchangzhong@huawei.com
Subject: Re: [PATCH net] selftests: netdevsim: Fix ethtool-coalesce.sh fail by installing ethtool-common.sh
Date: Tue, 28 Oct 2025 17:14:03 +0000 [thread overview]
Message-ID: <aQD52zzmW1YDC1iH@horms.kernel.org> (raw)
In-Reply-To: <20251027043007.1315917-1-wangliang74@huawei.com>
On Mon, Oct 27, 2025 at 12:30:07PM +0800, Wang Liang wrote:
> The script "ethtool-common.sh" is not installed in INSTALL_PATH, and
> triggers some errors when I try to run the test
> 'drivers/net/netdevsim/ethtool-coalesce.sh':
>
> TAP version 13
> 1..1
> # timeout set to 600
> # selftests: drivers/net/netdevsim: ethtool-coalesce.sh
> # ./ethtool-coalesce.sh: line 4: ethtool-common.sh: No such file or directory
> # ./ethtool-coalesce.sh: line 25: make_netdev: command not found
> # ethtool: bad command line argument(s)
> # ./ethtool-coalesce.sh: line 124: check: command not found
> # ./ethtool-coalesce.sh: line 126: [: -eq: unary operator expected
> # FAILED /0 checks
> not ok 1 selftests: drivers/net/netdevsim: ethtool-coalesce.sh # exit=1
>
> Install this file to avoid this error. After this patch:
>
> TAP version 13
> 1..1
> # timeout set to 600
> # selftests: drivers/net/netdevsim: ethtool-coalesce.sh
> # PASSED all 22 checks
> ok 1 selftests: drivers/net/netdevsim: ethtool-coalesce.sh
>
> Fixes: fbb8531e58bd ("selftests: extract common functions in ethtool-common.sh")
> Signed-off-by: Wang Liang <wangliang74@huawei.com>
> ---
> tools/testing/selftests/drivers/net/netdevsim/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/selftests/drivers/net/netdevsim/Makefile b/tools/testing/selftests/drivers/net/netdevsim/Makefile
> index daf51113c827..653141a654a0 100644
> --- a/tools/testing/selftests/drivers/net/netdevsim/Makefile
> +++ b/tools/testing/selftests/drivers/net/netdevsim/Makefile
> @@ -20,4 +20,6 @@ TEST_PROGS := \
> udp_tunnel_nic.sh \
> # end of TEST_PROGS
>
> +TEST_FILES := ethtool-common.sh
> +
> include ../../../lib.mk
Hi Wang Liang,
As per commit f07f91a36090 ("selftests: net: unify the Makefile formats")
I think the desired format is as follows (completely untested!):
TEST_FILES := \
ethtool-common.sh \
# end of TEST_PROGS
--
pw-bot: changes-requested
next prev parent reply other threads:[~2025-10-28 17:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 4:30 [PATCH net] selftests: netdevsim: Fix ethtool-coalesce.sh fail by installing ethtool-common.sh Wang Liang
2025-10-28 17:14 ` Simon Horman [this message]
2025-10-29 0:08 ` Jakub Kicinski
2025-10-29 17:37 ` Simon Horman
2025-10-29 7:56 ` Wang Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQD52zzmW1YDC1iH@horms.kernel.org \
--to=horms@kernel.org \
--cc=acardace@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=wangliang74@huawei.com \
--cc=yuehaibing@huawei.com \
--cc=zhangchangzhong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).