From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 693722D0625 for ; Tue, 28 Oct 2025 21:12:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761685971; cv=none; b=swp1lBQFGqHiwWD3Yj408z6PZWDCN8zJpVMQyd9e7w2FWBw8OvjMHfaENsoOYf/H0AqI5cRikgRTvJHWZeFx+nJWXpnlJ0vnOYc7KhvpzrM+emjM0/R4pr/nly1SgpRWF8oozkBkIKY1syXqVX+ScI2PDJM2e3Cv+zT9qXd4MKo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761685971; c=relaxed/simple; bh=3mdHxyFxcBIqx94fU00IVGhjAT6WODYMFzn7BltiJkQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IE9WYNqNru8jiZQjRIdsWp+G9y4hTvkppHRnP+7ZY1OUKga8L/VMc9H3KR1mT+jCL8hM60NfoYHnDTgQ+AGlanBXIWRquqS8Hwt0seKsTpydUwZivNYamhXSDKF75Rgvb5IPJl15WOXfhIRine2+roA0XrRwJoMvMQlCn3hIBQE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OuDANcZq; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Bpl0ZQfG; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OuDANcZq"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Bpl0ZQfG" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 59SJlOUh2554348 for ; Tue, 28 Oct 2025 21:12:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=1LtehMKAD0jYV0omlxKXVwht t876OECEZc58jyM18Sk=; b=OuDANcZqW+nEL2Vx09QGC0PRAzwYVuLSZ/i7cjot HiFoMynvHwDfZhOYW0WTcyP30TJiQ06KtROZgPLGdBM6IMZ4VL1vHE22cRqCJjgZ aLO+N9MQjqyW2nMsVHfRYMpBH5ueq5mZbQApTPexEydfHtkjloh7ts97mA5K2PMz X7AR2v7X/xgwlfd1Ca3Cy38rYrn6Jw4VN8JVpdvKvzsTMx6uhrZ2JDc5g8+6O1Sv HuY/44tamzhE4bm+Zhqpg5Xx9YxH3nXScuufVXjRr7dLJp1DIcQWAd6lu+UsWWgZ CPIGvReEwAlKc3yoVFAZX6xmvGo6S+wjwNGA3rTNJMbsBw== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4a34a106y6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 28 Oct 2025 21:12:49 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-b6ce1b57b3eso10166746a12.1 for ; Tue, 28 Oct 2025 14:12:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1761685969; x=1762290769; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1LtehMKAD0jYV0omlxKXVwhtt876OECEZc58jyM18Sk=; b=Bpl0ZQfGeaffp0urY8o4QdhTEWxiu79o5oKmQGyhGF9k66UXwRXIRc2rAxyM+QrpdQ sKEuyY7sQOMQG8s9DZ9gU957PKoJmOguJgkAhz5AxIn0MIDdAkDsh1IVvYFS0q8JFbZO Ysd/7ckEoU8IRaghlXxScBfdrE/QJSebowmxaLVq+MFn8kYaALBQAXPTEKmU5rmH0EPL tyqVr/W+tTKmhTZuaw0gz1R/ENzuYaLoqfJq5WhCypIB01X8hjVe/YUQFls0MRmfz1+a VsLzdDv4QEO6z8ZTiZTg0BC86e74XRbdjxxfPpRuatrOv/j7kz20j6WPICv56g14vLTf zL9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761685969; x=1762290769; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1LtehMKAD0jYV0omlxKXVwhtt876OECEZc58jyM18Sk=; b=PoFqF+AC5/PNIkZdLsHBBf8fpi3dFmzlubndN0lg1gu5aYJBa6QAd8iYtZ8aD0cQMc 3el0NoRLPZlkj3vilS8exMM4aqQWY+Z2P8UqneJ0Lcu1kBlvE32aGGKSbwAQhW1rYgWz EHExNzcka1u7Ga4hJAtG2wZKvdB5gM3L1oY15YU4E5Mw3D3LgLk1sOoCBUvkhXADUq52 zYIz4zXvF0/18wGRO7lSHw5INEV9VzWv1yYWe1DbYSirJqs1aegW325cxlNf0vqIMzuZ 7d66tMO+CpL9anvSJW4DXWfaYBh5gUaOAqSMyhCHcVGpq7+3duR7GNcEIJkZL2cglaYI T3HA== X-Forwarded-Encrypted: i=1; AJvYcCXohLW3RWKNogzTMQ9VizAVsxSBz245KC2wfetjWrUELV2F9XEByNUmNGY/iwitiLYAW0OKbNc=@vger.kernel.org X-Gm-Message-State: AOJu0YwdMIWjLJfLiRxJ8xzeUvyAwIjxZlSJK4UnjqudyC96IbEeJnhq 6Sv1TK7/R2VqEErL3QseQ7WH/JoOtdn+YnsTnx4KL43/4gDCktBejdXOMJ6Ct1ukfQ/VpfWbfsI Ici+vZso2cG6dsf+0Dbig9Zvjy8Z2uyg+6pCogxE64Hpm/HgTxlFbNzrgRus= X-Gm-Gg: ASbGncsCbkjkkOWFg5j+jP8MWbzaui7aTpth6O3w7TEdAVdFr/zvdURAZiFWWaHx196 WpUFBjtAd09rPOf2OyV6YD5aUBAoIwGEPLKiuEZXXIpSEr4W6mbvNvTSMoxijpef1/jM4XCYmuG mf1w/1F6Xepu+8NMG2rX6j1xnfWPL6IPbC2eNyTzM29+kpe7BVjjiHqx3jJFygkQoYxO/tEgJu9 pOUPRottQXDilhf2PVvBmiSbV54wHTazBPYWszWDYOOMrJklNL4oGJgx+INRK3xSTVu7GCtLdrl WGFla0HGOOPtVFFSNZGjNsEP+b247vCmnfwYhaZxuPJwKCLzceqUy5bzHxb5lfaXqQZlO5WsuJ+ coEyCDtbO1rE4 X-Received: by 2002:a05:6a21:6da6:b0:323:b12:bda6 with SMTP id adf61e73a8af0-34651d3055cmr536747637.13.1761685968809; Tue, 28 Oct 2025 14:12:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH7e6BLeImkmGk7yQBouN0uZRYDkpUAYFZrrUgsRCUtcrqntlF3BSsWFJ6WikLzqyRU0A1XWg== X-Received: by 2002:a05:6a21:6da6:b0:323:b12:bda6 with SMTP id adf61e73a8af0-34651d3055cmr536697637.13.1761685968234; Tue, 28 Oct 2025 14:12:48 -0700 (PDT) Received: from oss.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b7128e41c01sm11277005a12.23.2025.10.28.14.12.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Oct 2025 14:12:47 -0700 (PDT) Date: Wed, 29 Oct 2025 02:42:39 +0530 From: Mohd Ayaan Anwar To: "Russell King (Oracle)" Cc: Andrew Lunn , Heiner Kallweit , Alexandre Torgue , Alexis =?iso-8859-1?Q?Lothor=E9?= , Andrew Lunn , Boon Khai Ng , Daniel Machon , "David S. Miller" , Eric Dumazet , Furong Xu <0x1207@gmail.com>, Jacob Keller , Jakub Kicinski , "Jan Petrous (OSS)" , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Chevallier , Maxime Coquelin , netdev@vger.kernel.org, Paolo Abeni , Simon Horman , Vladimir Oltean , Yu-Chun Lin Subject: Re: [PATCH net-next 0/3] net: stmmac: phylink PCS conversion part 3 (dodgy stuff) Message-ID: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDI4MDE3OSBTYWx0ZWRfX4PQckg4FNFkH FC0oFu9qvvFIkF5JZS5vO244Ck2ZBKkQ0vXkKFer47vTDYwgRBhBL1pwz3oSC3QNpX77YLyFgCC x/ZXp3ro3Sr7Dlo2GY6A1zG03pFSWFBcGWZAOgTZgjdw0lPzeeUcZo529ZjlKxcZca+4YQ16d4G fWjIBOn0w9xUzgoNe0R4WchuN1Ghpuvhf2DxRFKsFnzBSgfpXz1NIRaOUq9Ilt38CXjw4vcQ5Ou 3AkS7UxBIvdbZgNr6IEDH8mC9NSpIosSIDpGWQaIKpBPkZCJKTV6605WLcukb36p1/8m7MIrb5y qj+U5aY+nUXj/7C0n0/1cA8cnlMs4hUN0278cYXsgIWQ1b1qWeOCYtz676KvfYOXdubmcvRt3ZF DUGwZSRDbeAGbj0DALhLSAH0/3PXGA== X-Proofpoint-ORIG-GUID: xyWMzjvJVx7ZeGwZ4QG9k-QlnFF9ntAp X-Authority-Analysis: v=2.4 cv=EKULElZC c=1 sm=1 tr=0 ts=690131d1 cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=kj9zAlcOel0A:10 a=x6icFKpwvdMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=yuzM4s2KeON4xd7rU1oA:9 a=CjuIK1q_8ugA:10 a=3WC7DwWrALyhR5TkjVHa:22 a=HhbK4dLum7pmb74im6QT:22 X-Proofpoint-GUID: xyWMzjvJVx7ZeGwZ4QG9k-QlnFF9ntAp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-28_08,2025-10-22_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 suspectscore=0 adultscore=0 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2510280179 Hi Russell, On Sat, Oct 25, 2025 at 09:47:37PM +0100, Russell King (Oracle) wrote: > Hi, > > This series is currently the last of the phylink PCS conversion for > stmmac. This series contains changes that will cause potential breakage, > so I suggest to netdev maintainers that it is only applied if there is > a significant response from testers using the PCS. > > Paritcularly, dwmac-qcom-ethqos.c users need to test this, since this > platform glue driver manipulates the PCS state. Patch 2 is designed to > print a warning to the kernel log if this glue driver calls > stmmac_pcs_ctrl_ane() to set the AN state differently to how phylink > has set it. If this happens, we need to do some pre-work to prevent > these prints. > > .../net/ethernet/stmicro/stmmac/dwmac1000_core.c | 7 +++++- > drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 7 +++++- > drivers/net/ethernet/stmicro/stmmac/stmmac_pcs.c | 29 +++++++++++++++++++--- > drivers/net/ethernet/stmicro/stmmac/stmmac_pcs.h | 8 +++++- > 4 files changed, 44 insertions(+), 7 deletions(-) > Thank you for the recent stmmac cleanup patches. I apologize for the late reply. I had limited time to test due to some urgent tasks at work. This is a long email, please bear with me. I have the following devices on which I try to test whatever I can (both of them have the same GMAC core with an integrated PCS, both use phy-mode="2500base-x"): - Qualcomm QCS9100 Ride R3 (2xAQR115C PHYs) - Qualcomm IQ8 EVK (QCA808X PHY) - this is the same board for which I had posted [1] to resolve its issue with advertising only 2.5G # Patch Series: net: stmmac: phylink PCS conversion I tested this series soon after it got merged to net-next, probably when I tested out the hwif.c cleanups. A summary: - QCS9100 Ride R3 - no issues found. - IQ8 EVK - same behavior as without this patch, i.e. 2.5G was working fine, other speeds aren't advertised. However, this might have been expected as both boards are using 2500Base-X whereas the integrated PCS changes are limited to SGMII. *Sidenote*: I was able to get 2.5G and lower speeds to work on the IQ8 EVK after adding an additional case for 2500Base-X on top of your patch. # Patch Series (current): net: stmmac: phylink PCS conversion part 3 (dodgy stuff) - QCS9100 Ride R3 - functionality seems to be fine (again, probably due to the changes only affecting SGMII mode). However, the warning added in patch 2 comes up whenever there's a speed change (I added an additional WARN_ON to check the sequence): [ 61.663685] qcom-ethqos 23000000.ethernet eth0: Link is Down [ 66.235461] dwmac: PCS configuration changed from phylink by glue, please report: 0x00001000 -> 0x00000000 [ 66.245488] ------------[ cut here ]------------ [ 66.250240] WARNING: CPU: 0 PID: 71 at drivers/net/ethernet/stmicro/stmmac/stmmac_pcs.h:130 dwmac4_ctrl_ane+0x68/0x84 [stmmac] [ 66.369320] CPU: 0 UID: 0 PID: 71 Comm: kworker/u33:2 Tainted: G W 6.18.0-rc2-00357-g6c595c926e8f-dirty #1 PREEMPT [ 66.381547] Tainted: [W]=WARN [ 66.384608] Hardware name: Qualcomm Technologies, Inc. Lemans Ride Rev3 (DT) [ 66.391848] Workqueue: events_power_efficient phylink_resolve [ 66.397770] pstate: 60400005 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 66.404920] pc : dwmac4_ctrl_ane+0x68/0x84 [stmmac] [ 66.409949] lr : dwmac4_ctrl_ane+0x68/0x84 [stmmac] [ 66.414975] sp : ffff80008124bc20 [ 66.418387] x29: ffff80008124bc20 x28: 0000000000000001 x27: 0000000000000000 [ 66.425720] x26: 0000000000000001 x25: 0000000000000001 x24: 0000000008032000 [ 66.433053] x23: ffff0000b1148a00 x22: 0000000008032000 x21: 00000000000009c4 [ 66.440386] x20: ffff8000847300e0 x19: 0000000000000000 x18: 00000000ffffffff [ 66.447719] x17: 657220657361656c x16: 70202c65756c6720 x15: 7962206b6e696c79 [ 66.455053] x14: 6870206d6f726620 x13: 3030303030303030 x12: ffffc6e220a06cf0 [ 66.462386] x11: 0000000000000486 x10: 0000000000000018 x9 : ffffc6e220a06cf0 [ 66.469718] x8 : 00000000ffffefff x7 : ffffc6e220a5ecf0 x6 : 0000000000000000 [ 66.477051] x5 : ffff000ec7437408 x4 : 0000000000000001 x3 : 0000000000000000 [ 66.484384] x2 : 0000000000000000 x1 : ffff0000812a8000 x0 : 000000000000005e [ 66.491718] Call trace: [ 66.494245] dwmac4_ctrl_ane+0x68/0x84 [stmmac] (P) [ 66.499273] ethqos_configure_sgmii+0x114/0x1c0 [dwmac_qcom_ethqos] [ 66.505711] ethqos_fix_mac_speed+0x6c/0xec [dwmac_qcom_ethqos] [ 66.511795] stmmac_mac_link_up+0xd4/0x370 [stmmac] [ 66.516823] phylink_resolve+0x150/0x604 [ 66.520861] process_one_work+0x148/0x28c [ 66.524999] worker_thread+0x2d8/0x3d8 [ 66.528855] kthread+0x134/0x208 [ 66.532181] ret_from_fork+0x10/0x20 [ 66.535870] ---[ end trace 0000000000000000 ]--- [ 66.540750] qcom-ethqos 23000000.ethernet eth0: Link is Up - 2.5Gbps/Full - flow control rx/tx - IQ8 EVK - I will try to test it soon and share the results. Would it be helpful to change the phy-mode to SGMII for some further testing? Ayaan --- [1] https://lore.kernel.org/netdev/20250914-qca808x_rate_match-v1-1-0f9e6a331c3b@oss.qualcomm.com/T/#u