From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64C022206BB for ; Tue, 28 Oct 2025 23:57:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761695871; cv=none; b=nYo/1w9ba0Ve3Yq9mtpoRBnkyfhLb/HqwH8Dhhx8lxWV+ABmSGFR8X1HOShASpZOmBvlxk941tloQsaxt2b8wqrpAUKFJgqi1YscqkCxy2tVIAueozoi+Y3Ujq1svp1D1bCb/M/sE6lPfNX3LW4+x1nSXSHw0GpjZRsHOSFV8RA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761695871; c=relaxed/simple; bh=4kMhXIfA7aPxZm8cEf7NrodCPPDBCJKsDOsaoKin8Dk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UPCTqbOKMQhViqjMHMaxGIbFtekX7n5CZvpYo5SbbQWvKAX5qmHu24h8jSUVCC5cYWOVDqo2kh/cf6rJElK7kdmbrAz7Ctl62R8jKehiUsmo4RqpeihvS+XKLsThAPKFBJwiIbbQWXz/BcswWm61n9n4dTBJqHhmBIygx3r2zW4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=DtBgppHx; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="DtBgppHx" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=+ScJmt+/0Os57nukiGynVFNomd71ekgTNx8UM6wvsiM=; b=DtBgppHxDmU/Kd/3Ruec8pBeu9 6L3U554pxuSnq3NejqoXqHrRGkn4CGgFOyXlGnlK2d3m8IhamY8ccmOa/Weu3O3yKOFJHEUx+1Y/4 LmIEwOegwyaAUS7t2ONwQ8gbkOo4Ol4aZP4uDJtf31ZGScnCN104FG6jGbZIRqX9wvCqtkXNQB0Dh t1SBNH/GoA5fPpPFsDtqTHqtyMZyEMZ/vZ39fryyZhzCP0a78gVpIMzPiDGBO+oMyndDGoWGg7V/d Om1WFXacBpBrjt0/M+XKNHB0TWaxBLR6z7exMpMC/BriAozJJzMvxfpNrI3fPxfRtYBLekG4RtUxP hqt671pg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:56542) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vDtZP-000000003fK-1CVt; Tue, 28 Oct 2025 23:57:43 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.98.2) (envelope-from ) id 1vDtZN-000000006xv-1h3p; Tue, 28 Oct 2025 23:57:41 +0000 Date: Tue, 28 Oct 2025 23:57:41 +0000 From: "Russell King (Oracle)" To: Jakub Kicinski Cc: Andrew Lunn , Heiner Kallweit , Alexandre Torgue , Andrew Lunn , "David S. Miller" , Eric Dumazet , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , netdev@vger.kernel.org, Paolo Abeni , Richard Cochran Subject: Re: [PATCH net-next 0/8] net: stmmac: hwif.c cleanups Message-ID: References: <20251028164257.067bdbcd@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251028164257.067bdbcd@kernel.org> Sender: Russell King (Oracle) On Tue, Oct 28, 2025 at 04:42:57PM -0700, Jakub Kicinski wrote: > On Fri, 24 Oct 2025 13:48:23 +0100 Russell King (Oracle) wrote: > > This series cleans up hwif.c: > > > > - move the reading of the version information out of stmmac_hwif_init() > > into its own function, stmmac_get_version(), storing the result in a > > new struct. > > > > - simplify stmmac_get_version(). > > > > - read the version register once, passing it to stmmac_get_id() and > > stmmac_get_dev_id(). > > > > - move stmmac_get_id() and stmmac_get_dev_id() into > > stmmac_get_version() > > > > - define version register fields and use FIELD_GET() to decode > > > > - start tackling the big loop in stmmac_hwif_init() - provide a > > function, stmmac_hwif_find(), which looks up the hwif entry, thus > > making a much smaller loop, which improves readability of this code. > > > > - change the use of '^' to '!=' when comparing the dev_id, which is > > what is really meant here. > > > > - reorganise the test after calling stmmac_hwif_init() so that we > > handle the error case in the indented code, and the success case > > with no indent, which is the classical arrangement. > > This one needs a respin (patch 6 vs your IRQ masking changes?). Ah, I see it, rebase can cope with that, but not application. Bah. Another week of waiting for it to be applied. :( I'm going to start sending larger patch series... -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!