From: Simon Horman <horms@kernel.org>
To: "Rangoju, Raju" <raju.rangoju@amd.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, pabeni@redhat.com, edumazet@google.com,
davem@davemloft.net, andrew+netdev@lunn.ch,
maxime.chevallier@bootlin.com, Shyam-sundar.S-k@amd.com
Subject: Re: [PATCH net-next v4 5/5] amd-xgbe: add ethtool jumbo frame selftest
Date: Wed, 29 Oct 2025 16:14:24 +0000 [thread overview]
Message-ID: <aQI9YANbRWL3LFvf@horms.kernel.org> (raw)
In-Reply-To: <56a8ffbf-7e4a-46fd-9c7a-ad3c32c5eb0a@amd.com>
On Wed, Oct 29, 2025 at 10:25:03AM +0530, Rangoju, Raju wrote:
>
>
> On 10/29/2025 7:44 AM, Jakub Kicinski wrote:
> > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> >
> >
> > On Tue, 28 Oct 2025 14:19:23 +0530 Raju Rangoju wrote:
> > > skb = skb_unshare(skb, GFP_ATOMIC);
> > > if (!skb)
> > > - goto out;
> > > + goto out;;
> >
> > double semicolon
>
> Thanks Jakub, Please let me know if re-spinning the series is needed.
>
> > --
> > pw-bot: cr
Hi Raju,
The annotation from Jakub above would have marked the series
as Changes Requested in patchwork.
So I think that, yes, a re-spin is being requested.
next prev parent reply other threads:[~2025-10-29 16:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 8:49 [PATCH net-next v4 2/5] amd-xgbe: introduce support ethtool selftest Raju Rangoju
2025-10-28 8:49 ` [PATCH net-next v4 3/5] amd-xgbe: add ethtool phy selftest Raju Rangoju
2025-10-28 8:49 ` [PATCH net-next v4 4/5] amd-xgbe: add ethtool split header selftest Raju Rangoju
2025-10-28 8:49 ` [PATCH net-next v4 5/5] amd-xgbe: add ethtool jumbo frame selftest Raju Rangoju
2025-10-29 2:14 ` Jakub Kicinski
2025-10-29 4:55 ` Rangoju, Raju
2025-10-29 16:14 ` Simon Horman [this message]
2025-10-29 19:16 ` Rangoju, Raju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQI9YANbRWL3LFvf@horms.kernel.org \
--to=horms@kernel.org \
--cc=Shyam-sundar.S-k@amd.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=raju.rangoju@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).