From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E87922D24B4; Wed, 29 Oct 2025 16:50:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761756620; cv=none; b=fLyqJBIUSfwzjhySHK8lDfWOkJm05MwhrWrH83cnPlDJ+NQVnNe9a953f1XfNyC3rQIighhrPpQ9/G3cDBNftAjLHbLskynNiv5ozcF50lRTfXoF7K8l/4Rg/C23M9Oasc0P6Zr6y6Q8rxnKQgHanIj1N5XX7zQM1T2j7Q2RCaM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761756620; c=relaxed/simple; bh=hYRW+X8pMcb2ZzVrrEksNmJaTmIrkeo60sx4OKvUG/w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=A+PgV/PiCUp0oSvQllIwPavzUItF2sC/zCOQGB0Q5gN6YrN2aqgNDnUJA+8o7tSvkx1KS3G2SoE5eyT28yY5FhaCinWOIfOlzDSf3729i+FQBloGKz5jas00F3/Nd8Bit9EJRKxdhn9Fe/vGSqscmPZPK0ystpbvPnUPS2y65m8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=T6Woaoc4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="T6Woaoc4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D76D7C4CEF8; Wed, 29 Oct 2025 16:50:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1761756619; bh=hYRW+X8pMcb2ZzVrrEksNmJaTmIrkeo60sx4OKvUG/w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T6Woaoc4Cq9YOMkKIKv2HpuqXctdbQekZkN35NcSt4n5u61/TX//refZ5Fl0ZfxPq rvlicEr42rRJWnckoASNCLBFdHLsHL9rD+DphTWfa/VaRLsba7cTXq3qjwB84wDmtZ VUPeLMyN84QltryqfVHceXniiOOimw9pKgtojngcalu6rc+VtqJcjcRyWef1o1+DkP Kdnc6ZqT/KdUchdG2390Fp4Ls337BjjTde0EnKkC8HyR6xDSTr5S2LBtHQcfgQQHpw wdXPi49mF7OeFM2mZWkAo7iVbX0H84m7e5FPsQy7y4mpiTr7Mih21f5rXCgxw9pjCL zZhRS5gb6Sy9g== Date: Wed, 29 Oct 2025 16:50:14 +0000 From: Simon Horman To: Ankit Khushwaha Cc: Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , Phil Sutter , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shuah Khan , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Muhammad Usama Anjum Subject: Re: [PATCH v2] selftest: net: fix socklen_t type mismatch in sctp_collision test Message-ID: References: <20251028172947.53153-1-ankitkhushwaha.linux@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251028172947.53153-1-ankitkhushwaha.linux@gmail.com> On Tue, Oct 28, 2025 at 10:59:47PM +0530, Ankit Khushwaha wrote: > Socket APIs like recvfrom(), accept(), and getsockname() expect socklen_t* > arg, but tests were using int variables. This causes -Wpointer-sign > warnings on platforms where socklen_t is unsigned. > > Change the variable type from int to socklen_t to resolve the warning and > ensure type safety across platforms. > > warning fixed: > > sctp_collision.c:62:70: warning: passing 'int *' to parameter of > type 'socklen_t *' (aka 'unsigned int *') converts between pointers to > integer types with different sign [-Wpointer-sign] > 62 | ret = recvfrom(sd, buf, sizeof(buf), > 0, (struct sockaddr *)&daddr, &len); > | ^~~~ > /usr/include/sys/socket.h:165:27: note: passing argument to > parameter '__addr_len' here > 165 | socklen_t *__restrict __addr_len); > | ^ > > Reviewed-by: Muhammad Usama Anjum > Signed-off-by: Ankit Khushwaha Thanks for the update. Reviewed-by: Simon Horman