From: Simon Horman <horms@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Wang Liang <wangliang74@huawei.com>,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, shuah@kernel.org, acardace@redhat.com,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, yuehaibing@huawei.com,
zhangchangzhong@huawei.com
Subject: Re: [PATCH net] selftests: netdevsim: Fix ethtool-coalesce.sh fail by installing ethtool-common.sh
Date: Wed, 29 Oct 2025 17:37:43 +0000 [thread overview]
Message-ID: <aQJQ57TPZqKbNCRJ@horms.kernel.org> (raw)
In-Reply-To: <20251028170842.3fdaea7e@kernel.org>
On Tue, Oct 28, 2025 at 05:08:42PM -0700, Jakub Kicinski wrote:
> On Tue, 28 Oct 2025 17:14:03 +0000 Simon Horman wrote:
> > > +TEST_FILES := ethtool-common.sh
> > > +
> > > include ../../../lib.mk
> >
> > Hi Wang Liang,
> >
> > As per commit f07f91a36090 ("selftests: net: unify the Makefile formats")
> > I think the desired format is as follows (completely untested!):
> >
> > TEST_FILES := \
> > ethtool-common.sh \
> > # end of TEST_PROGS
>
> I believe we (intentionally) allow simple single entry assignment like
> in this patch. But there have been bugs in this check which I only fixed
> last weekend so please LMK if I'm missing something..
Sorry, I was just going by manual inspection. If the patch meets
your expectations as-is, then there are no further objections from me.
next prev parent reply other threads:[~2025-10-29 17:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 4:30 [PATCH net] selftests: netdevsim: Fix ethtool-coalesce.sh fail by installing ethtool-common.sh Wang Liang
2025-10-28 17:14 ` Simon Horman
2025-10-29 0:08 ` Jakub Kicinski
2025-10-29 17:37 ` Simon Horman [this message]
2025-10-29 7:56 ` Wang Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQJQ57TPZqKbNCRJ@horms.kernel.org \
--to=horms@kernel.org \
--cc=acardace@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=wangliang74@huawei.com \
--cc=yuehaibing@huawei.com \
--cc=zhangchangzhong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).