From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 036BB1D7E41 for ; Thu, 30 Oct 2025 06:00:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761804035; cv=none; b=G43gJmug85aOaSZJEnu0w2BktXpt7ixsdIDoUyQb1/F2uLm0oQxOIKPAs8PllcdXvqAqb3gBa0n9uQUnJFLTXcnSeK75MyAealVuODHqS4i4lxiR55j4kvOmUzibRnJ63GebAmoSckEcMTgD29Rdjox+X9WKPoRwaKSEArq6jDg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761804035; c=relaxed/simple; bh=XEAjlwYYF3NQuyc7FS9cFXhCUN5UMP++EuqVshoBY3U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZLjorGmBXoZJmVKpbRShU81ABVN+Yp7drSkikNK7wEhEUk+g4EjGfw9cHeN1QR8m2bpzHMjWnbP6Gsjta8SYDitem3P3AI1Ft2DXyoL4/pNp7d6YDppeCiDIXE8EfzW2JunhUBeYGLKUxlwOVsa4lVrGr14IJGbPGSyAR41lWzk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eVu1WSoz; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eVu1WSoz" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-76e2ea933b7so684662b3a.1 for ; Wed, 29 Oct 2025 23:00:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761804033; x=1762408833; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4uR81dh1lUx0VLG29+RqKpRKmy+JaoTRfZUvtKc3mPg=; b=eVu1WSozcmCeyuJlU2bjQPfHQ1lOyNLL+HY3Q+nBMSlouc9dXaDfLCOmjWHuq0O8I2 ZyW7qnypVTTPA3JoJEW1AhvlK36tVnzROvyRjn6B+BEy0qKmgo/Ce1J2gZsYDjDu7c1K UTe3EPy4fO6XozrguzbztA/Iyi2BK7si9hT9XtoHM1Wy21cbFdCK3gaxmYDEq3oYfy/8 v02soMRh8clDGOorIUW6KedX4NwV+VhSG6cGSDpoWtNa5CXdJkiXo38r74TShJ99gnqD Ibj/yX/JBN7gVR9xyXhMB1cwweNlPoZw1dR1ASlns0PgXvRbKMtRRQU8GejKvRQ1069X 5wNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761804033; x=1762408833; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4uR81dh1lUx0VLG29+RqKpRKmy+JaoTRfZUvtKc3mPg=; b=Di8GtwxDv7RzOF/HhDriyatJg7jL2cpSCCZB8abP60tBHU3qIVLA2kacfuAae4XTDv qsoLZJcan9gqT/ph3nQB2qPg4KZiIMDOjdreP1FbG1dZu7/aEO1CVEE2wR9jL8xo2GrE lsdbyGR9oAcuGsKZrweFpQD9jqzpjkGLLJBRLJoS5OpIqdsfCtx9OlqWyd/9fbFkBfoK oWR40DOycN0Lr7Uk7M3ULXzXGFF+zmT2mBtNYavVECTjmqQTpwP/MWfMqrL4+KNOIA9A Q/w/r4iFXsBD2ATaX2W1OepffpbwuwGnlrQ6NMUP+1YDsTLYhy8IFBJPX9Cu2Bt5nQee M6nw== X-Gm-Message-State: AOJu0YzcawNCXLPOryNW7I35Qqh+/kOLW9eS8O1eT0qn+N7+0wYzRaPq SYvAn9HA/8yTUc6K+Lpo0fe609id0elhpheb0ejLykQtBKX4+rvEnvKf X-Gm-Gg: ASbGnctELfM1uy+ATn2u31gsnD2iZvN3zgwAN4ZfbU+vMvMFMXSI5G2xCkKrfp8wYfF Oj9yKHeFtfcN/bVQHjNZHi/5sIESBPM+MBVtCrFihhkjqn6bHx+o9ustwB9TxtCPZ/H9Uf3ww5s gvuzSERCj7/aHAggEMNMI7YIe1iJLF1hPQPdW6BZGqItP8TYIbcmAFcXB31C7VelU7DzMbX3ASH n6oqmMO7RTkqKtvOBugnDvy96BmUFXvtvDxTs6gOyeEKw7KDIK8WZuzfpkn6DRVj4IoiFax/yGx C32oKN8Kp4r/GAlb4ZxCwLWJWryG1RR0K4ZF+OnWHtJ4bDghzTl/Vb5/s0DWYnAjsaVE2avFU4u Dhn/EvEI4ulI7sdn4HBd9ZxIeZmzTQi45ujRBNjOSx3GzRyIiOPE92uwFxAWjBB6renrZacICuE eIMm2//Gh7LrEgvIk= X-Google-Smtp-Source: AGHT+IHkrFWmM0YexxS5c3JBOQRGZUBm0Gg/W5HZtvWbmHHj7ZUGTnyMBtNr/t6pp99vomcNW46A6g== X-Received: by 2002:a05:6a21:3510:b0:2da:3fe0:3299 with SMTP id adf61e73a8af0-3477aba1180mr3086189637.7.1761804033077; Wed, 29 Oct 2025 23:00:33 -0700 (PDT) Received: from fedora ([209.132.188.88]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b71268bdd50sm16016865a12.0.2025.10.29.23.00.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Oct 2025 23:00:32 -0700 (PDT) Date: Thu, 30 Oct 2025 06:00:24 +0000 From: Hangbin Liu To: Jakub Kicinski Cc: netdev@vger.kernel.org, Donald Hunter , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Jan Stancek , "Matthieu Baerts (NGI0)" , =?iso-8859-1?Q?Asbj=F8rn_Sloth_T=F8nnesen?= , Stanislav Fomichev , Shuah Khan , Ido Schimmel , Guillaume Nault , Petr Machata , linux-kselftest@vger.kernel.org Subject: Re: [PATCH net-next 3/3] selftests: net: add YNL test framework Message-ID: References: <20251029082245.128675-1-liuhangbin@gmail.com> <20251029082245.128675-4-liuhangbin@gmail.com> <20251029164159.2dbc615a@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251029164159.2dbc615a@kernel.org> On Wed, Oct 29, 2025 at 04:41:59PM -0700, Jakub Kicinski wrote: > On Wed, 29 Oct 2025 08:22:45 +0000 Hangbin Liu wrote: > > Add a test framework for YAML Netlink (YNL) tools, covering both CLI and > > ethtool functionality. The framework includes: > > > > 1) cli: family listing, netdev, ethtool, rt-* families, and nlctrl > > operations > > 2) ethtool: device info, statistics, ring/coalesce/pause parameters, and > > feature gettings > > > > The current YNL syntax is a bit obscure, and end users may not always know > > how to use it. This test framework provides usage examples and also serves > > as a regression test to catch potential breakages caused by future changes. > > Hm, my knee-jerk reaction was that we should avoid adding too much ynl > stuff to the kernel at this point. But looking closer it's not that > long. > > Do I understand correctly, tho, that you're testing _system_ YNL? > Not what's in tree? Kind of. With this we can test both the system's YNL and also make sure the YNL interface has no regression. Thanks Hangbin