From: Simon Horman <horms@kernel.org>
To: Joshua Washington <joshwash@google.com>
Cc: netdev@vger.kernel.org, Tim Hostetler <thostet@google.com>,
Richard Cochran <richardcochran@gmail.com>
Subject: Re: [PATCH net 0/2] gve: Fix NULL dereferencing with PTP clock
Date: Thu, 30 Oct 2025 09:43:54 +0000 [thread overview]
Message-ID: <aQMzWoIQvSa9ywe4@horms.kernel.org> (raw)
In-Reply-To: <20251029184555.3852952-1-joshwash@google.com>
On Wed, Oct 29, 2025 at 11:45:38AM -0700, Joshua Washington wrote:
> From: Tim Hostetler <thostet@google.com>
>
> This patch series fixes NULL dereferences that are possible with gve's
> PTP clock due to not stubbing certain ptp_clock_info callbacks.
>
> Tim Hostetler (2):
> gve: Implement gettimex64 with -EOPNOTSUPP
> gve: Implement settime64 with -EOPNOTSUPP
>
> drivers/net/ethernet/google/gve/gve_ptp.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
Hi Joshua and Tim,
I think that the approach of enhancing the caller to only
call these callbacks if they are non NULL, as per the patch below,
seems more robust. It would fix all drivers in one go.
- [PATCH] ptp: guard ptp_clock_gettime() if neither gettimex64 nor
https://lore.kernel.org/all/20251028095143.396385-1-junjie.cao@intel.com/
next prev parent reply other threads:[~2025-10-30 9:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 18:45 [PATCH net 0/2] gve: Fix NULL dereferencing with PTP clock Joshua Washington
2025-10-29 18:45 ` [PATCH net 1/2] gve: Implement gettimex64 with -EOPNOTSUPP Joshua Washington
2025-10-29 18:45 ` [PATCH net 2/2] gve: Implement settime64 " Joshua Washington
2025-10-30 9:43 ` Simon Horman [this message]
2025-10-30 9:48 ` [PATCH net 0/2] gve: Fix NULL dereferencing with PTP clock Simon Horman
2025-10-30 17:01 ` Tim Hostetler
2025-10-31 23:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQMzWoIQvSa9ywe4@horms.kernel.org \
--to=horms@kernel.org \
--cc=joshwash@google.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=thostet@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).