From: Sabrina Dubroca <sd@queasysnail.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org,
Steffen Klassert <steffen.klassert@secunet.com>,
David Ahern <dsahern@kernel.org>
Subject: Re: [PATCH iproute2-next] ip-xfrm: add pcpu-num support
Date: Fri, 31 Oct 2025 00:51:46 +0100 [thread overview]
Message-ID: <aQP6Ev_21Z45JuG9@krikkit> (raw)
In-Reply-To: <20251030090615.28552eeb@phoenix>
2025-10-30, 09:06:15 -0700, Stephen Hemminger wrote:
> On Wed, 29 Oct 2025 12:06:16 +0100
> Sabrina Dubroca <sd@queasysnail.net> wrote:
>
> > diff --git a/ip/ipxfrm.c b/ip/ipxfrm.c
> > index b15cc0002e5b..586d24fb8594 100644
> > --- a/ip/ipxfrm.c
> > +++ b/ip/ipxfrm.c
> > @@ -919,6 +919,12 @@ void xfrm_xfrma_print(struct rtattr *tb[], __u16 family, FILE *fp,
> > fprintf(fp, "other (%d)", dir);
> > fprintf(fp, "%s", _SL_);
> > }
> > + if (tb[XFRMA_SA_PCPU]) {
> > + __u32 pcpu_num = rta_getattr_u32(tb[XFRMA_SA_PCPU]);
> > +
> > + fprintf(fp, "\tpcpu-num %u", pcpu_num);
> > + fprintf(fp, "%s", _SL_);
> > + }
> > }
> >
> Reminds me that xfrm is overdue for conversion to JSON output.
Right. It's been on my todo list for years but I've never gotten to
it. :(
With the netlink specs project, it's also maybe less attractive?
(netlink spec for ipsec is also on my todo list and I've given
it a look, ipxfrm conversion is probably easier)
--
Sabrina
next prev parent reply other threads:[~2025-10-30 23:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 11:06 [PATCH iproute2-next] ip-xfrm: add pcpu-num support Sabrina Dubroca
2025-10-30 16:06 ` Stephen Hemminger
2025-10-30 23:51 ` Sabrina Dubroca [this message]
2025-10-31 1:32 ` David Ahern
2025-11-03 9:48 ` Sabrina Dubroca
2025-11-03 16:36 ` David Ahern
2025-11-04 13:06 ` Sabrina Dubroca
2025-11-03 16:47 ` David Ahern
2025-11-04 13:27 ` Sabrina Dubroca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQP6Ev_21Z45JuG9@krikkit \
--to=sd@queasysnail.net \
--cc=dsahern@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).