From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7303A1B7F4 for ; Mon, 3 Nov 2025 05:12:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762146774; cv=none; b=KJuueE5GTckIx8oOQ/zViX3zD9fxXB//XbApI2YIDRrzXw3VXbCDkKor5Soxaag1S+kvgSXaIsmSsyo/eC4OmSqy6qFobWrspMYvLhefYYfP0FJlXobQg9pj29KjJdJ0oXrEF7W5/jbTsKbtVq1GIW+tULlFzSUpzt7fDJnTAvU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762146774; c=relaxed/simple; bh=YrlqCfaqyBZJL8zxbvPY24vo8xlmOetjJXuiQh+Lm7s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hRpifcv1YwUj1CjnXm6kHMmrw47skAiLhj9u4SYxAwQrurdG0Sg37P2GF7asFtS6X+LdFD04EzNyqwvoP2PaYHDmieLRmLLEa4vauXUv1im+bbpd2ddL0uClYSwdJNAh1HkVQP7keFIRhiJMbqPPf3jPQ7uO5eheGT8yuDCS+4g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZKTdPFrq; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZKTdPFrq" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-7aa2170adf9so597148b3a.0 for ; Sun, 02 Nov 2025 21:12:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762146772; x=1762751572; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=53Y4J0pYrNQqP0ePl9L2M/4VMzg2WxKWv9mG/vikazQ=; b=ZKTdPFrqJzNiXDeyzBehgo8wpIvcTk0VYUMtv0mJFzK1qu19p+U7HfPIVivGiVf3ux gNB5370LbchwS4DY8kAGTAQ128Odx5nGA1vG3EaVQUP614mcs/BwkN337YfI5d4iR9C0 /kJ9ZQCkg+/Q9EYmS5vbz8j6ZqjiFebs16YVC3LML4KyGrdSsMfsC58tzGt2eZ7fsC/A 2w58qgqu7VmhDWk91SCtNcBRBaBoU5DNteXcw9/41v8KA4eT7GvXWZsOL4GlysQYyAlH r3YH814JI9FNAyFM6rcLH7yzUtXX9nI8/C4Sm+wFOghQQxrK27PnLHb+MXO9GLBJRKtv sXXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762146773; x=1762751573; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=53Y4J0pYrNQqP0ePl9L2M/4VMzg2WxKWv9mG/vikazQ=; b=FzTwZMCe2zxR968L8bVKXEwLpR/teS1jkzkYjFLsCXOiDTAW7Fq+AsSk/Q3Un8BQO1 fwEbHbhid/q2z45YPmawBCmhnFZn9YIYWt78oi7TYK58Yyq1IXF2bMcxtcdScHnGB+yc gpmy8fG5ydEHwWFA71eIpIc2YFXXS4K2DOhyb093j+cdMd4RuSE16zN+ORxolc85mpoi UobIHKgroF5t72O8/Tmmo6ONNS/GnhAkvUfVdWVN13a1aTpEyUxyABWNDNSNfBpn0JFb 07ILCz3x8GsrAG/L+fSVbs//l0VVH79r3xGXzYoN/YBx1JM12LhYMMMp53f4BwJYuQ2S tVZg== X-Gm-Message-State: AOJu0YwYMWVT/ycg6sVWtj7r6hGX5xBpMYUCM4+2mALdYAwvtDp5nvcA ZdesPK2nLq6css9WHw2X7W4REDZpEMSdJ5yuGeMOp1KEbX8MXZ6EZrx7 X-Gm-Gg: ASbGncvQZJAdNpiykbZrhEoOqvmDr2abFUUfPGzuZmuPZpI3kifBI5zcJJkLKEv50qd 7XihSsH9kbh0q4JuyiJGvsstDnh42gJgye1yoEFsQXHOzhd5y3RqVP5IXZns91hA+zbFIhmk9BX qSHlGjy0jSYfuRvDiWT7gHX25o4uGw/mhV5cnN0vO+JhcApAUObqX+bjolIllpx9xD596LgmT5L wS/H+aXnTvShn1CzqrvRW8BQPN0fJQ5E6Lum5YEh14Vjw1ZTFDC6cxto6BTHqUP+4A9Uq/v6xts PGBDRZokQIzkmSrADtb62vXd6X9aKkoy6Z+oGJfzMm/wn94s3nF/x5y9csRsEFgt+DkG2jUFK0M CkbfGlqBP1m7tHxugnmYO4yFPaG+KG3fEcUx2ndYq1iAlj4+KTIuTZtODea2MqFP4UvGo694TCy w6VaP/ X-Google-Smtp-Source: AGHT+IEFKuT4chWVteF92qguLHXYW1uXR8F18FiEVrtnfDbDi+7SKkfi8PSIO4tIekZXseQLHk4yjA== X-Received: by 2002:a05:6a20:5491:b0:341:84ee:75af with SMTP id adf61e73a8af0-348cc0c0a17mr15804544637.49.1762146772523; Sun, 02 Nov 2025 21:12:52 -0800 (PST) Received: from fedora ([209.132.188.88]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b95c44f7363sm6919427a12.6.2025.11.02.21.12.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Nov 2025 21:12:51 -0800 (PST) Date: Mon, 3 Nov 2025 05:12:43 +0000 From: Hangbin Liu To: Jakub Kicinski Cc: netdev@vger.kernel.org, Donald Hunter , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Jan Stancek , "Matthieu Baerts (NGI0)" , =?iso-8859-1?Q?Asbj=F8rn_Sloth_T=F8nnesen?= , Stanislav Fomichev , Shuah Khan , Ido Schimmel , Guillaume Nault , Petr Machata , linux-kselftest@vger.kernel.org Subject: Re: [PATCH net-next 3/3] selftests: net: add YNL test framework Message-ID: References: <20251029082245.128675-1-liuhangbin@gmail.com> <20251029082245.128675-4-liuhangbin@gmail.com> <20251029164159.2dbc615a@kernel.org> <20251030083944.722833ac@kernel.org> <20251031112406.403d1971@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251031112406.403d1971@kernel.org> On Fri, Oct 31, 2025 at 11:24:06AM -0700, Jakub Kicinski wrote: > > I just do `make install` in tools/net/ynl. Both the ynl scripts and specs are > > installed. So I think the specs are also tested. > > > > I didn't get here. The `ynl` calls pyynl.cli:main, that should be enough. > > Do you mean we should find the `cli.py` path and call it like > > `$source_code/tools/net/ynl/pyynl/cli.py --spec > > $source_code/Documentation/netlink/specs/xxx.yaml ...`? > > More or less. But it needs to know how to install itself when kernel > selftests are installed. Maybe it's not worth the complexity and we > should add the script under tools/net/ynl. Easier to refer from there. Hmm, how should we execute the script under `tools/net/ynl`? Use the cli.py like: ./cli.py --spec ../../../Documentation/netlink/specs/xxx.yaml Or use the installed name `ynl` ynl --family xxx ... Thanks Hangbin