From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08EED272801; Mon, 3 Nov 2025 13:58:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762178333; cv=none; b=V7Xp3iz1kjQ1uitajY1tUZAvxaOEiLROiaYNRtVixigpFXCUoSxyisLKN5qGubVPlL+z/d0SoQAZnzHEgDceg8qaQvLwHx7wZua7Ks23MN5BkTy4Y/sC0RDYc86CVdL8dyAh6GkKI7dA+I5f1PoCPrC3IMG1gMfMtRbsygy1sb0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762178333; c=relaxed/simple; bh=CVpW39VvM+rcZYs4RPQFrCUx5jX1/vW3YR+Et2rrxZ4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ojZ04gsC/F2S7Dw1WHIC2j9ZOcgsIaoAvCcxL1VMBsfbtxTVxMFpmwyHw4fdflVxfzodNfhJkGhRveCReUMnBA6DcNRLJVJF0GzvAkHnHdjW3u3cS6VTn2BZzlguyfjCTDJAs2yomvdyFaVyky+JinvTw/WafeMSWHR5MtdKPac= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=b3sgFmY1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="b3sgFmY1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F3C43C4CEFD; Mon, 3 Nov 2025 13:58:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762178329; bh=CVpW39VvM+rcZYs4RPQFrCUx5jX1/vW3YR+Et2rrxZ4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=b3sgFmY1Wn1wg9ie1Q+cm6HjMRgl5g1p5sYoCMJIHNUY/S1O+m/QtoikwPbHVms7j Qn/yoGtu25LJqFnuOQBhggtDTIeAdo0lBsSJ9DedQoWlvFIGWoC9Ml7pIBoRp8kJAv 7QTKnsWi3VEVlO0niNPazhoDX2Xn3WyDaBKmYD/N+zsSn8Da9C06H3PEPVWKbuEhGO r7K57o4r/5rC+78PXIaAkS7OJe7EDKwWC76rNLiUaTc+gpAuHKpnWFfyidT+GSZmj6 d1O/7r6QQdROsU1ClK7CqFHTOMiHyzRWwIA17BD5q7c80N0wbTm4w+GlI3MsZB1R7E XHakMsEgF1zEA== Date: Mon, 3 Nov 2025 13:58:44 +0000 From: Simon Horman To: Tariq Toukan Cc: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" , Saeed Mahameed , Leon Romanovsky , Mark Bloch , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Gal Pressman , Carolina Jubran Subject: Re: [PATCH net-next V2 5/7] net/mlx5e: Do not re-apply TIR loopback configuration if not necessary Message-ID: References: <1761831159-1013140-1-git-send-email-tariqt@nvidia.com> <1761831159-1013140-6-git-send-email-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1761831159-1013140-6-git-send-email-tariqt@nvidia.com> On Thu, Oct 30, 2025 at 03:32:37PM +0200, Tariq Toukan wrote: > On old firmware, (tis_tir_td_order=0), TIR of a transport domain should > either be created after all SQs of the same domain, or TIR.self_lb_en > should be reapplied using MODIFY_TIR, for self loopback filtering to > function correctly. > > This is not necessary anymnore on new FW (tis_tir_td_order=1), thus > there's no need for calling modify_tir operations after creating a new > set of SQs to maintain the self loopback prevention functional. > > Skip these operations. > > This saves O(max_num_channels) MODIFY_TIR firmware commands in > operations like interface up or channels configuration change. > > Signed-off-by: Tariq Toukan > Reviewed-by: Carolina Jubran Reviewed-by: Simon Horman