From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Yao Zi <ziyao@disroot.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Yanteng Si <si.yanteng@linux.dev>,
Huacai Chen <chenhuacai@kernel.org>,
Philipp Stanner <phasta@kernel.org>,
Tiezhu Yang <yangtiezhu@loongson.cn>,
Qunqin Zhao <zhaoqunqin@loongson.cn>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Furong Xu <0x1207@gmail.com>,
Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
Jacob Keller <jacob.e.keller@intel.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 3/3] net: stmmac: pci: Use generic PCI suspend/resume routines
Date: Tue, 4 Nov 2025 17:23:35 +0000 [thread overview]
Message-ID: <aQo2l-E9Z0tTJKlb@shell.armlinux.org.uk> (raw)
In-Reply-To: <20251104151647.3125-4-ziyao@disroot.org>
On Tue, Nov 04, 2025 at 03:16:47PM +0000, Yao Zi wrote:
> Convert STMMAC PCI glue driver to use the generic platform
> suspend/resume routines for PCI controllers, instead of implementing its
> own one.
>
> Signed-off-by: Yao Zi <ziyao@disroot.org>
> ---
> drivers/net/ethernet/stmicro/stmmac/Kconfig | 5 +--
> .../net/ethernet/stmicro/stmmac/stmmac_pci.c | 36 ++-----------------
> 2 files changed, 6 insertions(+), 35 deletions(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/Kconfig b/drivers/net/ethernet/stmicro/stmmac/Kconfig
> index 7ec7c7630c41..59aa04e71aab 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/Kconfig
> +++ b/drivers/net/ethernet/stmicro/stmmac/Kconfig
> @@ -378,8 +378,6 @@ config DWMAC_LOONGSON
> This selects the LOONGSON PCI bus support for the stmmac driver,
> Support for ethernet controller on Loongson-2K1000 SoC and LS7A1000 bridge.
>
> -endif
> -
> config STMMAC_PCI
> tristate "STMMAC PCI bus support"
> depends on STMMAC_ETH && PCI
As per patch 2, this line can be removed.
Otherwise, looks good, thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
prev parent reply other threads:[~2025-11-04 17:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-04 15:16 [PATCH net-next v3 0/3] Unify platform suspend/resume routines for PCI DWMAC glue Yao Zi
2025-11-04 15:16 ` [PATCH net-next v3 1/3] net: stmmac: Add generic suspend/resume helper for PCI-based controllers Yao Zi
2025-11-04 17:20 ` Russell King (Oracle)
2025-11-04 15:16 ` [PATCH net-next v3 2/3] net: stmmac: loongson: Use generic PCI suspend/resume routines Yao Zi
2025-11-04 17:22 ` Russell King (Oracle)
2025-11-05 3:21 ` Yao Zi
2025-11-04 15:16 ` [PATCH net-next v3 3/3] net: stmmac: pci: " Yao Zi
2025-11-04 17:23 ` Russell King (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQo2l-E9Z0tTJKlb@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=0x1207@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=chenhuacai@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=phasta@kernel.org \
--cc=si.yanteng@linux.dev \
--cc=vladimir.oltean@nxp.com \
--cc=yangtiezhu@loongson.cn \
--cc=zhaoqunqin@loongson.cn \
--cc=ziyao@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).