From: Simon Horman <horms@kernel.org>
To: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: netdev@vger.kernel.org, 'Andrew Lunn' <andrew+netdev@lunn.ch>,
"'David S. Miller'" <davem@davemloft.net>,
'Eric Dumazet' <edumazet@google.com>,
'Jakub Kicinski' <kuba@kernel.org>,
'Paolo Abeni' <pabeni@redhat.com>,
'Mengyuan Lou' <mengyuanlou@net-swift.com>,
stable@vger.kernel.org
Subject: Re: [PATCH net] net: libwx: fix device bus LAN ID
Date: Wed, 5 Nov 2025 11:47:29 +0000 [thread overview]
Message-ID: <aQs5UeY214tiuL3f@horms.kernel.org> (raw)
In-Reply-To: <093901dc4e3b$b753c630$25fb5290$@trustnetic.com>
On Wed, Nov 05, 2025 at 06:05:29PM +0800, Jiawen Wu wrote:
> On Wed, Nov 5, 2025 5:59 PM, Simon Horman wrote:
> > On Tue, Nov 04, 2025 at 02:23:21PM +0800, Jiawen Wu wrote:
> > > The device bus LAN ID was obtained from PCI_FUNC(), but when a PF
> > > port is passthrough to a virtual machine, the function number may not
> > > match the actual port index on the device. This could cause the driver
> > > to perform operations such as LAN reset on the wrong port.
> > >
> > > Fix this by reading the LAN ID from port status register.
> > >
> > > Fixes: a34b3e6ed8fb ("net: txgbe: Store PCI info")
> > > Cc: stable@vger.kernel.org
> > > Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
> >
> > Hi Jiawen Wu,
> >
> > I am wondering if these devises also support port swapping (maybe LAN
> > Function Select bit of FACTPS). And if so, does it need to be taken into
> > account here?
>
> Does not support yet, thanks. :)
Thanks, in that case this patch looks good to me.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-11-05 11:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-04 6:23 [PATCH net] net: libwx: fix device bus LAN ID Jiawen Wu
2025-11-05 9:58 ` Simon Horman
2025-11-05 10:05 ` Jiawen Wu
2025-11-05 11:47 ` Simon Horman [this message]
2025-11-06 2:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQs5UeY214tiuL3f@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiawenwu@trustnetic.com \
--cc=kuba@kernel.org \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).