From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49912303C86; Wed, 5 Nov 2025 11:47:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762343253; cv=none; b=lPTaKXkJ6iU+aj1OiT+tLXOcLFOr4jhvwwTIHtrTNwZHkBqutZsbFnt24YTvaRgY8c7G98XB/84Uubyp/wtHAMHma/sECsLt8AH/1X+O6/V6LAHC8sX/z3t9oa7QSckJhGcm2vO6gmDqtjVX0OgMX9fg5L8sCqIGv6yVvhYWLUw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762343253; c=relaxed/simple; bh=rByHzTDi8GNI4VjgdYw6keFPO0iICIg6fPIKaXxnABc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sBv7OAqipFCw/wMBSjsS6RMIZiI09VFU82CecTiUmRf/Tp74MmYrjuCL7y1MxcCfSwWUXJfbojgvYdYyYct4/B5atC494NTEt9xzsu2PoqaV9vCu+uamjVw5vvgiyiEIb/kiKwdFsR7X4qJ3xNaWMg3heKZBTmNMAJshTGhGdz4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cg86LLZm; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cg86LLZm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 07B72C4CEF8; Wed, 5 Nov 2025 11:47:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762343252; bh=rByHzTDi8GNI4VjgdYw6keFPO0iICIg6fPIKaXxnABc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cg86LLZmZvaS640pryi2nqiIXgCYl+2loDa4wCmigGCPFYqxEfdcimuJQegQBKLAn JGstJyrE36Z4DWcgmjabR46+0HuqdLlqRni49TyrctQC1j4h4vpBFUJBR0FSZ0rVKA 5Po69MmtyqZ9aLUudcv3EHLqYOUrGuf78Pu8h/wbMd2JJWDv/kOB9q5e04GWVidQrz VCQ8+Dg68EWSX772eUT2G/9LNmmGMPkFkh+2DCdQKikNpQFI6fr1N1PrhCeSCun97l Ro396elp4sC7nvfAmLsaTQJSPyWgw9SXl/kXx6Vy5MNioKQ2GtoXeosAXztX/pe9y7 2PpLayzOKdcbA== Date: Wed, 5 Nov 2025 11:47:29 +0000 From: Simon Horman To: Jiawen Wu Cc: netdev@vger.kernel.org, 'Andrew Lunn' , "'David S. Miller'" , 'Eric Dumazet' , 'Jakub Kicinski' , 'Paolo Abeni' , 'Mengyuan Lou' , stable@vger.kernel.org Subject: Re: [PATCH net] net: libwx: fix device bus LAN ID Message-ID: References: <093901dc4e3b$b753c630$25fb5290$@trustnetic.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <093901dc4e3b$b753c630$25fb5290$@trustnetic.com> On Wed, Nov 05, 2025 at 06:05:29PM +0800, Jiawen Wu wrote: > On Wed, Nov 5, 2025 5:59 PM, Simon Horman wrote: > > On Tue, Nov 04, 2025 at 02:23:21PM +0800, Jiawen Wu wrote: > > > The device bus LAN ID was obtained from PCI_FUNC(), but when a PF > > > port is passthrough to a virtual machine, the function number may not > > > match the actual port index on the device. This could cause the driver > > > to perform operations such as LAN reset on the wrong port. > > > > > > Fix this by reading the LAN ID from port status register. > > > > > > Fixes: a34b3e6ed8fb ("net: txgbe: Store PCI info") > > > Cc: stable@vger.kernel.org > > > Signed-off-by: Jiawen Wu > > > > Hi Jiawen Wu, > > > > I am wondering if these devises also support port swapping (maybe LAN > > Function Select bit of FACTPS). And if so, does it need to be taken into > > account here? > > Does not support yet, thanks. :) Thanks, in that case this patch looks good to me. Reviewed-by: Simon Horman