From: Simon Horman <horms@kernel.org>
To: Fan Gong <gongfan1@huawei.com>
Cc: Zhu Yikai <zhuyikai1@h-partners.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Markus.Elfring@web.de, pavan.chebbi@broadcom.com,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
luosifu <luosifu@huawei.com>, Xin Guo <guoxin09@huawei.com>,
Shen Chenyang <shenchenyang1@hisilicon.com>,
Zhou Shuai <zhoushuai28@huawei.com>, Wu Like <wulike1@huawei.com>,
Shi Jing <shijing34@huawei.com>,
Luo Yang <luoyang82@h-partners.com>,
Meny Yossefi <meny.yossefi@huawei.com>,
Gur Stavi <gur.stavi@huawei.com>
Subject: Re: [PATCH net-next v04 2/5] hinic3: Add PF management interfaces
Date: Wed, 5 Nov 2025 08:25:21 +0000 [thread overview]
Message-ID: <aQsJ8a4XXE3HXR7A@horms.kernel.org> (raw)
In-Reply-To: <2acb500c38c11b0234e8616da7c2a941c344659f.1761711549.git.zhuyikai1@h-partners.com>
On Wed, Oct 29, 2025 at 02:16:26PM +0800, Fan Gong wrote:
...
> diff --git a/drivers/net/ethernet/huawei/hinic3/hinic3_netdev_ops.c b/drivers/net/ethernet/huawei/hinic3/hinic3_netdev_ops.c
...
> +static void hinic3_print_link_message(struct net_device *netdev,
> + bool link_status_up)
> +{
> + struct hinic3_nic_dev *nic_dev = netdev_priv(netdev);
> +
> + if (nic_dev->link_status_up == link_status_up)
> + return;
> +
> + nic_dev->link_status_up = link_status_up;
> +
> + netdev_dbg(netdev, "Link is %s\n", (link_status_up ? "up" : "down"));
Hi Fan Gong, all,
Coccinelle suggests that str_up_down() could be used here,
which does seem like a reasonable suggestion as it seems
there will be a v5 anyway.
> +}
...
next prev parent reply other threads:[~2025-11-05 8:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 6:16 [PATCH net-next v04 0/5] net: hinic3: PF initialization Fan Gong
2025-10-29 6:16 ` [PATCH net-next v04 1/5] hinic3: Add PF framework Fan Gong
2025-10-29 6:16 ` [PATCH net-next v04 2/5] hinic3: Add PF management interfaces Fan Gong
2025-11-05 8:25 ` Simon Horman [this message]
2025-10-29 6:16 ` [PATCH net-next v04 3/5] hinic3: Add NIC configuration ops Fan Gong
2025-11-05 9:14 ` Simon Horman
2025-10-29 6:16 ` [PATCH net-next v04 4/5] hinic3: Add mac filter ops Fan Gong
2025-10-29 6:16 ` [PATCH net-next v04 5/5] hinic3: Add netdev register interfaces Fan Gong
2025-11-05 9:16 ` Simon Horman
2025-11-04 2:29 ` [PATCH net-next v04 0/5] net: hinic3: PF initialization Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQsJ8a4XXE3HXR7A@horms.kernel.org \
--to=horms@kernel.org \
--cc=Markus.Elfring@web.de \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gongfan1@huawei.com \
--cc=guoxin09@huawei.com \
--cc=gur.stavi@huawei.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luosifu@huawei.com \
--cc=luoyang82@h-partners.com \
--cc=meny.yossefi@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=shenchenyang1@hisilicon.com \
--cc=shijing34@huawei.com \
--cc=wulike1@huawei.com \
--cc=zhoushuai28@huawei.com \
--cc=zhuyikai1@h-partners.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).