* [PATCH net] selftests/vsock: avoid false-positives when checking dmesg
@ 2025-11-04 21:50 Bobby Eshleman
2025-11-05 11:16 ` Stefano Garzarella
0 siblings, 1 reply; 3+ messages in thread
From: Bobby Eshleman @ 2025-11-04 21:50 UTC (permalink / raw)
To: Stefano Garzarella, Shuah Khan, Jakub Kicinski, Bobby Eshleman
Cc: virtualization, netdev, linux-kselftest, linux-kernel,
Bobby Eshleman, Simon Horman
From: Bobby Eshleman <bobbyeshleman@meta.com>
Sometimes VMs will have some intermittent dmesg warnings that are
unrelated to vsock. Change the dmesg parsing to filter on strings
containing 'vsock' to avoid false positive failures that are unrelated
to vsock. The downside is that it is possible for some vsock related
warnings to not contain the substring 'vsock', so those will be missed.
Fixes: a4a65c6fe08b ("selftests/vsock: add initial vmtest.sh for vsock")
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Bobby Eshleman <bobbyeshleman@meta.com>
---
Previously was part of the series:
https://lore.kernel.org/all/20251022-vsock-selftests-fixes-and-improvements-v1-0-edeb179d6463@meta.com/
---
tools/testing/selftests/vsock/vmtest.sh | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/testing/selftests/vsock/vmtest.sh b/tools/testing/selftests/vsock/vmtest.sh
index edacebfc1632..e1732f236d14 100755
--- a/tools/testing/selftests/vsock/vmtest.sh
+++ b/tools/testing/selftests/vsock/vmtest.sh
@@ -389,9 +389,9 @@ run_test() {
local rc
host_oops_cnt_before=$(dmesg | grep -c -i 'Oops')
- host_warn_cnt_before=$(dmesg --level=warn | wc -l)
+ host_warn_cnt_before=$(dmesg --level=warn | grep -c -i 'vsock')
vm_oops_cnt_before=$(vm_ssh -- dmesg | grep -c -i 'Oops')
- vm_warn_cnt_before=$(vm_ssh -- dmesg --level=warn | wc -l)
+ vm_warn_cnt_before=$(vm_ssh -- dmesg --level=warn | grep -c -i 'vsock')
name=$(echo "${1}" | awk '{ print $1 }')
eval test_"${name}"
@@ -403,7 +403,7 @@ run_test() {
rc=$KSFT_FAIL
fi
- host_warn_cnt_after=$(dmesg --level=warn | wc -l)
+ host_warn_cnt_after=$(dmesg --level=warn | grep -c -i vsock)
if [[ ${host_warn_cnt_after} -gt ${host_warn_cnt_before} ]]; then
echo "FAIL: kernel warning detected on host" | log_host "${name}"
rc=$KSFT_FAIL
@@ -415,7 +415,7 @@ run_test() {
rc=$KSFT_FAIL
fi
- vm_warn_cnt_after=$(vm_ssh -- dmesg --level=warn | wc -l)
+ vm_warn_cnt_after=$(vm_ssh -- dmesg --level=warn | grep -c -i vsock)
if [[ ${vm_warn_cnt_after} -gt ${vm_warn_cnt_before} ]]; then
echo "FAIL: kernel warning detected on vm" | log_host "${name}"
rc=$KSFT_FAIL
---
base-commit: 255d75ef029f33f75fcf5015052b7302486f7ad2
change-id: 20251104-vsock-vmtest-dmesg-fix-b2c59e1d9c38
Best regards,
--
Bobby Eshleman <bobbyeshleman@meta.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] selftests/vsock: avoid false-positives when checking dmesg
2025-11-04 21:50 [PATCH net] selftests/vsock: avoid false-positives when checking dmesg Bobby Eshleman
@ 2025-11-05 11:16 ` Stefano Garzarella
2025-11-05 16:11 ` Bobby Eshleman
0 siblings, 1 reply; 3+ messages in thread
From: Stefano Garzarella @ 2025-11-05 11:16 UTC (permalink / raw)
To: Bobby Eshleman
Cc: Shuah Khan, Jakub Kicinski, virtualization, netdev,
linux-kselftest, linux-kernel, Bobby Eshleman, Simon Horman
On Tue, Nov 04, 2025 at 01:50:50PM -0800, Bobby Eshleman wrote:
>From: Bobby Eshleman <bobbyeshleman@meta.com>
>
>Sometimes VMs will have some intermittent dmesg warnings that are
>unrelated to vsock. Change the dmesg parsing to filter on strings
>containing 'vsock' to avoid false positive failures that are unrelated
>to vsock. The downside is that it is possible for some vsock related
>warnings to not contain the substring 'vsock', so those will be missed.
>
>Fixes: a4a65c6fe08b ("selftests/vsock: add initial vmtest.sh for vsock")
>Reviewed-by: Simon Horman <horms@kernel.org>
>Signed-off-by: Bobby Eshleman <bobbyeshleman@meta.com>
>---
>Previously was part of the series:
>https://lore.kernel.org/all/20251022-vsock-selftests-fixes-and-improvements-v1-0-edeb179d6463@meta.com/
>---
> tools/testing/selftests/vsock/vmtest.sh | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/tools/testing/selftests/vsock/vmtest.sh b/tools/testing/selftests/vsock/vmtest.sh
>index edacebfc1632..e1732f236d14 100755
>--- a/tools/testing/selftests/vsock/vmtest.sh
>+++ b/tools/testing/selftests/vsock/vmtest.sh
>@@ -389,9 +389,9 @@ run_test() {
> local rc
>
> host_oops_cnt_before=$(dmesg | grep -c -i 'Oops')
>- host_warn_cnt_before=$(dmesg --level=warn | wc -l)
>+ host_warn_cnt_before=$(dmesg --level=warn | grep -c -i 'vsock')
> vm_oops_cnt_before=$(vm_ssh -- dmesg | grep -c -i 'Oops')
>- vm_warn_cnt_before=$(vm_ssh -- dmesg --level=warn | wc -l)
>+ vm_warn_cnt_before=$(vm_ssh -- dmesg --level=warn | grep -c -i 'vsock')
>
> name=$(echo "${1}" | awk '{ print $1 }')
> eval test_"${name}"
>@@ -403,7 +403,7 @@ run_test() {
> rc=$KSFT_FAIL
> fi
>
>- host_warn_cnt_after=$(dmesg --level=warn | wc -l)
>+ host_warn_cnt_after=$(dmesg --level=warn | grep -c -i vsock)
In the previous hunk we quoted 'vsock', but here and in the next we did
not. Can we be consistent at least in the same patch ?
The rest LGTM.
Stefano
> if [[ ${host_warn_cnt_after} -gt ${host_warn_cnt_before} ]]; then
> echo "FAIL: kernel warning detected on host" | log_host "${name}"
> rc=$KSFT_FAIL
>@@ -415,7 +415,7 @@ run_test() {
> rc=$KSFT_FAIL
> fi
>
>- vm_warn_cnt_after=$(vm_ssh -- dmesg --level=warn | wc -l)
>+ vm_warn_cnt_after=$(vm_ssh -- dmesg --level=warn | grep -c -i vsock)
> if [[ ${vm_warn_cnt_after} -gt ${vm_warn_cnt_before} ]]; then
> echo "FAIL: kernel warning detected on vm" | log_host "${name}"
> rc=$KSFT_FAIL
>
>---
>base-commit: 255d75ef029f33f75fcf5015052b7302486f7ad2
>change-id: 20251104-vsock-vmtest-dmesg-fix-b2c59e1d9c38
>
>Best regards,
>--
>Bobby Eshleman <bobbyeshleman@meta.com>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] selftests/vsock: avoid false-positives when checking dmesg
2025-11-05 11:16 ` Stefano Garzarella
@ 2025-11-05 16:11 ` Bobby Eshleman
0 siblings, 0 replies; 3+ messages in thread
From: Bobby Eshleman @ 2025-11-05 16:11 UTC (permalink / raw)
To: Stefano Garzarella
Cc: Shuah Khan, Jakub Kicinski, virtualization, netdev,
linux-kselftest, linux-kernel, Bobby Eshleman, Simon Horman
On Wed, Nov 05, 2025 at 12:16:42PM +0100, Stefano Garzarella wrote:
> On Tue, Nov 04, 2025 at 01:50:50PM -0800, Bobby Eshleman wrote:
> > From: Bobby Eshleman <bobbyeshleman@meta.com>
> >
> > Sometimes VMs will have some intermittent dmesg warnings that are
> > unrelated to vsock. Change the dmesg parsing to filter on strings
> > containing 'vsock' to avoid false positive failures that are unrelated
> > to vsock. The downside is that it is possible for some vsock related
> > warnings to not contain the substring 'vsock', so those will be missed.
> >
> > Fixes: a4a65c6fe08b ("selftests/vsock: add initial vmtest.sh for vsock")
> > Reviewed-by: Simon Horman <horms@kernel.org>
> > Signed-off-by: Bobby Eshleman <bobbyeshleman@meta.com>
> > ---
> > Previously was part of the series:
> > https://lore.kernel.org/all/20251022-vsock-selftests-fixes-and-improvements-v1-0-edeb179d6463@meta.com/
> > ---
> > tools/testing/selftests/vsock/vmtest.sh | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/tools/testing/selftests/vsock/vmtest.sh b/tools/testing/selftests/vsock/vmtest.sh
> > index edacebfc1632..e1732f236d14 100755
> > --- a/tools/testing/selftests/vsock/vmtest.sh
> > +++ b/tools/testing/selftests/vsock/vmtest.sh
> > @@ -389,9 +389,9 @@ run_test() {
> > local rc
> >
> > host_oops_cnt_before=$(dmesg | grep -c -i 'Oops')
> > - host_warn_cnt_before=$(dmesg --level=warn | wc -l)
> > + host_warn_cnt_before=$(dmesg --level=warn | grep -c -i 'vsock')
> > vm_oops_cnt_before=$(vm_ssh -- dmesg | grep -c -i 'Oops')
> > - vm_warn_cnt_before=$(vm_ssh -- dmesg --level=warn | wc -l)
> > + vm_warn_cnt_before=$(vm_ssh -- dmesg --level=warn | grep -c -i 'vsock')
> >
> > name=$(echo "${1}" | awk '{ print $1 }')
> > eval test_"${name}"
> > @@ -403,7 +403,7 @@ run_test() {
> > rc=$KSFT_FAIL
> > fi
> >
> > - host_warn_cnt_after=$(dmesg --level=warn | wc -l)
> > + host_warn_cnt_after=$(dmesg --level=warn | grep -c -i vsock)
>
> In the previous hunk we quoted 'vsock', but here and in the next we did
> not. Can we be consistent at least in the same patch ?
>
> The rest LGTM.
>
> Stefano
Just sent the update, sorry for the oversight.
Best,
Bobby
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-11-05 16:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-04 21:50 [PATCH net] selftests/vsock: avoid false-positives when checking dmesg Bobby Eshleman
2025-11-05 11:16 ` Stefano Garzarella
2025-11-05 16:11 ` Bobby Eshleman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).