public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Hangbin Liu <liuhangbin@gmail.com>
To: Sabrina Dubroca <sd@queasysnail.net>
Cc: netdev@vger.kernel.org, "Donald Hunter" <donald.hunter@gmail.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Simon Horman" <horms@kernel.org>,
	"Jan Stancek" <jstancek@redhat.com>,
	"Matthieu Baerts (NGI0)" <matttbe@kernel.org>,
	"Asbjørn Sloth Tønnesen" <ast@fiberby.net>,
	"Stanislav Fomichev" <sdf@fomichev.me>,
	"Ido Schimmel" <idosch@nvidia.com>,
	"Guillaume Nault" <gnault@redhat.com>,
	"Petr Machata" <petrm@nvidia.com>
Subject: Re: [PATCHv2 net-next 3/3] tools: ynl: add YNL test framework
Date: Thu, 6 Nov 2025 01:39:14 +0000	[thread overview]
Message-ID: <aQv8Qgv1G9DDk9Th@fedora> (raw)
In-Reply-To: <aQuClqhaV-GiBxFZ@krikkit>

On Wed, Nov 05, 2025 at 06:00:06PM +0100, Sabrina Dubroca wrote:
> 2025-11-05, 08:28:41 +0000, Hangbin Liu wrote:
> > +setup() {
> > +	if ! modprobe netdevsim &>/dev/null; then
> > +		echo "SKIP: all YNL CLI tests (netdevsim module not available)"
> 
> Can we maybe find a way to try to load the module and still run the
> test if modprobe fails but netdevsim is built-in? I usually do my
> testing in VMs with kernels where everything I need is built in, so I
> don't do "make modules_install" and "modprobe netdevsim" fails even if
> netdevsim is actually available (because it's built in).
> 
> For some modules it may be difficult, for netdevsim we could just run
> modprobe (but ignore its return value) and check if
> /sys/bus/netdevsim/new_device exists to decide if we need to skip the
> tests?

Yes, could be.
> 
> 
> Or do we only expect selftests/those new tests to run with the
> standard net selftests config, and not with custom configs that also
> provide all the required features?

I do not have a preference. I added a config file to the test folder. However,
this config file is just for reference.

Thanks
Hangbin

  reply	other threads:[~2025-11-06  1:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-05  8:28 [PATCHv2 net-next 0/3] Add YNL test framework and library improvements Hangbin Liu
2025-11-05  8:28 ` [PATCHv2 net-next 1/3] tools: ynl: Add MAC address parsing support Hangbin Liu
2025-11-05  8:28 ` [PATCHv2 net-next 2/3] netlink: specs: update rt-rule src/dst attribute types to support IPv4 addresses Hangbin Liu
2025-11-05  8:28 ` [PATCHv2 net-next 3/3] tools: ynl: add YNL test framework Hangbin Liu
2025-11-05 17:00   ` Sabrina Dubroca
2025-11-06  1:39     ` Hangbin Liu [this message]
2025-11-06  2:33   ` Jakub Kicinski
2025-11-06  2:40     ` Hangbin Liu
2025-11-06 14:45       ` Jakub Kicinski
2025-11-10  3:14         ` Hangbin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aQv8Qgv1G9DDk9Th@fedora \
    --to=liuhangbin@gmail.com \
    --cc=ast@fiberby.net \
    --cc=davem@davemloft.net \
    --cc=donald.hunter@gmail.com \
    --cc=edumazet@google.com \
    --cc=gnault@redhat.com \
    --cc=horms@kernel.org \
    --cc=idosch@nvidia.com \
    --cc=jstancek@redhat.com \
    --cc=kuba@kernel.org \
    --cc=matttbe@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=petrm@nvidia.com \
    --cc=sd@queasysnail.net \
    --cc=sdf@fomichev.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox