Re: [PATCH net-next 2/3] netlink: specs: update rt-rule src/dst attribute types to support IPv4 addresses

[Hangbin Liu <liuhangbin@gmail.com>]

On Wed, Nov 05, 2025 at 04:13:19PM -0800, Jakub Kicinski wrote:
> On Wed, 5 Nov 2025 07:55:47 +0000 Hangbin Liu wrote:
> > > > I just realize that most of the address/src/dst in rt-addr/route are
> > > > dual stack. The same with FRA_DST. We can't simply change binary to u32.
> > > > So can we keep this u32 -> binary change?  
> > > 
> > > Ah, should have looked at more context..
> > > Yes, and in that case without the display-hint?  
> > 
> > The display-hint is required; otherwise, the displayed src and dst fields
> > appear as binary data, and setting the rule’s src/dst values also fails. I
> > haven’t checked the code yet, but with
> >   - display-hint: ipv4
> > the IPv6 addresses are also displayed correctly :)
> 
> Heh, we should have called the hint "ip" in that case :)

I saw the display hit supports "ipv4-or-v6", but genetlink-c.yaml doesn't
have "ipv4-or-v6". Do you know why?

# grep -rn fddi Documentation/netlink
Documentation/netlink/genetlink.yaml:188:                enum: [ hex, mac, fddi, ipv4, ipv6, uuid ]
Documentation/netlink/genetlink-legacy.yaml:157:                enum: [ hex, mac, fddi, ipv4, ipv6, ipv4-or-v6, uuid ]
Documentation/netlink/netlink-raw.yaml:160:                enum: [ hex, mac, fddi, ipv4, ipv6, uuid ]
Documentation/netlink/genetlink-c.yaml:230:                enum: [ hex, mac, fddi, ipv4, ipv6, uuid ]

Thanks
Hangbin