[PATCH v2 resend] net: stmmac: add support for dwmac 5.20

[PATCH v2 resend] net: stmmac: add support for dwmac 5.20

[Jisheng Zhang]

The dwmac 5.20 IP can be found on some synaptics SoCs. 

The binding doc has been already upstreamed by
commit 13f9351180aa ("dt-bindings: net: snps,dwmac: Add dwmac-5.20
version")

So we just need to add a compatibility flag in dwmac generic driver.

Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
---
Since v1:
 - fix the commit msg

 drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c
index b9218c07eb6b..cecce6ed9aa6 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c
@@ -59,6 +59,7 @@ static const struct of_device_id dwmac_generic_match[] = {
 	{ .compatible = "snps,dwmac-3.72a"},
 	{ .compatible = "snps,dwmac-4.00"},
 	{ .compatible = "snps,dwmac-4.10a"},
+	{ .compatible = "snps,dwmac-5.20"},
 	{ .compatible = "snps,dwmac"},
 	{ .compatible = "snps,dwxgmac-2.10"},
 	{ .compatible = "snps,dwxgmac"},
-- 
2.51.0

Re: [PATCH v2 resend] net: stmmac: add support for dwmac 5.20

[Russell King (Oracle)]

On Wed, Nov 19, 2025 at 11:35:26PM +0800, Jisheng Zhang wrote:
> The dwmac 5.20 IP can be found on some synaptics SoCs. 
> 
> The binding doc has been already upstreamed by
> commit 13f9351180aa ("dt-bindings: net: snps,dwmac: Add dwmac-5.20
> version")
> 
> So we just need to add a compatibility flag in dwmac generic driver.

Do we _need_ to add it to the generic driver? Do the platforms that are
using this really not need any additional code to support them?

Looking at all the DT that mention dwmac-5.20 in their compatible
strings, that is always after other compatibles that point to other
platform specific drivers.

So, can you point to a platform that doesn't have its own platform
glue, and would be functional when using the dwmac-generic driver?

For reference, the dts that refer to dwmac-5.20 are:

arch/arm64/boot/dts/renesas/r9a09g047.dtsi
arch/arm64/boot/dts/renesas/r9a09g056.dtsi
arch/arm64/boot/dts/renesas/r9a09g057.dtsi
arch/arm64/boot/dts/st/stm32mp251.dtsi
arch/arm64/boot/dts/st/stm32mp253.dtsi
arch/arm64/boot/dts/st/stm32mp233.dtsi
arch/arm64/boot/dts/st/stm32mp231.dtsi
arch/riscv/boot/dts/starfive/jh7110.dtsi

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

Re: [PATCH v2 resend] net: stmmac: add support for dwmac 5.20

[Jisheng Zhang]

On Wed, Nov 19, 2025 at 04:13:17PM +0000, Russell King (Oracle) wrote:
> On Wed, Nov 19, 2025 at 11:35:26PM +0800, Jisheng Zhang wrote:
> > The dwmac 5.20 IP can be found on some synaptics SoCs. 
> > 
> > The binding doc has been already upstreamed by
> > commit 13f9351180aa ("dt-bindings: net: snps,dwmac: Add dwmac-5.20
> > version")
> > 
> > So we just need to add a compatibility flag in dwmac generic driver.
> 
> Do we _need_ to add it to the generic driver? Do the platforms that are
> using this really not need any additional code to support them?
> 
> Looking at all the DT that mention dwmac-5.20 in their compatible
> strings, that is always after other compatibles that point to other
> platform specific drivers.
> 
> So, can you point to a platform that doesn't have its own platform
> glue, and would be functional when using the dwmac-generic driver?

Synatpics platforms use the dwmac-generic driver, it's enough now.
But we haven't upstreamed related platforms, but will do soon.
> 
> For reference, the dts that refer to dwmac-5.20 are:
> 
> arch/arm64/boot/dts/renesas/r9a09g047.dtsi
> arch/arm64/boot/dts/renesas/r9a09g056.dtsi
> arch/arm64/boot/dts/renesas/r9a09g057.dtsi
> arch/arm64/boot/dts/st/stm32mp251.dtsi
> arch/arm64/boot/dts/st/stm32mp253.dtsi
> arch/arm64/boot/dts/st/stm32mp233.dtsi
> arch/arm64/boot/dts/st/stm32mp231.dtsi
> arch/riscv/boot/dts/starfive/jh7110.dtsi
> 
> Thanks.
> 
> -- 
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

Re: [PATCH v2 resend] net: stmmac: add support for dwmac 5.20

[Andrew Lunn]

On Thu, Nov 20, 2025 at 12:01:36AM +0800, Jisheng Zhang wrote:
> On Wed, Nov 19, 2025 at 04:13:17PM +0000, Russell King (Oracle) wrote:
> > On Wed, Nov 19, 2025 at 11:35:26PM +0800, Jisheng Zhang wrote:
> > > The dwmac 5.20 IP can be found on some synaptics SoCs. 
> > > 
> > > The binding doc has been already upstreamed by
> > > commit 13f9351180aa ("dt-bindings: net: snps,dwmac: Add dwmac-5.20
> > > version")
> > > 
> > > So we just need to add a compatibility flag in dwmac generic driver.
> > 
> > Do we _need_ to add it to the generic driver? Do the platforms that are
> > using this really not need any additional code to support them?
> > 
> > Looking at all the DT that mention dwmac-5.20 in their compatible
> > strings, that is always after other compatibles that point to other
> > platform specific drivers.
> > 
> > So, can you point to a platform that doesn't have its own platform
> > glue, and would be functional when using the dwmac-generic driver?
> 
> Synatpics platforms use the dwmac-generic driver, it's enough now.
> But we haven't upstreamed related platforms, but will do soon.

Please make this patch part of the patchset when you upstream the
platforms. We prefer to only add things which have users.

    Andrew

---
pw-bot: cr