From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C72153A1CE5 for ; Thu, 20 Nov 2025 15:31:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763652676; cv=none; b=JZA1RouquVOxrRU3O0aIQES2wcsb5B2khjVaRjeenGyAAs5jPHkFOwaElB8Vctt+yfB0WYbyvLw+DjYE3Jluc7Vv0yVa6oPiTwbgVzpuApdnoJEwIPh7R2ve+z2T7AkvQcsSOnARGFo9uGeVGR8bT4e/Bq9eRt4m6PH4GRDz73g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763652676; c=relaxed/simple; bh=wMnT47phEFuGfAdPalYZmpWGC6ln9kV4Q339Ib+0xuE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YgdN0bbmMHuML/B3HayGYnLLccy89Hn4SOJm4S7MCenIvRa4EUA8pT07iavWSUHy2+JO3XYypR1XbhMAehemu1WqpZckLnmvAVxY9SPMybRD883R6F3DTImswg2XA+/Pu1ZvwdL/WgptiDlCdzRJEkmU9dpp/gbHn+0d2m28AGk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lbzlHOj7; arc=none smtp.client-ip=209.85.128.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lbzlHOj7" Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-787e7aa1631so26496417b3.1 for ; Thu, 20 Nov 2025 07:31:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763652673; x=1764257473; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PFiT8mQz2EeFfhAtckqnTM9BcNHX0xiz9tE4/FBhkTE=; b=lbzlHOj7nNZO01ylI7WXU8F4o0tSysm4a2eWQsStUmqXbtFdoDctgJ9r196y/ZMHFF CNCzckt38jO/1VY/nyuIvSSHn8iBArZd04LYVFofPSKZs1UrMIjgTSxZeU6nWwuqillY wKbMquXENiQGkkXgKReO54LN5792IV1wxdaQZJV54+XqH8fEWqIcDw3XhyuPOK0KQ2WU /nw3G188kAh61IeWc2FZ3Amig8SovI+FzqoQ56g8wSSD3owR+M9smjMLKHGkxG1d06ze ftfV9xm1sZNsVIg/uUqmSJK9h6W2eSZ1gi7FBtIbjUhhMnvNkPSq6zX96irGDd2CE0jt jRPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763652673; x=1764257473; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PFiT8mQz2EeFfhAtckqnTM9BcNHX0xiz9tE4/FBhkTE=; b=oBY3mSD45vj1LO3dGnpP76nUPWTI8lm3mt6gBM4BQIq/x4HmgW6yrAnzGETC4x4RYg Ncas0WYp7BA7lzyQZrF8BKqosZVr7TzZE9sARN8ClBmgnsQUgRYMoqLySTVMbFK3UdWl +ESVA3jA5WTyRMd0xxT/bMTvFgFPgM4JMJpPUv5MYD7Xb1lm+PdlIrZOQgz+IZWnlPVZ s5+zLT2pGhKegTqG+8DxUmwSgX5QJpOF+CppYVfhjisVF+HvyPspoGoJ40bBBsVGWIP4 UK4DV5VidAsoodxkzXxwgocwNSfX8VB45sOR7giGJrjYk9gvwXhuTmG2xWkLUDRRds3p qKew== X-Forwarded-Encrypted: i=1; AJvYcCXDURd8fIZ+Z+dzcEdGB4pXce7WfnGSo7b7h/whJAOkIHLcrWSquOKBa1ANGd6Z68TTfKTNZAs=@vger.kernel.org X-Gm-Message-State: AOJu0YzxJ+Z+mwU6khS3cXk7pGX1eoIr97Ah6KCXjsrzf1OXozBErgyK cREZedI0BfjpmDZhOJEH2G7MsMONvDxs9NW9gROaKeA3jcLj2AePWVJ4 X-Gm-Gg: ASbGncua6QnUIB1V64r8dWhJAbnvgGmNgd/F/e27GOyATKg+dho5v7LjAIXby6ClV8R SaTkYO0Z2G7HFbW0tjKLideM6g0AMYq6UHjsr63k2q5BqwBuKVGmOc3ucyjiSf5BLGBekZcyNxG WS2EeTQ3dCdV8WN0+1sjUebaG3Q0WQiNiFUPyhRT5+96MuX5u/GOwhM95/F/KuE8bhHY3IC99F2 qK7RPsdmcc9pK+nN9V1or/zHlTFNllAhM/Me3U8yW15IJu5eOIt2pl50pNrVrP7TilfugQE72gt HDiJZ5J9TMWCi6IgBTs/E5EXe4ieREcVIsoc6daFds3GHcHqdqnB8XrKZDQhHTcIUwsWpu/GfjB ZIk0TKE/6h8QmU0BDPvLs07E6Clh78zGRstbZJ7IXxlJ9psC4bs1p3RXlK8bht/pQbI/AFPYb4P FrvqZpGzLFrXCy+2oKa+dHEys9UifMGiqYCRHwraxoLInipvQ= X-Google-Smtp-Source: AGHT+IGnxsv7O9k5uQ7ryneqkrnqq+cPJZPkqCvcNCDp+BprL3ACVr9C8SpKEUSItTS/dKmykTVJvA== X-Received: by 2002:a05:690e:12cc:b0:63f:b4b4:7758 with SMTP id 956f58d0204a3-642f8df4854mr2073800d50.11.1763652672604; Thu, 20 Nov 2025 07:31:12 -0800 (PST) Received: from devvm11784.nha0.facebook.com ([2a03:2880:25ff:45::]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-642f71787f3sm871532d50.16.2025.11.20.07.31.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Nov 2025 07:31:12 -0800 (PST) Date: Thu, 20 Nov 2025 07:31:10 -0800 From: Bobby Eshleman To: Paolo Abeni Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Simon Horman , Kuniyuki Iwashima , Willem de Bruijn , Neal Cardwell , David Ahern , Arnd Bergmann , Jonathan Corbet , Andrew Lunn , Shuah Khan , Donald Hunter , Mina Almasry , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, Stanislav Fomichev , Bobby Eshleman Subject: Re: [PATCH net-next v7 3/5] net: devmem: implement autorelease token management Message-ID: References: <20251119-scratch-bobbyeshleman-devmem-tcp-token-upstream-v7-0-1abc8467354c@meta.com> <20251119-scratch-bobbyeshleman-devmem-tcp-token-upstream-v7-3-1abc8467354c@meta.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Nov 20, 2025 at 01:19:54PM +0100, Paolo Abeni wrote: > On 11/20/25 4:37 AM, Bobby Eshleman wrote: > > @@ -2479,10 +2504,12 @@ static int tcp_recvmsg_dmabuf(struct sock *sk, const struct sk_buff *skb, > > unsigned int offset, struct msghdr *msg, > > int remaining_len) > > { > > + struct net_devmem_dmabuf_binding *binding = NULL; > > struct dmabuf_cmsg dmabuf_cmsg = { 0 }; > > struct tcp_xa_pool tcp_xa_pool; > > unsigned int start; > > int i, copy, n; > > + int refs = 0; > > int sent = 0; > > int err = 0; > > > > @@ -2536,6 +2563,7 @@ static int tcp_recvmsg_dmabuf(struct sock *sk, const struct sk_buff *skb, > > skb_frag_t *frag = &skb_shinfo(skb)->frags[i]; > > struct net_iov *niov; > > u64 frag_offset; > > + u32 token; > > int end; > > > > /* !skb_frags_readable() should indicate that ALL the > > @@ -2568,13 +2596,32 @@ static int tcp_recvmsg_dmabuf(struct sock *sk, const struct sk_buff *skb, > > start; > > dmabuf_cmsg.frag_offset = frag_offset; > > dmabuf_cmsg.frag_size = copy; > > - err = tcp_xa_pool_refill(sk, &tcp_xa_pool, > > - skb_shinfo(skb)->nr_frags - i); > > - if (err) > > + > > + binding = net_devmem_iov_binding(niov); > > + > > + if (!sk->sk_devmem_info.binding) > > + sk->sk_devmem_info.binding = binding; > > + > > + if (sk->sk_devmem_info.binding != binding) { > > + err = -EFAULT; > > goto out; > > + } > > + > > + if (static_branch_unlikely(&tcp_devmem_ar_key)) { > > Not a real/full review but the above is apparently causing kunit build > failures: > > ERROR:root:ld: vmlinux.o: in function `tcp_recvmsg_dmabuf': > tcp.c:(.text+0x669b21): undefined reference to `tcp_devmem_ar_key' > ld: tcp.c:(.text+0x669b68): undefined reference to `tcp_devmem_ar_key' > ld: tcp.c:(.text+0x669c54): undefined reference to `tcp_devmem_ar_key' > make[3]: *** [../scripts/Makefile.vmlinux:72: vmlinux.unstripped] Error 1 > make[2]: *** [/home/kunit/testing/Makefile:1242: vmlinux] Error 2 > make[1]: *** [/home/kunit/testing/Makefile:248: __sub-make] Error 2 > make: *** [Makefile:248: __sub-make] Error 2 > > see: > > https://netdev-3.bots.linux.dev/kunit/results/393664/ Thanks Paolo, I'll fix that for the next rev. And I'll have to add building kunit into my flow (currently using some custom stuff and nipa ingest_mdir, but don't think either has kunit). > > > @@ -2617,6 +2664,7 @@ static int tcp_recvmsg_dmabuf(struct sock *sk, > > const struct sk_buff *skb, > > > > out: tcp_xa_pool_commit(sk, &tcp_xa_pool); + > > [just because I stumbled upon the above while looking for the build > issue]: please do not mix unrelated whitespace-change only with > functional change. Don't know how I missed that line, will definitely remove. Thanks again, Bobby