From: Cong Wang <xiyou.wangcong@gmail.com>
To: Victor Nogueira <victor@mojatatu.com>
Cc: jhs@mojatatu.com, jiri@resnulli.us, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
horms@kernel.org, netdev@vger.kernel.org, wangliang74@huawei.com,
pctammela@mojatatu.ai
Subject: Re: [PATCH net 1/2] net/sched: Abort __tc_modify_qdisc if parent is a clsact/ingress qdisc
Date: Mon, 10 Nov 2025 14:45:59 -0800 [thread overview]
Message-ID: <aRJrJyjyif/axyxf@pop-os.localdomain> (raw)
In-Reply-To: <20251106205621.3307639-1-victor@mojatatu.com>
On Thu, Nov 06, 2025 at 05:56:20PM -0300, Victor Nogueira wrote:
> Wang reported an illegal configuration [1] where the user attempts to add a
> child qdisc to the ingress qdisc as follows:
>
> tc qdisc add dev eth0 handle ffff:0 ingress
> tc qdisc add dev eth0 handle ffe0:0 parent ffff:a fq
>
> To solve this, we reject any configuration attempt to add a child qdisc to
> ingress or clsact.
>
> [1] https://lore.kernel.org/netdev/20251105022213.1981982-1-wangliang74@huawei.com/
>
> Fixes: 5e50da01d0ce ("[NET_SCHED]: Fix endless loops (part 2): "simple" qdiscs")
> Reported-by: Wang Liang <wangliang74@huawei.com>
> Closes: https://lore.kernel.org/netdev/20251105022213.1981982-1-wangliang74@huawei.com/
> Reviewed-by: Pedro Tammela <pctammela@mojatatu.ai>
> Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
> Signed-off-by: Victor Nogueira <victor@mojatatu.com>
Reviewed-by: Cong Wang <cwang@multikernel.io>
Thanks!
next prev parent reply other threads:[~2025-11-10 22:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 20:56 [PATCH net 1/2] net/sched: Abort __tc_modify_qdisc if parent is a clsact/ingress qdisc Victor Nogueira
2025-11-06 20:56 ` [PATCH net 2/2] selftests/tc-testing: Create tests trying to add children to clsact/ingress qdiscs Victor Nogueira
2025-11-10 22:48 ` Cong Wang
2025-11-10 22:45 ` Cong Wang [this message]
2025-11-11 1:20 ` [PATCH net 1/2] net/sched: Abort __tc_modify_qdisc if parent is a clsact/ingress qdisc patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRJrJyjyif/axyxf@pop-os.localdomain \
--to=xiyou.wangcong@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pctammela@mojatatu.ai \
--cc=victor@mojatatu.com \
--cc=wangliang74@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox