From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Yao Zi <ziyao@disroot.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Frank <Frank.Sae@motor-comm.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Choong Yong Liang <yong.liang.choong@linux.intel.com>,
Chen-Yu Tsai <wens@csie.org>, Jisheng Zhang <jszhang@kernel.org>,
Furong Xu <0x1207@gmail.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Mingcong Bai <jeffbai@aosc.io>, Runhua He <hua@aosc.io>,
Xi Ruoyao <xry111@xry111.site>
Subject: Re: [PATCH net-next v2 2/3] net: stmmac: Add glue driver for Motorcomm YT6801 ethernet controller
Date: Tue, 11 Nov 2025 11:07:24 +0000 [thread overview]
Message-ID: <aRMY7GyocIJkgzZ2@shell.armlinux.org.uk> (raw)
In-Reply-To: <20251111105252.53487-3-ziyao@disroot.org>
On Tue, Nov 11, 2025 at 10:52:51AM +0000, Yao Zi wrote:
> + plat->bus_id = pci_dev_id(pdev);
> + plat->phy_addr = -1;
> + plat->phy_interface = PHY_INTERFACE_MODE_GMII;
> + plat->clk_csr = STMMAC_CSR_20_35M;
> + plat->tx_coe = 1;
> + plat->rx_coe = 1;
> + plat->maxmtu = JUMBO_LEN;
> + plat->rx_queues_to_use = 1;
> + plat->tx_queues_to_use = 1;
> + plat->clk_ref_rate = 125000000;
> + plat->core_type = DWMAC_CORE_GMAC4;
> + plat->suspend = stmmac_pci_plat_suspend;
> + plat->resume = motorcomm_resume;
> + plat->flags = STMMAC_FLAG_TSO_EN;
Can you also set STMMAC_FLAG_EN_TX_LPI_CLK_PHY_CAP here, so if EEE
is used, we can shut down the transmit clock to the PHY if the PHY
supports that? I would like all new glue drivers to set this where
possible please.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-11-11 11:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 10:52 [PATCH net-next v2 0/3] Add DWMAC glue driver for Motorcomm YT6801 Yao Zi
2025-11-11 10:52 ` [PATCH net-next v2 1/3] net: phy: motorcomm: Support YT8531S PHY in YT6801 Ethernet controller Yao Zi
2025-11-11 10:52 ` [PATCH net-next v2 2/3] net: stmmac: Add glue driver for Motorcomm YT6801 ethernet controller Yao Zi
2025-11-11 11:07 ` Russell King (Oracle) [this message]
2025-11-15 11:27 ` Yao Zi
2025-11-11 12:32 ` Russell King (Oracle)
2025-11-15 11:46 ` Yao Zi
2025-11-16 6:50 ` Xi Ruoyao
2025-11-18 3:17 ` Yao Zi
2025-11-11 10:52 ` [PATCH net-next v2 3/3] MAINTAINERS: Assign myself as maintainer of Motorcomm DWMAC glue driver Yao Zi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRMY7GyocIJkgzZ2@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=0x1207@gmail.com \
--cc=Frank.Sae@motor-comm.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=hua@aosc.io \
--cc=jeffbai@aosc.io \
--cc=jszhang@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
--cc=wens@csie.org \
--cc=xry111@xry111.site \
--cc=yong.liang.choong@linux.intel.com \
--cc=ziyao@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).