[PATCH net-next 0/2] net: phy: disable EEE on TI PHYs

[PATCH net-next 0/2] net: phy: disable EEE on TI PHYs

[Russell King (Oracle)]

Hi,

Towards the end of October, we discussed EEE on TI PHYs which seems to
cause problems with the stmmac hardware. This problem was never fully
diagnosed, but it was identified that TI PHYs do not support LPI
signalling, but report that EEE is supported, and they implement the
advertisement registers and that functionality.

This series allows PHY drivers to disable EEE support.

 drivers/net/phy/dp83822.c    |  3 +++
 drivers/net/phy/dp83867.c    |  1 +
 drivers/net/phy/dp83869.c    |  1 +
 drivers/net/phy/dp83tc811.c  |  1 +
 drivers/net/phy/phy-core.c   |  2 --
 drivers/net/phy/phy_device.c | 34 ++++++++++++++++++++++++++++++----
 include/linux/phy.h          |  1 +
 7 files changed, 37 insertions(+), 6 deletions(-)

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

[PATCH net-next 1/2] net: phy: allow drivers to disable EEE support via .get_features()

[Russell King (Oracle)]

Allow PHY drivers to hook the .get_features() method to disable EEE
support. This is useful for TI PHYs, where we have a statement that
none of their gigabit products support EEE, yet at least DP83867
reports EEE capabilties and implements EEE negotiation.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
 drivers/net/phy/phy-core.c   |  2 --
 drivers/net/phy/phy_device.c | 34 ++++++++++++++++++++++++++++++----
 include/linux/phy.h          |  1 +
 3 files changed, 31 insertions(+), 6 deletions(-)

diff --git a/drivers/net/phy/phy-core.c b/drivers/net/phy/phy-core.c
index 605ca20ae192..43ccbd3a09f8 100644
--- a/drivers/net/phy/phy-core.c
+++ b/drivers/net/phy/phy-core.c
@@ -207,8 +207,6 @@ void of_set_phy_eee_broken(struct phy_device *phydev)
 	if (!IS_ENABLED(CONFIG_OF_MDIO) || !node)
 		return;
 
-	linkmode_zero(modes);
-
 	if (of_property_read_bool(node, "eee-broken-100tx"))
 		linkmode_set_bit(ETHTOOL_LINK_MODE_100baseT_Full_BIT, modes);
 	if (of_property_read_bool(node, "eee-broken-1000t"))
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index 81984d4ebb7c..437b89a0e944 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -3397,6 +3397,34 @@ struct fwnode_handle *fwnode_get_phy_node(const struct fwnode_handle *fwnode)
 }
 EXPORT_SYMBOL_GPL(fwnode_get_phy_node);
 
+static int phy_get_features(struct phy_device *phydev)
+{
+	int err;
+
+	if (phydev->is_c45)
+		err = genphy_c45_pma_read_abilities(phydev);
+	else
+		err = genphy_read_abilities(phydev);
+
+	return err;
+}
+
+/**
+ * phy_get_Features_no_eee - read the PHY features, disabling all EEE
+ * @phydev: phy_device structure to be added to the MDIO bus
+ *
+ * Read the PHY features, and fill the @phydev->eee_disabled_modes to
+ * prevent EEE being used. This is intended to be used for PHY .get_feature
+ * methods where a PHY reports incorrect capabilities.
+ */
+int phy_get_features_no_eee(struct phy_device *phydev)
+{
+	linkmode_fill(phydev->eee_disabled_modes);
+
+	return phy_get_features(phydev);
+}
+EXPORT_SYMBOL_GPL(phy_get_features_no_eee);
+
 /**
  * phy_probe - probe and init a PHY device
  * @dev: device to probe and init
@@ -3442,10 +3470,8 @@ static int phy_probe(struct device *dev)
 	}
 	else if (phydrv->get_features)
 		err = phydrv->get_features(phydev);
-	else if (phydev->is_c45)
-		err = genphy_c45_pma_read_abilities(phydev);
-	else
-		err = genphy_read_abilities(phydev);
+	else 
+		err = phy_get_features(phydev);
 
 	if (err)
 		goto out;
diff --git a/include/linux/phy.h b/include/linux/phy.h
index bf5457341ca8..2655c0ae6488 100644
--- a/include/linux/phy.h
+++ b/include/linux/phy.h
@@ -2299,6 +2299,7 @@ void phy_support_sym_pause(struct phy_device *phydev);
 void phy_support_asym_pause(struct phy_device *phydev);
 void phy_support_eee(struct phy_device *phydev);
 void phy_disable_eee(struct phy_device *phydev);
+int phy_get_features_no_eee(struct phy_device *phydev);
 void phy_set_sym_pause(struct phy_device *phydev, bool rx, bool tx,
 		       bool autoneg);
 void phy_set_asym_pause(struct phy_device *phydev, bool rx, bool tx);
-- 
2.47.3

[PATCH net-next 2/2] net: phy: TI PHYs use phy_get_features_no_eee()

[Russell King (Oracle)]

As TI Gigabit PHYs do not support EEE, use the newly introduced
phy_get_features_no_eee() to read the features but mark EEE as
disabled.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
 drivers/net/phy/dp83822.c   | 3 +++
 drivers/net/phy/dp83867.c   | 1 +
 drivers/net/phy/dp83869.c   | 1 +
 drivers/net/phy/dp83tc811.c | 1 +
 4 files changed, 6 insertions(+)

diff --git a/drivers/net/phy/dp83822.c b/drivers/net/phy/dp83822.c
index 33db21251f2e..20caf9a5faa7 100644
--- a/drivers/net/phy/dp83822.c
+++ b/drivers/net/phy/dp83822.c
@@ -1160,6 +1160,7 @@ static int dp83822_led_hw_control_get(struct phy_device *phydev, u8 index,
 		.name		= (_name),			\
 		/* PHY_BASIC_FEATURES */			\
 		.probe          = dp83822_probe,		\
+		.get_features	= phy_get_features_no_eee,	\
 		.soft_reset	= dp83822_phy_reset,		\
 		.config_init	= dp83822_config_init,		\
 		.read_status	= dp83822_read_status,		\
@@ -1180,6 +1181,7 @@ static int dp83822_led_hw_control_get(struct phy_device *phydev, u8 index,
 		.name		= (_name),			\
 		/* PHY_BASIC_FEATURES */			\
 		.probe          = dp8382x_probe,		\
+		.get_features	= phy_get_features_no_eee,	\
 		.soft_reset	= dp83822_phy_reset,		\
 		.config_init	= dp83825_config_init,		\
 		.get_wol = dp83822_get_wol,			\
@@ -1196,6 +1198,7 @@ static int dp83822_led_hw_control_get(struct phy_device *phydev, u8 index,
 		.name		= (_name),			\
 		/* PHY_BASIC_FEATURES */			\
 		.probe          = dp83826_probe,		\
+		.get_features	= phy_get_features_no_eee,	\
 		.soft_reset	= dp83822_phy_reset,		\
 		.config_init	= dp83826_config_init,		\
 		.get_wol = dp83822_get_wol,			\
diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c
index 36a0c1b7f59c..da055ff861be 100644
--- a/drivers/net/phy/dp83867.c
+++ b/drivers/net/phy/dp83867.c
@@ -1124,6 +1124,7 @@ static struct phy_driver dp83867_driver[] = {
 		/* PHY_GBIT_FEATURES */
 
 		.probe          = dp83867_probe,
+		.get_features	= phy_get_features_no_eee,
 		.config_init	= dp83867_config_init,
 		.soft_reset	= dp83867_phy_reset,
 
diff --git a/drivers/net/phy/dp83869.c b/drivers/net/phy/dp83869.c
index 1f381d7b13ff..4400654b0f72 100644
--- a/drivers/net/phy/dp83869.c
+++ b/drivers/net/phy/dp83869.c
@@ -906,6 +906,7 @@ static int dp83869_phy_reset(struct phy_device *phydev)
 	PHY_ID_MATCH_MODEL(_id),				\
 	.name		= (_name),				\
 	.probe          = dp83869_probe,			\
+	.get_features	= phy_get_features_no_eee,		\
 	.config_init	= dp83869_config_init,			\
 	.soft_reset	= dp83869_phy_reset,			\
 	.config_intr	= dp83869_config_intr,			\
diff --git a/drivers/net/phy/dp83tc811.c b/drivers/net/phy/dp83tc811.c
index e480c2a07450..92c5f3cfee9e 100644
--- a/drivers/net/phy/dp83tc811.c
+++ b/drivers/net/phy/dp83tc811.c
@@ -390,6 +390,7 @@ static struct phy_driver dp83811_driver[] = {
 		.phy_id_mask = 0xfffffff0,
 		.name = "TI DP83TC811",
 		/* PHY_BASIC_FEATURES */
+		.get_features = phy_get_features_no_eee,
 		.config_init = dp83811_config_init,
 		.config_aneg = dp83811_config_aneg,
 		.soft_reset = dp83811_phy_reset,
-- 
2.47.3

Re: [PATCH net-next 1/2] net: phy: allow drivers to disable EEE support via .get_features()

[Oleksij Rempel]

On Tue, Nov 11, 2025 at 11:38:38AM +0000, Russell King (Oracle) wrote:
> Allow PHY drivers to hook the .get_features() method to disable EEE
> support. This is useful for TI PHYs, where we have a statement that
> none of their gigabit products support EEE, yet at least DP83867
> reports EEE capabilties and implements EEE negotiation.
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> +/**
> + * phy_get_Features_no_eee - read the PHY features, disabling all EEE

s/phy_get_Features_no_eee/phy_get_features_no_eee


Otherwise looks good.

Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>

Thank you.
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [PATCH net-next 2/2] net: phy: TI PHYs use phy_get_features_no_eee()

[Oleksij Rempel]

On Tue, Nov 11, 2025 at 11:38:43AM +0000, Russell King (Oracle) wrote:
> As TI Gigabit PHYs do not support EEE, use the newly introduced
> phy_get_features_no_eee() to read the features but mark EEE as
> disabled.
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> ---
>  drivers/net/phy/dp83822.c   | 3 +++
>  drivers/net/phy/dp83867.c   | 1 +
>  drivers/net/phy/dp83869.c   | 1 +
>  drivers/net/phy/dp83tc811.c | 1 +
>  4 files changed, 6 insertions(+)
> 
> diff --git a/drivers/net/phy/dp83822.c b/drivers/net/phy/dp83822.c
> index 33db21251f2e..20caf9a5faa7 100644
> --- a/drivers/net/phy/dp83822.c
> +++ b/drivers/net/phy/dp83822.c
> @@ -1160,6 +1160,7 @@ static int dp83822_led_hw_control_get(struct phy_device *phydev, u8 index,
>  		.name		= (_name),			\
>  		/* PHY_BASIC_FEATURES */			\
>  		.probe          = dp83822_probe,		\
> +		.get_features	= phy_get_features_no_eee,	\
>  		.soft_reset	= dp83822_phy_reset,		\
>  		.config_init	= dp83822_config_init,		\
>  		.read_status	= dp83822_read_status,		\
> @@ -1180,6 +1181,7 @@ static int dp83822_led_hw_control_get(struct phy_device *phydev, u8 index,
>  		.name		= (_name),			\
>  		/* PHY_BASIC_FEATURES */			\
>  		.probe          = dp8382x_probe,		\
> +		.get_features	= phy_get_features_no_eee,	\
>  		.soft_reset	= dp83822_phy_reset,		\
>  		.config_init	= dp83825_config_init,		\
>  		.get_wol = dp83822_get_wol,			\
> @@ -1196,6 +1198,7 @@ static int dp83822_led_hw_control_get(struct phy_device *phydev, u8 index,
>  		.name		= (_name),			\
>  		/* PHY_BASIC_FEATURES */			\
>  		.probe          = dp83826_probe,		\
> +		.get_features	= phy_get_features_no_eee,	\
>  		.soft_reset	= dp83822_phy_reset,		\
>  		.config_init	= dp83826_config_init,		\
>  		.get_wol = dp83822_get_wol,			\

The DP83822/25/26 are all 100 Mbit variants. They all officially claim
EEE support. Maybe it is too early to give up here?

> diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c
> index 36a0c1b7f59c..da055ff861be 100644
> --- a/drivers/net/phy/dp83867.c
> +++ b/drivers/net/phy/dp83867.c
> @@ -1124,6 +1124,7 @@ static struct phy_driver dp83867_driver[] = {
>  		/* PHY_GBIT_FEATURES */
>  
>  		.probe          = dp83867_probe,
> +		.get_features	= phy_get_features_no_eee,
>  		.config_init	= dp83867_config_init,
>  		.soft_reset	= dp83867_phy_reset,

ACK

> diff --git a/drivers/net/phy/dp83869.c b/drivers/net/phy/dp83869.c
> index 1f381d7b13ff..4400654b0f72 100644
> --- a/drivers/net/phy/dp83869.c
> +++ b/drivers/net/phy/dp83869.c
> @@ -906,6 +906,7 @@ static int dp83869_phy_reset(struct phy_device *phydev)
>  	PHY_ID_MATCH_MODEL(_id),				\
>  	.name		= (_name),				\
>  	.probe          = dp83869_probe,			\
> +	.get_features	= phy_get_features_no_eee,		\
>  	.config_init	= dp83869_config_init,			\
>  	.soft_reset	= dp83869_phy_reset,			\
>  	.config_intr	= dp83869_config_intr,			\

ACK

> diff --git a/drivers/net/phy/dp83tc811.c b/drivers/net/phy/dp83tc811.c
> index e480c2a07450..92c5f3cfee9e 100644
> --- a/drivers/net/phy/dp83tc811.c
> +++ b/drivers/net/phy/dp83tc811.c
> @@ -390,6 +390,7 @@ static struct phy_driver dp83811_driver[] = {
>  		.phy_id_mask = 0xfffffff0,
>  		.name = "TI DP83TC811",
>  		/* PHY_BASIC_FEATURES */
> +		.get_features = phy_get_features_no_eee,
>  		.config_init = dp83811_config_init,
>  		.config_aneg = dp83811_config_aneg,
>  		.soft_reset = dp83811_phy_reset,

Not sure about this one. It is 100BaseT1 without autoneg support.

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [PATCH net-next 2/2] net: phy: TI PHYs use phy_get_features_no_eee()

[Russell King (Oracle)]

On Wed, Nov 12, 2025 at 09:27:57AM +0100, Oleksij Rempel wrote:
> On Tue, Nov 11, 2025 at 11:38:43AM +0000, Russell King (Oracle) wrote:
> > As TI Gigabit PHYs do not support EEE, use the newly introduced
> > phy_get_features_no_eee() to read the features but mark EEE as
> > disabled.
> > 
> > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
...
> > @@ -1196,6 +1198,7 @@ static int dp83822_led_hw_control_get(struct phy_device *phydev, u8 index,
> >  		.name		= (_name),			\
> >  		/* PHY_BASIC_FEATURES */			\
> >  		.probe          = dp83826_probe,		\
> > +		.get_features	= phy_get_features_no_eee,	\
> >  		.soft_reset	= dp83822_phy_reset,		\
> >  		.config_init	= dp83826_config_init,		\
> >  		.get_wol = dp83822_get_wol,			\
> 
> The DP83822/25/26 are all 100 Mbit variants. They all officially claim
> EEE support. Maybe it is too early to give up here?

This is going to be horrid to guarantee getting the correct entry
in the patch - I *absolutely* hate this driver struct array. Please
provide a diff to be squashed into the patch.

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

[PATCH] net: dp83822/dp83tc811: do not blacklist EEE for now

[Oleksij Rempel]

dp83822 driver is supporting DP83822/25/26 PHYs, which are
all 100Mbit variants. TI support forum says - only 1Gbit variants are
broken.

dp83tc811 driver is supporting 1000BaseT1 SPE variant, which do not has
autoneg support towards MDI.

Note: dp83tc811 wires phydev->autoneg to control SGMII autoneg, which
can't be proper decision. But it is a different issue.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 drivers/net/phy/dp83822.c   | 3 ---
 drivers/net/phy/dp83tc811.c | 1 -
 2 files changed, 4 deletions(-)

diff --git a/drivers/net/phy/dp83822.c b/drivers/net/phy/dp83822.c
index 20caf9a5faa7..33db21251f2e 100644
--- a/drivers/net/phy/dp83822.c
+++ b/drivers/net/phy/dp83822.c
@@ -1160,7 +1160,6 @@ static int dp83822_led_hw_control_get(struct phy_device *phydev, u8 index,
 		.name		= (_name),			\
 		/* PHY_BASIC_FEATURES */			\
 		.probe          = dp83822_probe,		\
-		.get_features	= phy_get_features_no_eee,	\
 		.soft_reset	= dp83822_phy_reset,		\
 		.config_init	= dp83822_config_init,		\
 		.read_status	= dp83822_read_status,		\
@@ -1181,7 +1180,6 @@ static int dp83822_led_hw_control_get(struct phy_device *phydev, u8 index,
 		.name		= (_name),			\
 		/* PHY_BASIC_FEATURES */			\
 		.probe          = dp8382x_probe,		\
-		.get_features	= phy_get_features_no_eee,	\
 		.soft_reset	= dp83822_phy_reset,		\
 		.config_init	= dp83825_config_init,		\
 		.get_wol = dp83822_get_wol,			\
@@ -1198,7 +1196,6 @@ static int dp83822_led_hw_control_get(struct phy_device *phydev, u8 index,
 		.name		= (_name),			\
 		/* PHY_BASIC_FEATURES */			\
 		.probe          = dp83826_probe,		\
-		.get_features	= phy_get_features_no_eee,	\
 		.soft_reset	= dp83822_phy_reset,		\
 		.config_init	= dp83826_config_init,		\
 		.get_wol = dp83822_get_wol,			\
diff --git a/drivers/net/phy/dp83tc811.c b/drivers/net/phy/dp83tc811.c
index 92c5f3cfee9e..e480c2a07450 100644
--- a/drivers/net/phy/dp83tc811.c
+++ b/drivers/net/phy/dp83tc811.c
@@ -390,7 +390,6 @@ static struct phy_driver dp83811_driver[] = {
 		.phy_id_mask = 0xfffffff0,
 		.name = "TI DP83TC811",
 		/* PHY_BASIC_FEATURES */
-		.get_features = phy_get_features_no_eee,
 		.config_init = dp83811_config_init,
 		.config_aneg = dp83811_config_aneg,
 		.soft_reset = dp83811_phy_reset,
-- 
2.47.3

Re: [PATCH] net: dp83822/dp83tc811: do not blacklist EEE for now

[Russell King (Oracle)]

On Wed, Nov 12, 2025 at 02:59:35PM +0100, Oleksij Rempel wrote:
> Note: dp83tc811 wires phydev->autoneg to control SGMII autoneg, which
> can't be proper decision. But it is a different issue.

Yep, that is just wrong. You didn't state whether you are happy with my
plan to squash this into my patch. What would you like to happen with
authorship etc?

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

Re: [PATCH] net: dp83822/dp83tc811: do not blacklist EEE for now

[Oleksij Rempel]

On Wed, Nov 12, 2025 at 03:55:48PM +0000, Russell King (Oracle) wrote:
> On Wed, Nov 12, 2025 at 02:59:35PM +0100, Oleksij Rempel wrote:
> > Note: dp83tc811 wires phydev->autoneg to control SGMII autoneg, which
> > can't be proper decision. But it is a different issue.
> 
> Yep, that is just wrong. You didn't state whether you are happy with my
> plan to squash this into my patch. What would you like to happen with
> authorship etc?

Just squash it and add my:
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>

Thank you!
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |