From: Oleksij Rempel <o.rempel@pengutronix.de>
To: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Emanuele Ghidoli <ghidoliemanuele@gmail.com>,
Eric Dumazet <edumazet@google.com>,
Fabio Estevam <festevam@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next 1/2] net: phy: allow drivers to disable EEE support via .get_features()
Date: Wed, 12 Nov 2025 09:14:30 +0100 [thread overview]
Message-ID: <aRRB5miRuA57NSk5@pengutronix.de> (raw)
In-Reply-To: <E1vImhq-0000000DrQc-3bMW@rmk-PC.armlinux.org.uk>
On Tue, Nov 11, 2025 at 11:38:38AM +0000, Russell King (Oracle) wrote:
> Allow PHY drivers to hook the .get_features() method to disable EEE
> support. This is useful for TI PHYs, where we have a statement that
> none of their gigabit products support EEE, yet at least DP83867
> reports EEE capabilties and implements EEE negotiation.
>
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> +/**
> + * phy_get_Features_no_eee - read the PHY features, disabling all EEE
s/phy_get_Features_no_eee/phy_get_features_no_eee
Otherwise looks good.
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
Thank you.
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2025-11-12 8:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 11:38 [PATCH net-next 0/2] net: phy: disable EEE on TI PHYs Russell King (Oracle)
2025-11-11 11:38 ` [PATCH net-next 1/2] net: phy: allow drivers to disable EEE support via .get_features() Russell King (Oracle)
2025-11-12 8:14 ` Oleksij Rempel [this message]
2025-11-11 11:38 ` [PATCH net-next 2/2] net: phy: TI PHYs use phy_get_features_no_eee() Russell King (Oracle)
2025-11-12 8:27 ` Oleksij Rempel
2025-11-12 8:33 ` Russell King (Oracle)
2025-11-12 13:59 ` [PATCH] net: dp83822/dp83tc811: do not blacklist EEE for now Oleksij Rempel
2025-11-12 15:55 ` Russell King (Oracle)
2025-11-13 5:08 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRRB5miRuA57NSk5@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=festevam@gmail.com \
--cc=ghidoliemanuele@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).