From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Emanuele Ghidoli <ghidoliemanuele@gmail.com>,
Eric Dumazet <edumazet@google.com>,
Fabio Estevam <festevam@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next 2/2] net: phy: TI PHYs use phy_get_features_no_eee()
Date: Wed, 12 Nov 2025 08:33:48 +0000 [thread overview]
Message-ID: <aRRGbAR26GuyKKZl@shell.armlinux.org.uk> (raw)
In-Reply-To: <aRRFDUewyw9x7teC@pengutronix.de>
On Wed, Nov 12, 2025 at 09:27:57AM +0100, Oleksij Rempel wrote:
> On Tue, Nov 11, 2025 at 11:38:43AM +0000, Russell King (Oracle) wrote:
> > As TI Gigabit PHYs do not support EEE, use the newly introduced
> > phy_get_features_no_eee() to read the features but mark EEE as
> > disabled.
> >
> > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
...
> > @@ -1196,6 +1198,7 @@ static int dp83822_led_hw_control_get(struct phy_device *phydev, u8 index,
> > .name = (_name), \
> > /* PHY_BASIC_FEATURES */ \
> > .probe = dp83826_probe, \
> > + .get_features = phy_get_features_no_eee, \
> > .soft_reset = dp83822_phy_reset, \
> > .config_init = dp83826_config_init, \
> > .get_wol = dp83822_get_wol, \
>
> The DP83822/25/26 are all 100 Mbit variants. They all officially claim
> EEE support. Maybe it is too early to give up here?
This is going to be horrid to guarantee getting the correct entry
in the patch - I *absolutely* hate this driver struct array. Please
provide a diff to be squashed into the patch.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-11-12 8:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 11:38 [PATCH net-next 0/2] net: phy: disable EEE on TI PHYs Russell King (Oracle)
2025-11-11 11:38 ` [PATCH net-next 1/2] net: phy: allow drivers to disable EEE support via .get_features() Russell King (Oracle)
2025-11-12 8:14 ` Oleksij Rempel
2025-11-11 11:38 ` [PATCH net-next 2/2] net: phy: TI PHYs use phy_get_features_no_eee() Russell King (Oracle)
2025-11-12 8:27 ` Oleksij Rempel
2025-11-12 8:33 ` Russell King (Oracle) [this message]
2025-11-12 13:59 ` [PATCH] net: dp83822/dp83tc811: do not blacklist EEE for now Oleksij Rempel
2025-11-12 15:55 ` Russell King (Oracle)
2025-11-13 5:08 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRRGbAR26GuyKKZl@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=festevam@gmail.com \
--cc=ghidoliemanuele@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).