From: Hangbin Liu <liuhangbin@gmail.com>
To: Felix Maurer <fmaurer@redhat.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
m-karicheri2@ti.com, arvid.brodin@alten.se,
bigeasy@linutronix.de
Subject: Re: [PATCH net 0/2] hsr: Send correct HSRv0 supervision frames
Date: Wed, 12 Nov 2025 09:41:42 +0000 [thread overview]
Message-ID: <aRRWVkY4LghIA7RP@fedora> (raw)
In-Reply-To: <cover.1762876095.git.fmaurer@redhat.com>
On Tue, Nov 11, 2025 at 05:29:31PM +0100, Felix Maurer wrote:
> Hangbin recently reported that the hsr selftests were failing and noted
> that the entries in the node table were not merged, i.e., had
> 00:00:00:00:00:00 as MacAddressB forever [1].
>
> This failure only occured with HSRv0 because it was not sending
> supervision frames anymore. While debugging this I found that we were
> not really following the HSRv0 standard for the supervision frames we
> sent, so I additionally made a few changes to get closer to the standard
> and restore a more correct behavior we had a while ago.
>
> The selftests can still fail because they take a while and run into the
> timeout. I did not include a change of the timeout because I have more
> improvements to the selftests mostly ready that change the test duration
> but are net-next material.
>
> [1]: https://lore.kernel.org/netdev/aMONxDXkzBZZRfE5@fedora/
>
> Felix Maurer (2):
> hsr: Fix supervision frame sending on HSRv0
> hsr: Follow standard for HSRv0 supervision frames
>
> net/hsr/hsr_device.c | 5 ++++-
> net/hsr/hsr_forward.c | 22 +++++++++++++++-------
> 2 files changed, 19 insertions(+), 8 deletions(-)
>
> --
> 2.51.0
>
Tested-by: Hangbin Liu <liuhangbin@gmail.com>
next prev parent reply other threads:[~2025-11-12 9:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 16:29 [PATCH net 0/2] hsr: Send correct HSRv0 supervision frames Felix Maurer
2025-11-11 16:29 ` [PATCH net 1/2] hsr: Fix supervision frame sending on HSRv0 Felix Maurer
2025-11-12 10:03 ` Sebastian Andrzej Siewior
2025-11-11 16:29 ` [PATCH net 2/2] hsr: Follow standard for HSRv0 supervision frames Felix Maurer
2025-11-12 10:24 ` Sebastian Andrzej Siewior
2025-11-12 11:01 ` Felix Maurer
2025-11-12 11:59 ` Sebastian Andrzej Siewior
2025-11-12 9:41 ` Hangbin Liu [this message]
2025-11-12 10:03 ` [PATCH net 0/2] hsr: Send correct " Sebastian Andrzej Siewior
2025-11-12 10:38 ` Felix Maurer
2025-11-13 15:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRRWVkY4LghIA7RP@fedora \
--to=liuhangbin@gmail.com \
--cc=arvid.brodin@alten.se \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fmaurer@redhat.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=m-karicheri2@ti.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).