Re: [PATCH net-next v2 0/2] net: phy: disable EEE on TI PHYs

["Russell King (Oracle)" <linux@armlinux.org.uk>]

On Thu, Nov 13, 2025 at 09:11:32PM +0100, Heiner Kallweit wrote:
> On 11/13/2025 12:27 PM, Russell King (Oracle) wrote:
> > Hi,
> > 
> > Towards the end of October, we discussed EEE on TI PHYs which seems to
> > cause problems with the stmmac hardware. This problem was never fully
> > diagnosed, but it was identified that TI PHYs do not support LPI
> > signalling, but report that EEE is supported, and they implement the
> > advertisement registers and that functionality.
> > 
> > This series allows PHY drivers to disable EEE support.
> > 
> > v2:
> > - integrate Oleksij Rempel's review comments, and merge update
> >   into patch 2 to allow EEE on non-1G variants.
> > 
> >  drivers/net/phy/dp83867.c    |  1 +
> >  drivers/net/phy/dp83869.c    |  1 +
> >  drivers/net/phy/phy-core.c   |  2 --
> >  drivers/net/phy/phy_device.c | 32 +++++++++++++++++++++++++++++---
> >  include/linux/phy.h          |  1 +
> >  5 files changed, 32 insertions(+), 5 deletions(-)
> > 
> 
> Alternatively the PHY driver could call phy_disable_eee()
> in its config_init. Then we wouldn't have to touch core code.

If that's what you intend, then please update the kerneldoc for
phy_disable_eee() so that it doesn't state that it's for MAC use
(because that implies it's not for PHY drivers.)

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!