From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Wei Fang <wei.fang@nxp.com>
Cc: "andrew@lunn.ch" <andrew@lunn.ch>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"eric@nelint.com" <eric@nelint.com>,
"maxime.chevallier@bootlin.com" <maxime.chevallier@bootlin.com>,
"imx@lists.linux.dev" <imx@lists.linux.dev>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] net: phylink: add missing supported link modes for the fixed-link
Date: Fri, 14 Nov 2025 09:08:40 +0000 [thread overview]
Message-ID: <aRbxmCPDe5ybYGwO@shell.armlinux.org.uk> (raw)
In-Reply-To: <PAXPR04MB8510007477C858A7E952E8E988CAA@PAXPR04MB8510.eurprd04.prod.outlook.com>
On Fri, Nov 14, 2025 at 08:52:07AM +0000, Wei Fang wrote:
> > On Fri, Nov 14, 2025 at 01:28:08PM +0800, Wei Fang wrote:
> > > Pause, Asym_Pause and Autoneg bits are not set when pl->supported is
> > > initialized, so these link modes will not work for the fixed-link.
> >
> > What problem does this cause?
> >
>
> Our i.MX943 platform, the switch CPU port is connected to an ENETC
> MAC, the link speed is 2.5Gbps. And one user port of switch is 1Gbps.
> If the flow-control of internal link is not enabled, we can see the iperf
> performance of TCP packets is very low. Because of the congestion
> (ingress speed of CPU port is greater than egress speed of user port) in
> the switch, some TCP packets were dropped, resulting in the packets
> being retransmitted many times.
Please include this in the commit message, thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-11-14 9:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 5:28 [PATCH net] net: phylink: add missing supported link modes for the fixed-link Wei Fang
2025-11-14 8:32 ` Russell King (Oracle)
2025-11-14 8:52 ` Wei Fang
2025-11-14 9:08 ` Russell King (Oracle) [this message]
2025-11-14 9:18 ` Wei Fang
2025-11-14 8:38 ` Maxime Chevallier
2025-11-15 20:36 ` Andrew Lunn
2025-11-15 21:01 ` Russell King (Oracle)
2025-11-15 21:15 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRbxmCPDe5ybYGwO@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric@nelint.com \
--cc=hkallweit1@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wei.fang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).