From: Simon Horman <horms@kernel.org>
To: Qingfang Deng <dqfext@gmail.com>
Cc: Namjae Jeon <linkinjeon@kernel.org>,
Steve French <smfrench@gmail.com>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Tom Talpey <tom@talpey.com>, Hyunchul Lee <hyc.lee@gmail.com>,
Ronnie Sahlberg <lsahlber@redhat.com>,
linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, Stefan Metzmacher <metze@samba.org>
Subject: Re: [PATCH v2] ksmbd: server: avoid busy polling in accept loop
Date: Fri, 14 Nov 2025 12:02:01 +0000 [thread overview]
Message-ID: <aRcaOZ79iQwqMTZI@horms.kernel.org> (raw)
In-Reply-To: <20251111104750.25739-1-dqfext@gmail.com>
On Tue, Nov 11, 2025 at 06:47:49PM +0800, Qingfang Deng wrote:
...
> @@ -458,10 +451,6 @@ static void tcp_destroy_socket(struct socket *ksmbd_socket)
> if (!ksmbd_socket)
> return;
>
> - /* set zero to timeout */
> - ksmbd_tcp_rcv_timeout(ksmbd_socket, 0);
> - ksmbd_tcp_snd_timeout(ksmbd_socket, 0);
> -
Hi Qingfang Deng,
W=1 builds tell me that ksmbd_tcp_rcv_timeout() is now unused:
I expect it can be removed.
> ret = kernel_sock_shutdown(ksmbd_socket, SHUT_RDWR);
> if (ret)
> pr_err("Failed to shutdown socket: %d\n", ret);
...
prev parent reply other threads:[~2025-11-14 12:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 10:47 [PATCH v2] ksmbd: server: avoid busy polling in accept loop Qingfang Deng
2025-11-14 12:02 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRcaOZ79iQwqMTZI@horms.kernel.org \
--to=horms@kernel.org \
--cc=dqfext@gmail.com \
--cc=hyc.lee@gmail.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lsahlber@redhat.com \
--cc=metze@samba.org \
--cc=netdev@vger.kernel.org \
--cc=senozhatsky@chromium.org \
--cc=smfrench@gmail.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).