netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Buday Csaba <buday.csaba@prolan.hu>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v2 1/3] net: mdio: move device reset functions to mdio_device.c
Date: Mon, 17 Nov 2025 13:22:32 +0100	[thread overview]
Message-ID: <aRsTiBZBqc-cx38W@debianbuilder> (raw)
In-Reply-To: <aRrsOfJv6kUPCxNd@shell.armlinux.org.uk>

On Mon, Nov 17, 2025 at 09:34:49AM +0000, Russell King (Oracle) wrote:
> On Mon, Nov 17, 2025 at 10:28:51AM +0100, Buday Csaba wrote:
> > diff --git a/include/linux/mdio.h b/include/linux/mdio.h
> > index 42d6d47e4..1322d2623 100644
> > --- a/include/linux/mdio.h
> > +++ b/include/linux/mdio.h
> > @@ -92,6 +92,8 @@ void mdio_device_free(struct mdio_device *mdiodev);
> >  struct mdio_device *mdio_device_create(struct mii_bus *bus, int addr);
> >  int mdio_device_register(struct mdio_device *mdiodev);
> >  void mdio_device_remove(struct mdio_device *mdiodev);
> > +int mdio_device_register_gpiod(struct mdio_device *mdiodev);
> > +int mdio_device_register_reset(struct mdio_device *mdiodev);
> 
> These are private functions to the mdio code living in drivers/net/phy,
> so I wonder whether we want to have drivers/net/phy/mdio.h for these to
> discourage other code calling these?

I completely agree with that, but that file does not exist yet.
Is it worth creating just for the sake of these two functions?

Csaba


  reply	other threads:[~2025-11-17 12:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-17  9:28 [PATCH net-next v2 0/3] net: mdio: improve reset handling of mdio devices Buday Csaba
2025-11-17  9:28 ` [PATCH net-next v2 1/3] net: mdio: move device reset functions to mdio_device.c Buday Csaba
2025-11-17  9:34   ` Russell King (Oracle)
2025-11-17 12:22     ` Buday Csaba [this message]
2025-11-17 13:48       ` Andrew Lunn
2025-11-17  9:28 ` [PATCH net-next v2 2/3] net: mdio: common handling of phy device reset properties Buday Csaba
2025-11-17  9:28 ` [PATCH net-next v2 3/3] net: mdio: improve reset handling in mdio_device.c Buday Csaba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aRsTiBZBqc-cx38W@debianbuilder \
    --to=buday.csaba@prolan.hu \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).