From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: Alessandro Decina <alessandro.d@gmail.com>
Cc: <netdev@vger.kernel.org>, "David S. Miller" <davem@davemloft.net>,
"Alexei Starovoitov" <ast@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"Daniel Borkmann" <daniel@iogearbox.net>,
Eric Dumazet <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
Jesper Dangaard Brouer <hawk@kernel.org>,
"John Fastabend" <john.fastabend@gmail.com>,
Paolo Abeni <pabeni@redhat.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Stanislav Fomichev <sdf@fomichev.me>,
Tirthendu Sarkar <tirthendu.sarkar@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>, <bpf@vger.kernel.org>,
<intel-wired-lan@lists.osuosl.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net v3 1/1] i40e: xsk: advance next_to_clean on status descriptors
Date: Tue, 18 Nov 2025 09:04:58 +0100 [thread overview]
Message-ID: <aRwoqgw1KFX+H6ci@boxer> (raw)
In-Reply-To: <aRwUGnyFBxrkjGl7@lima-default>
On Tue, Nov 18, 2025 at 05:37:14PM +1100, Alessandro Decina wrote:
> On Mon, Nov 17, 2025 at 05:37:49PM +0100, Maciej Fijalkowski wrote:
> > This revision is much more clear to me. Only thing that might be bothering
> > someone is doubled i40e_rx_bi() call in i40e_get_rx_buffer(). Not sure if
> > we can do about it though as we need to use ntp from before potential
> > increment.
> >
> > ...maybe pass rx_buffer to i40e_get_rx_buffer() ?
>
> Surely the compiler isn't going to actually reload here, but yeah not
> great code wise. How about I pass it the buffer and rename to
> i40e_prepare_rx_buffer to better match what's happening now?
SGTM!
>
prev parent reply other threads:[~2025-11-18 8:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-13 8:24 [PATCH net v3 0/1] i40e: xsk: advance next_to_clean on status descriptors Alessandro Decina
2025-11-13 8:24 ` [PATCH net v3 1/1] " Alessandro Decina
2025-11-14 5:49 ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-11-14 13:01 ` Maciej Fijalkowski
2025-11-15 7:58 ` Alessandro Decina
2025-11-17 16:37 ` Maciej Fijalkowski
2025-11-18 6:37 ` Alessandro Decina
2025-11-18 8:04 ` Maciej Fijalkowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRwoqgw1KFX+H6ci@boxer \
--to=maciej.fijalkowski@intel.com \
--cc=alessandro.d@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=sdf@fomichev.me \
--cc=tirthendu.sarkar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).