From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0ED8F3043D1; Tue, 18 Nov 2025 14:02:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763474548; cv=none; b=CSGdk6TZ/qOTg5bMW2Nvl5GYP94XxaU3mdDl5NOygEUB2oef8YP6LEixmmEsKGOZNhf+RpjD/KdQLaDKRZqN1lzB1F6o9wOVX5SZ7aRG6bnP0xMmJSRzZaUIoZexmofpksygYFVYT2ZejLKrq6Q92NIpdJCyVLRvMg6Hc2x3Tyk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763474548; c=relaxed/simple; bh=+KhqY3oB1wgkGc6jzN+UfYOvpqqc60Dgp6JPVcxBT1Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GXE7y0tEWyqbND+vzGYrwYzfMgezSst+Agr1xP6Ip0pBryZUNsdov9nBnvatIRdipMBKNlAMHy5B8N14W3rSYSwYxYXiFBVFoDJt82kHURFGCW1yJ2LtVBDzRdBMv2RZ5iVX2d8XT4FLFe5iEA+gT+7fPZ5c4FCfQ/YfjvFyLog= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=Uv0XmdqB; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="Uv0XmdqB" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Dg01KqUntpaFpjCXJtHlRufZ34s60nzPkse3Ae90upo=; b=Uv0XmdqBapCHl4/1aM3xKwbpby m739xINTZZujr9WHqEVYit0n8ne2KlWegg8Q1/AiVm07rmj+MUplkUH7Vs0QHzhekb91pQ4jV9iAa oMsfnrWvz206steIJdpH/Ek2LQz6TkQva7Okdu9D8pYbAkKDHxsd8Eda9skbMCkhD44iTnQabge1/ hYMUTL1LSRZQ26f9uEFFW7pWrwGjHzj7a5tnxZWUAFNNeT3FONqRrpGDjJjJGJbd/C3xbn9ObVBv6 iIT7koyhZp4BH9U4q22aIx2IlYJq/1h8denLX9mNx0DubtV9LT5eTxSmn5vvEeSB5IS6He67Yq46f aWp5Havg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:50934) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vLMHg-000000003Hs-3XN4; Tue, 18 Nov 2025 14:02:16 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.98.2) (envelope-from ) id 1vLMHe-000000002VP-0rEX; Tue, 18 Nov 2025 14:02:14 +0000 Date: Tue, 18 Nov 2025 14:02:14 +0000 From: "Russell King (Oracle)" To: Andrew Lunn Cc: Wei Fang , "hkallweit1@gmail.com" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "eric@nelint.com" , "maxime.chevallier@bootlin.com" , "imx@lists.linux.dev" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 net] net: phylink: add missing supported link modes for the fixed-link Message-ID: References: <20251117102943.1862680-1-wei.fang@nxp.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) On Tue, Nov 18, 2025 at 03:00:00PM +0100, Andrew Lunn wrote: > > > > Fixes: de7d3f87be3c ("net: phylink: Use phy_caps_lookup for fixed-link > > > > configuration") > > > > Signed-off-by: Wei Fang > > > > Reviewed-by: Maxime Chevallier > > > > > > NAK. I give up. > > > > > > > Sorry, could you please tell me what the reason is? > > I think Russell is referring to the commit message, and how you only > quoted a little section of his explanation. There is no limit to > commit messages, they don't need to be short. It is actually better if > they are long. So you could use his whole explanation. And then you > don't need the link. Worse than that. I gave my reviewed-by, which seems to have been a waste of time. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!