* [net-next PATCH] octeontx2-af: Skip TM tree print for disabled SQs
@ 2025-11-18 5:42 Anshumali Gaur
2025-11-18 9:47 ` Simon Horman
2025-11-20 4:21 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Anshumali Gaur @ 2025-11-18 5:42 UTC (permalink / raw)
To: netdev, linux-kernel
Cc: Anshumali Gaur, Sunil Goutham, Linu Cherian, Geetha sowjanya,
Jerin Jacob, hariprasad, Subbaraya Sundeep, Andrew Lunn,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
Currently, the TM tree is printing all SQ topology including those
which are not enabled, this results in redundant output for SQs
which are not active. This patch adds a check in print_tm_tree()
to skip printing the TM tree hierarchy if the SQ is not enabled.
Signed-off-by: Anshumali Gaur <agaur@marvell.com>
---
drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c
index 7370812ece2a..15d3cb0b9da6 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c
@@ -1663,6 +1663,9 @@ static void print_tm_tree(struct seq_file *m,
int blkaddr;
u64 cfg;
+ if (!sq_ctx->ena)
+ return;
+
blkaddr = nix_hw->blkaddr;
schq = sq_ctx->smq;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [net-next PATCH] octeontx2-af: Skip TM tree print for disabled SQs
2025-11-18 5:42 [net-next PATCH] octeontx2-af: Skip TM tree print for disabled SQs Anshumali Gaur
@ 2025-11-18 9:47 ` Simon Horman
2025-11-20 4:21 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2025-11-18 9:47 UTC (permalink / raw)
To: Anshumali Gaur
Cc: netdev, linux-kernel, Sunil Goutham, Linu Cherian,
Geetha sowjanya, Jerin Jacob, hariprasad, Subbaraya Sundeep,
Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni
On Tue, Nov 18, 2025 at 11:12:34AM +0530, Anshumali Gaur wrote:
> Currently, the TM tree is printing all SQ topology including those
> which are not enabled, this results in redundant output for SQs
> which are not active. This patch adds a check in print_tm_tree()
> to skip printing the TM tree hierarchy if the SQ is not enabled.
>
> Signed-off-by: Anshumali Gaur <agaur@marvell.com>
Thanks Anshumali,
As per my feedback on the 'net' variant of this patch,
this looks good to me.
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [net-next PATCH] octeontx2-af: Skip TM tree print for disabled SQs
2025-11-18 5:42 [net-next PATCH] octeontx2-af: Skip TM tree print for disabled SQs Anshumali Gaur
2025-11-18 9:47 ` Simon Horman
@ 2025-11-20 4:21 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-11-20 4:21 UTC (permalink / raw)
To: Anshumali Gaur
Cc: netdev, linux-kernel, sgoutham, lcherian, gakula, jerinj, hkelam,
sbhatta, andrew+netdev, davem, edumazet, kuba, pabeni
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 18 Nov 2025 11:12:34 +0530 you wrote:
> Currently, the TM tree is printing all SQ topology including those
> which are not enabled, this results in redundant output for SQs
> which are not active. This patch adds a check in print_tm_tree()
> to skip printing the TM tree hierarchy if the SQ is not enabled.
>
> Signed-off-by: Anshumali Gaur <agaur@marvell.com>
>
> [...]
Here is the summary with links:
- [net-next] octeontx2-af: Skip TM tree print for disabled SQs
https://git.kernel.org/netdev/net-next/c/929ca3bceab8
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-11-20 4:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-18 5:42 [net-next PATCH] octeontx2-af: Skip TM tree print for disabled SQs Anshumali Gaur
2025-11-18 9:47 ` Simon Horman
2025-11-20 4:21 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).