From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>
Cc: netdev@vger.kernel.org, kuba@kernel.org, pabeni@redhat.com
Subject: Re: [PATCH net-next 10/11] tools: ynl: add sample for wireguard
Date: Tue, 2 Dec 2025 04:09:30 +0100 [thread overview]
Message-ID: <aS5Yarah6ZhyckEz@zx2c4.com> (raw)
In-Reply-To: <21cf5582-61b7-469b-a235-3d44be898e7e@fiberby.net>
On Mon, Dec 01, 2025 at 09:00:41PM +0000, Asbjørn Sloth Tønnesen wrote:
> On 12/1/25 2:28 AM, Jason A. Donenfeld wrote:
> > [..]
> > +
> > + req = wireguard_get_device_req_alloc();
> > + build_request(req, argv[1]);
> > +
> > + ys = ynl_sock_create(&ynl_wireguard_family, NULL);
> > + if (!ys)
> > + return 2;
>
> I will send a patch for fixing up the error patch here, and call
> wireguard_get_device_req_free() before returning here, after rc1.
>
> The broken error path here was pointed out by the AI reviewer.
Let's just drop this patch 10/11 then from the queue, but merge the
others.
Jason
next prev parent reply other threads:[~2025-12-02 3:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-01 2:28 [PATCH net-next 00/11] wireguard updates for 6.19 Jason A. Donenfeld
2025-12-01 2:28 ` [PATCH net-next 01/11] wireguard: netlink: enable strict genetlink validation Jason A. Donenfeld
2025-12-01 2:28 ` [PATCH net-next 02/11] wireguard: netlink: validate nested arrays in policy Jason A. Donenfeld
2025-12-01 2:28 ` [PATCH net-next 03/11] wireguard: netlink: use WG_KEY_LEN in policies Jason A. Donenfeld
2025-12-01 2:28 ` [PATCH net-next 04/11] wireguard: netlink: convert to split ops Jason A. Donenfeld
2025-12-01 2:28 ` [PATCH net-next 05/11] wireguard: netlink: lower .maxattr for WG_CMD_GET_DEVICE Jason A. Donenfeld
2025-12-01 2:28 ` [PATCH net-next 06/11] netlink: specs: add specification for wireguard Jason A. Donenfeld
2025-12-01 2:28 ` [PATCH net-next 07/11] wireguard: uapi: move enum wg_cmd Jason A. Donenfeld
2025-12-01 2:28 ` [PATCH net-next 08/11] wireguard: uapi: move flag enums Jason A. Donenfeld
2025-12-01 2:28 ` [PATCH net-next 09/11] wireguard: uapi: generate header with ynl-gen Jason A. Donenfeld
2025-12-01 2:28 ` [PATCH net-next 10/11] tools: ynl: add sample for wireguard Jason A. Donenfeld
2025-12-01 21:00 ` Asbjørn Sloth Tønnesen
2025-12-02 3:09 ` Jason A. Donenfeld [this message]
2025-12-01 2:28 ` [PATCH net-next 11/11] wireguard: netlink: generate netlink code Jason A. Donenfeld
2025-12-01 23:07 ` [PATCH net-next 00/11] wireguard updates for 6.19 Jakub Kicinski
2025-12-02 3:19 ` Jason A. Donenfeld
2025-12-02 4:37 ` Jakub Kicinski
2025-12-04 17:43 ` Jason A. Donenfeld
2025-12-02 4:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aS5Yarah6ZhyckEz@zx2c4.com \
--to=jason@zx2c4.com \
--cc=ast@fiberby.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).