netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Buday Csaba <buday.csaba@prolan.hu>, Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 1/1] net: mdio: reset PHY before attempting to access ID register
Date: Tue, 2 Dec 2025 12:48:47 +0000	[thread overview]
Message-ID: <aS7gL3md82HEEjaP@shell.armlinux.org.uk> (raw)
In-Reply-To: <37ecfff6-19da-4b0d-9623-129431d5a218@redhat.com>

On Tue, Dec 02, 2025 at 01:38:21PM +0100, Paolo Abeni wrote:
> On 11/28/25 2:53 PM, Buday Csaba wrote:
> > When the ID of an Ethernet PHY is not provided by the 'compatible'
> > string in the device tree, its actual ID is read via the MDIO bus.
> > For some PHYs this could be unsafe, since a hard reset may be
> > necessary to safely access the MDIO registers.
> > 
> > Add a fallback mechanism for such devices: when reading the ID
> > fails, the reset will be asserted, and the ID read is retried.
> > 
> > This allows such devices to be used with an autodetected ID.
> > 
> > The fallback mechanism is activated in the error handling path, and
> > the return code of fwnode_mdiobus_register_phy() is unaltered, except
> > when the reset fails with -EPROBE_DEFER, which is propagated to the
> > caller.
> > 
> > Signed-off-by: Buday Csaba <buday.csaba@prolan.hu>
> 
> IMHO this deserves an explicit ack from phy maintainers. Unless such ack
> is going to land on the ML very soon, I suggest to defer this patch to
> the next cycle, as Jakub is wrapping the net-next PR.

No time to do anything quickly, sorry.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

  reply	other threads:[~2025-12-02 12:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-28 13:53 [PATCH net-next v2 1/1] net: mdio: reset PHY before attempting to access ID register Buday Csaba
2025-12-02 12:38 ` Paolo Abeni
2025-12-02 12:48   ` Russell King (Oracle) [this message]
2025-12-02 13:46 ` Andrew Lunn
2025-12-03 15:59   ` Russell King (Oracle)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aS7gL3md82HEEjaP@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=andrew@lunn.ch \
    --cc=buday.csaba@prolan.hu \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).