From: Buday Csaba <buday.csaba@prolan.hu>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: <netdev@vger.kernel.org>
Subject: Re: Re: [Question] Return value of mii_bus->write()
Date: Fri, 21 Nov 2025 08:15:24 +0100 [thread overview]
Message-ID: <aSARjLeqFjHKvrem@debianbuilder> (raw)
In-Reply-To: <8cbd4650-aeed-4d1c-8173-957776dfec51@gmail.com>
On Fri, Nov 21, 2025 at 07:53:21AM +0100, Heiner Kallweit wrote:
> On 11/21/2025 7:31 AM, Buday Csaba wrote:
> > I am preparing a patch to eliminate kernel-doc warnings in mdio_device.c
> > and mdio_bus.c
> >
> > I have ran into an ambiguity: what is mii_bus->write() supposed to
> > return on success? Documentation/networking/phy.txt does not give any
> > information about it, neither does the kdoc in include/linux/phy.h.
> >
> > It is clear that 0 is treated as success, and a negative indicates
> > failure. The reference implementation also follows this convention.
> > But the code in mdio_bus.c, for example: __mdiobus_modify_changed(),
> > seems to also expect positive return values from write().
> >
> I think you misread the code. __mdiobus_modify_changed() returns
> a positive value in case new and old value differ, but __mdiobus_write()
> never returns a positive value.
>
That is right, thank you!
Csaba
prev parent reply other threads:[~2025-11-21 7:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 6:31 [Question] Return value of mii_bus->write() Buday Csaba
2025-11-21 6:53 ` Heiner Kallweit
2025-11-21 7:15 ` Buday Csaba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aSARjLeqFjHKvrem@debianbuilder \
--to=buday.csaba@prolan.hu \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).