From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f44.google.com (mail-yx1-f44.google.com [74.125.224.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 735FB2DAFD2 for ; Fri, 21 Nov 2025 19:03:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763751836; cv=none; b=KnWC+/x5C4ByGteiR4fQXPgzhBUkChoA141zehJWYpvT6LSULlxHq+zuMks7AqYKIwWnRWzJkx91VYzRE5PABPjaZYpXntRVft58dLcfjmWDzIBjPuVpfguXQTaXyPyZ917oraUmcyRk/MIM9yj/mnlyPhIKTT9b8q6LaTliS74= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763751836; c=relaxed/simple; bh=JdSLpTVX2iWVVnKDVSvfFjbJUtvnuhLaoTLA6sfPhAo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cer9MRTeyAuncN+nfzUbm5sfaZok4CmaCV69Rlc3yxXRXubLwGuHC3hn+FwCtngnGggzM9IlmNgp7xGCCc9voI2hOsctjwNpGbow2OWlYi1pxyfD9DenNqxPDjO1hYY/59dFSz4MphLBXqzVNvzQaudNM9Upnov2YpmI2OGDSr0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CNhioqTn; arc=none smtp.client-ip=74.125.224.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CNhioqTn" Received: by mail-yx1-f44.google.com with SMTP id 956f58d0204a3-640f2c9ccbdso2042417d50.1 for ; Fri, 21 Nov 2025 11:03:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763751833; x=1764356633; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ZsyeuDVu3rFEqJRnWBFG2+MFZuPnp6VpaIUJkyp+gQI=; b=CNhioqTna98ViNEPLEESoGMiSL4ryVjexSc1boJ5OPdZl+flEzc7tfmP0lwFD/5ApB VHXuhZs5JqWIzTY+pWAep3W3jhNYJ4yWcjNLozw5fwjVtMdPNunqYJUBRlE3De0Q5WDo Y2F+zoPCPuavUrjsVU0z1s/UivaUR2FtahPQncqoATjwFBZ1g5+nx0CN2yQrT/jrGmp8 4TCVRv0DKv4cD2tZR/3odHlTcf+4Py8JhecgmLxu4X3C5+llgnd+5Ed+oPwprBMcabnt hkote8jCYhKvcnHFCRT7j6O+pWMpeL4gZbLvT4cGAF9Cd9B61eMgV+8vr9N92By/IT4X iodA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763751833; x=1764356633; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZsyeuDVu3rFEqJRnWBFG2+MFZuPnp6VpaIUJkyp+gQI=; b=fv+qMXxfkTNjhUqi6Ejc2n8mty4lrdy4lTgh0v/awe+dRSBFd9DpyuMRx+XJUYxZu9 gk8rQF+86Bm954FD2DIPPF8J6e67d1bRRziyfvt7DZlHk4dP3sGTvrNNaV8hE8kYzVls 5EWeRkKSTjx48wnCee9KeqLqcbSlKPuLemv1KY3WdxrnRwzZcQ92+58lYvwaJDUOwARW 31ja+BiVg1xaKmYjbRWie7dVjemiyOF85pJSdEbSHtZxhCBVheMpXRDiexbJ+OoflYm/ lEthqpBA7PXVDplvR5hTKPGnL3H1mP8PIozx1BmIiHT5G/vjriJndQGSzbo0H6tGvSX4 qDWg== X-Forwarded-Encrypted: i=1; AJvYcCVp6YSJ8T4IjLQjTxtQLK9OsDLnoCrIkvmNSyPRHeaBPk1xYY7T/i0OYgiX5YjytMdq8nHE6Bg=@vger.kernel.org X-Gm-Message-State: AOJu0Yxg9u/0d5cu2qJOOwRpOA1qEzELrI/CEKteemxUfn3buYiLhq4h QsK91WjmW2TiTcsJ/ypm8ofs428G/XtqddOWE0G3u/Sz3ERXyJXGxyia X-Gm-Gg: ASbGncvGKLW8eee2H/wgrvAeJAdy0CZdx14xZKDqalXHPPw7Apz4T7wKmExZOG/52fW dbT/eTyzAbFgtO4H7Ny4qvSi0/3RsZq3hNbx9qJi7Tu5JHr73kn3p0yX6R4Y4njxVM1SFyeznFt Mkn9c3kGXi3j7OxUGc2tvmdkENQt48zZ583bOlxvEePHOfrTPTZZX5VJhFaVhlh2mQfLC9GViSM 9KfnMePfUzkhQyVcbgKfBjptrlrncC6/Dili6ROQP+NVXSAPhresAvgGTDose9Lba7udsQLHpE6 UThdQgsc1GH8VwmK1pTm5H5oMFUmPe1BW6xrnW+l4MpPcPxAiO4KZlwU+aMzvLTbYJeOI10wDlh +K4c1N2ISPaJoojolA9VjHEHihlibOHAmwGF9pXFLJBQDptdesN1tiB3yAWwn8uRuAZC+y0HKtx JjqcpfZ8DQCiNulyPfoZTY6KDQxoxMGtInvs4yqTnYg/Viea4= X-Google-Smtp-Source: AGHT+IHqdQfTU4t/9nnncQ179liEt9vBvpItMsnoh0ykni1C+JgYJBg/+9EgA2A1pACRXR1G1tNPMQ== X-Received: by 2002:a05:690e:4298:10b0:63f:aadb:397a with SMTP id 956f58d0204a3-64302ab1807mr1907945d50.55.1763751833308; Fri, 21 Nov 2025 11:03:53 -0800 (PST) Received: from devvm11784.nha0.facebook.com ([2a03:2880:25ff:41::]) by smtp.gmail.com with ESMTPSA id 00721157ae682-78a7993e2d6sm18040287b3.39.2025.11.21.11.03.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Nov 2025 11:03:53 -0800 (PST) Date: Fri, 21 Nov 2025 11:03:51 -0800 From: Bobby Eshleman To: Stefano Garzarella Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Stefan Hajnoczi , "Michael S. Tsirkin" , Jason Wang , Eugenio =?iso-8859-1?Q?P=E9rez?= , Xuan Zhuo , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Bryan Tan , Vishnu Dasa , Broadcom internal kernel review list , Shuah Khan , linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, netdev@vger.kernel.org, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kselftest@vger.kernel.org, berrange@redhat.com, Sargun Dhillon , Bobby Eshleman Subject: Re: [PATCH net-next v11 05/13] vsock: add netns support to virtio transports Message-ID: References: <20251120-vsock-vmtest-v11-0-55cbc80249a7@meta.com> <20251120-vsock-vmtest-v11-5-55cbc80249a7@meta.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Nov 21, 2025 at 03:39:25PM +0100, Stefano Garzarella wrote: > On Thu, Nov 20, 2025 at 09:44:37PM -0800, Bobby Eshleman wrote: > > From: Bobby Eshleman > > > > Add netns support to loopback and vhost. Keep netns disabled for > > virtio-vsock, but add necessary changes to comply with common API > > updates. > > > > This is the patch in the series when vhost-vsock namespaces actually > > come online. Hence, vhost_transport_supports_local_mode() is switched > > to return true. > > > > Signed-off-by: Bobby Eshleman > > --- > > Changes in v11: > > - reorder with the skb ownership patch for loopback (Stefano) > > - toggle vhost_transport_supports_local_mode() to true > > > > Changes in v10: > > - Splitting patches complicates the series with meaningless placeholder > > values that eventually get replaced anyway, so to avoid that this > > patch combines into one. Links to previous patches here: > > - Link: https://lore.kernel.org/all/20251111-vsock-vmtest-v9-3-852787a37bed@meta.com/ > > - Link: https://lore.kernel.org/all/20251111-vsock-vmtest-v9-6-852787a37bed@meta.com/ > > - Link: https://lore.kernel.org/all/20251111-vsock-vmtest-v9-7-852787a37bed@meta.com/ > > - remove placeholder values (Stefano) > > - update comment describe net/net_mode for > > virtio_transport_reset_no_sock() > > --- > > drivers/vhost/vsock.c | 47 ++++++++++++++++++------ > > include/linux/virtio_vsock.h | 8 +++-- > > net/vmw_vsock/virtio_transport.c | 10 ++++-- > > net/vmw_vsock/virtio_transport_common.c | 63 ++++++++++++++++++++++++--------- > > net/vmw_vsock/vsock_loopback.c | 8 +++-- > > 5 files changed, 103 insertions(+), 33 deletions(-) > > Reviewed-by: Stefano Garzarella If we move the supports_local_mode() changes into this patch (for virtio and loopback, as I bring up in other discussion), should I drop this trailer or carry it forward? Thanks, Bobby