From: Simon Horman <horms@kernel.org>
To: Kai-Heng Feng <kaihengf@nvidia.com>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, Carol Soto <csoto@nvidia.com>,
Igor Russkikh <irusskikh@marvell.com>,
Dmitry Bogdanov <dbogdanov@marvell.com>,
Mark Starovoytov <mstarovo@pm.me>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] net: aquantia: Add missing descriptor cache invalidation on ATL2
Date: Mon, 24 Nov 2025 14:32:46 +0000 [thread overview]
Message-ID: <aSRsjhB3vbGdUyg0@horms.kernel.org> (raw)
In-Reply-To: <20251120041537.62184-1-kaihengf@nvidia.com>
On Thu, Nov 20, 2025 at 12:15:33PM +0800, Kai-Heng Feng wrote:
> ATL2 hardware was missing descriptor cache invalidation in hw_stop(),
> causing SMMU translation faults during device shutdown and module removal:
> [ 70.355743] arm-smmu-v3 arm-smmu-v3.5.auto: event 0x10 received:
> [ 70.361893] arm-smmu-v3 arm-smmu-v3.5.auto: 0x0002060000000010
> [ 70.367948] arm-smmu-v3 arm-smmu-v3.5.auto: 0x0000020000000000
> [ 70.374002] arm-smmu-v3 arm-smmu-v3.5.auto: 0x00000000ff9bc000
> [ 70.380055] arm-smmu-v3 arm-smmu-v3.5.auto: 0x0000000000000000
> [ 70.386109] arm-smmu-v3 arm-smmu-v3.5.auto: event: F_TRANSLATION client: 0001:06:00.0 sid: 0x20600 ssid: 0x0 iova: 0xff9bc000 ipa: 0x0
> [ 70.398531] arm-smmu-v3 arm-smmu-v3.5.auto: unpriv data write s1 "Input address caused fault" stag: 0x0
>
> Commit 7a1bb49461b1 ("net: aquantia: fix potential IOMMU fault after
> driver unbind") and commit ed4d81c4b3f2 ("net: aquantia: when cleaning
> hw cache it should be toggled") fixed cache invalidation for ATL B0, but
> ATL2 was left with only interrupt disabling. This allowed hardware to
> write to cached descriptors after DMA memory was unmapped, triggering
> SMMU faults. Once cache invalidation is applied to ATL2, the translation
> fault can't be observed anymore.
>
> Add shared aq_hw_invalidate_descriptor_cache() helper and use it in both
> ATL B0 and ATL2 hw_stop() implementations for consistent behavior.
>
> Fixes: e54dcf4bba3e ("net: atlantic: basic A2 init/deinit hw_ops")
> Tested-by: Carol Soto <csoto@nvidia.com>
> Signed-off-by: Kai-Heng Feng <kaihengf@nvidia.com>
Thanks for addressing my review of v1.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-11-24 14:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-20 4:15 [PATCH net v2] net: aquantia: Add missing descriptor cache invalidation on ATL2 Kai-Heng Feng
2025-11-24 14:32 ` Simon Horman [this message]
2025-11-25 11:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aSRsjhB3vbGdUyg0@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=csoto@nvidia.com \
--cc=davem@davemloft.net \
--cc=dbogdanov@marvell.com \
--cc=edumazet@google.com \
--cc=irusskikh@marvell.com \
--cc=kaihengf@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mstarovo@pm.me \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).