From: Hangbin Liu <liuhangbin@gmail.com>
To: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>
Cc: netdev@vger.kernel.org, Donald Hunter <donald.hunter@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
"Matthieu Baerts (NGI0)" <matttbe@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>,
Jacob Keller <jacob.e.keller@intel.com>,
Yuyang Huang <yuyanghuang@google.com>,
Daniel Borkmann <daniel@iogearbox.net>
Subject: Re: [PATCH net-next] netlink: specs: add big-endian byte-order for u32 IPv4 addresses
Date: Wed, 26 Nov 2025 06:36:04 +0000 [thread overview]
Message-ID: <aSaf1D-N5ONmnys8@fedora> (raw)
In-Reply-To: <8564b02f-18f9-4132-ab69-5ee1babeb18c@fiberby.net>
Hi,
On Tue, Nov 25, 2025 at 05:03:13PM +0000, Asbjørn Sloth Tønnesen wrote:
> I also checked how consistently defined the fields using the ipv6 display helper are,
> and it looks like they could use some realignment too. Obviously not for this fix.
>
> git grep -C6 'display-hint.*ipv6$' Documentation/netlink/specs/
The ip6gre spec shows
-
name: local
display-hint: ipv6
-
name: remote
display-hint: ipv6
The dump result looks good. So for others ipv6 field, what alignment should we
use? Should we add checks: min-len: 16? Do we need byte-order: big-endian?
Thanks
Hangbin
next prev parent reply other threads:[~2025-11-26 6:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-25 11:20 [PATCH net-next] netlink: specs: add big-endian byte-order for u32 IPv4 addresses Hangbin Liu
2025-11-25 17:03 ` Asbjørn Sloth Tønnesen
2025-11-26 6:36 ` Hangbin Liu [this message]
2025-11-26 13:32 ` Asbjørn Sloth Tønnesen
2025-11-27 2:14 ` Hangbin Liu
2025-11-27 3:31 ` Hangbin Liu
2025-11-27 1:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aSaf1D-N5ONmnys8@fedora \
--to=liuhangbin@gmail.com \
--cc=ast@fiberby.net \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=matttbe@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=yuyanghuang@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).