From: Ido Schimmel <idosch@idosch.org>
To: Antoine Tenart <atenart@kernel.org>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, andrew+netdev@lunn.ch,
netdev@vger.kernel.org, Liang Li <liali@redhat.com>,
Beniamino Galvani <b.galvani@gmail.com>
Subject: Re: [PATCH net v2] net: vxlan: prevent NULL deref in vxlan_xmit_one
Date: Wed, 26 Nov 2025 16:32:14 +0200 [thread overview]
Message-ID: <aScPbnXHCNrpu4u3@shredder> (raw)
In-Reply-To: <20251126102627.74223-1-atenart@kernel.org>
On Wed, Nov 26, 2025 at 11:26:25AM +0100, Antoine Tenart wrote:
> Neither sock4 nor sock6 pointers are guaranteed to be non-NULL in
> vxlan_xmit_one, e.g. if the iface is brought down. This can lead to the
> following NULL dereference:
>
> BUG: kernel NULL pointer dereference, address: 0000000000000010
> Oops: Oops: 0000 [#1] SMP NOPTI
> RIP: 0010:vxlan_xmit_one+0xbb3/0x1580
> Call Trace:
> vxlan_xmit+0x429/0x610
> dev_hard_start_xmit+0x55/0xa0
> __dev_queue_xmit+0x6d0/0x7f0
> ip_finish_output2+0x24b/0x590
> ip_output+0x63/0x110
>
> Mentioned commits changed the code path in vxlan_xmit_one and as a side
> effect the sock4/6 pointer validity checks in vxlan(6)_get_route were
> lost. Fix this by adding back checks.
>
> Since both commits being fixed were released in the same version (v6.7)
> and are strongly related, bundle the fixes in a single commit.
>
> Reported-by: Liang Li <liali@redhat.com>
> Fixes: 6f19b2c136d9 ("vxlan: use generic function for tunnel IPv4 route lookup")
> Fixes: 2aceb896ee18 ("vxlan: use generic function for tunnel IPv6 route lookup")
> Cc: Beniamino Galvani <b.galvani@gmail.com>
> Signed-off-by: Antoine Tenart <atenart@kernel.org>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Tested-by: Ido Schimmel <idosch@nvidia.com>
Tested using:
ip link add name vx0 up type vxlan id 10010 local 192.0.2.1 remote 198.51.100.1 dstport 4789
for i in $(seq 0 $(($(nproc) - 2))); do
taskset -c $i mausezahn vx0 -a own -b 00:11:22:33:44:55 -c 0 -q &
done
taskset -c $(($(nproc) - 1)) bash -c "while true; do ip link set dev vx0 down && ip link set dev vx0 up; done"
next prev parent reply other threads:[~2025-11-26 14:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-26 10:26 [PATCH net v2] net: vxlan: prevent NULL deref in vxlan_xmit_one Antoine Tenart
2025-11-26 14:32 ` Ido Schimmel [this message]
2025-11-28 2:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aScPbnXHCNrpu4u3@shredder \
--to=idosch@idosch.org \
--cc=andrew+netdev@lunn.ch \
--cc=atenart@kernel.org \
--cc=b.galvani@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=liali@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).