netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hangbin Liu <liuhangbin@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org
Subject: Re: [TEST] bond_macvlan_ipvlan.sh flakiness
Date: Thu, 27 Nov 2025 01:14:55 +0000	[thread overview]
Message-ID: <aSemD3xMfbVfps0D@fedora> (raw)
In-Reply-To: <20251126071930.76b42c57@kernel.org>

On Wed, Nov 26, 2025 at 07:19:30AM -0800, Jakub Kicinski wrote:
> On Tue, 18 Nov 2025 07:13:02 -0800 Jakub Kicinski wrote:
> > On Tue, 18 Nov 2025 06:03:17 +0000 Hangbin Liu wrote:
> > > > Hmm, this one is suspicious. I can reproduce the ping fail on local.
> > > > But no "otherhost" issue. I will check the failure recently.    
> > > 
> > > This looks like a time-sensitive issue, with
> > > 
> > > diff --git a/tools/testing/selftests/drivers/net/bonding/bond_macvlan_ipvlan.sh b/tools/testing/selftests/drivers/net/bonding/bond_macvlan_ipvlan.sh
> > > index c4711272fe45..947c85ec2cbb 100755
> > > --- a/tools/testing/selftests/drivers/net/bonding/bond_macvlan_ipvlan.sh
> > > +++ b/tools/testing/selftests/drivers/net/bonding/bond_macvlan_ipvlan.sh
> > > @@ -30,6 +30,7 @@ check_connection()
> > >         local message=${3}
> > >         RET=0
> > > 
> > > +       sleep 1
> > >         ip netns exec ${ns} ping ${target} -c 4 -i 0.1 &>/dev/null
> > >         check_err $? "ping failed"
> > >         log_test "${bond_mode}/${xvlan_type}_${xvlan_mode}: ${message}"
> > > 
> > > I run the test 100 times (vng with 4 cpus) and not able to reproduce it anymore.
> > > That maybe why debug kernel works good.  
> > 
> > I see. I queued up a local change to add a 0.25 sec wait. Let's wait 
> > a couple of days and see how much sleep we need here, this function 
> > is called 96 times if I'm counting right.
> 
> Hi Hangbin!
> 
> The 0.25 sec sleep was added locally 1 week ago and 0 flakes since.
> Would you mind submitting it officially?

Good to hear this. I will submit it.

Thanks
Hangbin

  reply	other threads:[~2025-11-27  1:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-14 16:20 [TEST] bond_macvlan_ipvlan.sh flakiness Jakub Kicinski
2025-11-17  8:24 ` Hangbin Liu
2025-11-18  6:03   ` Hangbin Liu
2025-11-18 15:13     ` Jakub Kicinski
2025-11-26 15:19       ` Jakub Kicinski
2025-11-27  1:14         ` Hangbin Liu [this message]
2025-11-27  1:18           ` Hangbin Liu
2025-11-27  1:41             ` Jakub Kicinski
2025-11-27  2:04               ` Hangbin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aSemD3xMfbVfps0D@fedora \
    --to=liuhangbin@gmail.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).