From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Maxime Chevallier <maxime.chevallier@bootlin.com>,
Oleksij Rempel <o.rempel@pengutronix.de>,
Jakub Kicinski <kuba@kernel.org>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Alexei Starovoitov <ast@kernel.org>,
Eric Dumazet <edumazet@google.com>, Rob Herring <robh@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Donald Hunter <donald.hunter@gmail.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Jonathan Corbet <corbet@lwn.net>,
John Fastabend <john.fastabend@gmail.com>,
Lukasz Majewski <lukma@denx.de>,
Stanislav Fomichev <sdf@fomichev.me>,
Paolo Abeni <pabeni@redhat.com>, Jiri Pirko <jiri@resnulli.us>,
Jesper Dangaard Brouer <hawk@kernel.org>,
Divya.Koppera@microchip.com,
Kory Maincent <kory.maincent@bootlin.com>,
Vadim Fedorenko <vadim.fedorenko@linux.dev>,
netdev@vger.kernel.org, Sabrina Dubroca <sd@queasysnail.net>,
linux-kernel@vger.kernel.org, kernel@pengutronix.de,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH net-next v8 1/1] Documentation: net: add flow control guide and document ethtool API
Date: Thu, 27 Nov 2025 16:18:34 +0000 [thread overview]
Message-ID: <aSh52mXPMr3ijY-m@shell.armlinux.org.uk> (raw)
In-Reply-To: <b4ae88a8-3db7-434a-92d8-90734f6d7682@lunn.ch>
On Thu, Nov 27, 2025 at 04:48:42PM +0100, Andrew Lunn wrote:
> Maybe for the last year, when i have seen broken pause, i've been
> reporting the problems but also pushing developers towards
> phylink. phylink also does all the business logic for EEE, and is
> starting to get WoL support.
Not "starting" - it has a full implementation for it, unless I'm
missing something.
What is missing is the upgrade of phylib drivers to a more modern WoL
approach where they actually tell us that they truly are capable of
waking the system - I don't think that's something we has core code
maintainers can really get involved with, but push people to do the
necessary leg work to make it so.
We have far too many phylib drivers that implement the get_wol
without a thought to whether the hardware can actually wake the
system, and that is completely incompatible with having logic to
determine whether a certain WoL configuration should be set on the
PHY or the MAC.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-11-27 16:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-19 14:03 [PATCH net-next v8 1/1] Documentation: net: add flow control guide and document ethtool API Oleksij Rempel
2025-11-26 2:19 ` Jakub Kicinski
2025-11-26 8:36 ` Oleksij Rempel
2025-11-26 22:42 ` Jakub Kicinski
2025-11-27 9:20 ` Oleksij Rempel
2025-11-27 15:07 ` Andrew Lunn
2025-11-27 15:31 ` Maxime Chevallier
2025-11-27 15:48 ` Andrew Lunn
2025-11-27 16:18 ` Russell King (Oracle) [this message]
2025-11-27 16:14 ` Russell King (Oracle)
2025-11-28 1:21 ` Jakub Kicinski
2025-11-27 16:10 ` Russell King (Oracle)
2025-11-28 1:27 ` Russell King (Oracle)
2025-11-28 1:47 ` Russell King (Oracle)
2025-11-28 8:55 ` Oleksij Rempel
2025-11-28 9:35 ` Russell King (Oracle)
2025-11-28 18:32 ` Jakub Kicinski
2025-11-28 20:16 ` Andrew Lunn
2025-11-28 20:38 ` Russell King (Oracle)
2025-11-28 22:17 ` Jakub Kicinski
2025-12-01 9:49 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aSh52mXPMr3ijY-m@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=Divya.Koppera@microchip.com \
--cc=andrew@lunn.ch \
--cc=ast@kernel.org \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hawk@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=jiri@resnulli.us \
--cc=john.fastabend@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kory.maincent@bootlin.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukma@denx.de \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=sd@queasysnail.net \
--cc=sdf@fomichev.me \
--cc=vadim.fedorenko@linux.dev \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).