From: Simon Horman <horms@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: Claudiu Manoil <claudiu.manoil@nxp.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Wei Fang <wei.fang@nxp.com>, Clark Wang <xiaoning.wang@nxp.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev
Subject: Re: [PATCH net-next 3/3] net: enetc: convert to use .get_rx_ring_count
Date: Sun, 30 Nov 2025 15:22:03 +0000 [thread overview]
Message-ID: <aSxhG-WcSMv9DbLn@horms.kernel.org> (raw)
In-Reply-To: <20251128-gxring_freescale-v1-3-22a978abf29e@debian.org>
On Fri, Nov 28, 2025 at 05:11:47AM -0800, Breno Leitao wrote:
> Convert the enetc driver to use the new .get_rx_ring_count
> ethtool operation instead of implementing .get_rxnfc for handling
> ETHTOOL_GRXRINGS command. This simplifies the code in two ways:
>
> 1. For enetc_get_rxnfc(): Remove the ETHTOOL_GRXRINGS case from the
> switch statement while keeping other cases for classifier rules.
>
> 2. For enetc4_get_rxnfc(): Remove it completely and use
> enetc_get_rxnfc() instead.
>
> Now on, enetc_get_rx_ring_count() is the callback that returns the
> number of RX rings for enetc driver.
>
> Also, remove the documentation around enetc4_get_rxnfc(), which was not
> matching what the function did(?!).
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-11-30 15:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-28 13:11 [PATCH net-next 0/3] net: freescale: migrate to .get_rx_ring_count() ethtool callback Breno Leitao
2025-11-28 13:11 ` [PATCH net-next 1/3] net: gianfar: convert to use .get_rx_ring_count Breno Leitao
2025-11-30 15:21 ` Simon Horman
2025-11-28 13:11 ` [PATCH net-next 2/3] net: dpaa2: " Breno Leitao
2025-11-30 15:21 ` Simon Horman
2025-11-28 13:11 ` [PATCH net-next 3/3] net: enetc: " Breno Leitao
2025-11-30 15:22 ` Simon Horman [this message]
2025-12-01 20:00 ` [PATCH net-next 0/3] net: freescale: migrate to .get_rx_ring_count() ethtool callback patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aSxhG-WcSMv9DbLn@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=imx@lists.linux.dev \
--cc=ioana.ciornei@nxp.com \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).